feat: add toggle to control ComfyUI version-update notifications (default off) by Kosinkadink · Pull Request #1205 · Comfy-Org/Comfy-Desktop

Kosinkadink · 2026-06-26T10:04:56Z

Adds a Show ComfyUI version updates toggle (Updates settings tab, default off) that injects the show_version_updates feature flag into the embedded ComfyUI at launch. The flag seeds the frontend's Comfy.Notification.ShowVersionUpdates default. Comfy Desktop has its own update / What's-New UI, so the in-frontend release notifications are off by default; a user can opt in via this toggle. The ComfyUI setting still overrides it.

Changes

settings.ts — new showComfyVersionUpdates setting (default off).
desktopFeatureFlags() — injects show_version_updates=<bool> from the setting.
registerSettingsHandlers.ts / titlePopup.ts — render the toggle in the Updates tab (with a shared field-id set so the snapshot grouping can't drift).
locales/en.json + locales/zh.json — labels/description.
Unit test for the injected flag.

The flag is only injected when the running ComfyUI advertises it via --list-feature-flags (existing registry guard), so it is a no-op on older ComfyUI.

Cross-repo dependencies

Add show_version_updates CLI feature flag ComfyUI#14646 — registers the show_version_updates flag (default off).
fix: gate version-update notifications on the ShowVersionUpdates setting (default off on local installs) ComfyUI_frontend#13171 — gates the notifications on the setting and reads the flag as its default.

Adds a 'Show ComfyUI version updates' toggle (Updates settings, default on) that injects the show_version_updates feature flag into the embedded ComfyUI at launch, seeding its Comfy.Notification.ShowVersionUpdates default. Lets Desktop users suppress the in-frontend release notifications in favor of Desktop's own update UI; the ComfyUI setting still overrides. Only injected when the running ComfyUI advertises the flag. Amp-Thread-ID: https://ampcode.com/threads/T-019f0347-dc00-723a-a4d2-558539329035 Co-authored-by: Amp <amp@ampcode.com>

coderabbitai · 2026-06-26T10:05:05Z

Warning

Review limit reached

@Kosinkadink, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 49 seconds. Learn how PR review limits work.

To continue reviewing without waiting, enable usage-based billing in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 110d7fdb-a183-4e28-af4a-6a8c6c414a93

📥 Commits

Reviewing files that changed from the base of the PR and between deb1314 and 18ad4f5.

📒 Files selected for processing (6)

locales/en.json
locales/zh.json
src/main/lib/ipc/registerSettingsHandlers.ts
src/main/lib/ipc/sessionActions/launch.ts
src/main/popups/titlePopup.ts
src/main/settings.ts

📝 Walkthrough

Walkthrough

Adds a showComfyVersionUpdates setting, updates settings presentation and popup grouping, and passes the value into launch-time ComfyUI feature flags. English and Chinese strings and launch tests are updated for the new toggle.

Changes

ComfyUI version-update setting

Layer / File(s)	Summary
Setting contract and localized text `src/main/settings.ts`, `locales/en.json`, `locales/zh.json`	Adds `showComfyVersionUpdates` to the settings type and schema, plus English and Chinese label and description strings.
Settings section and popup snapshot `src/main/lib/ipc/registerSettingsHandlers.ts`, `src/main/popups/titlePopup.ts`	Adds `showComfyVersionUpdates` to the general settings section and includes it in the title popup’s desktop update field grouping.
Launch flag wiring and validation `src/main/lib/ipc/sessionActions/launch.ts`, `src/main/lib/ipc/sessionActions/launch.test.ts`	Extends `desktopFeatureFlags` with `show_version_updates`, passes the new setting from launch-time settings lookup, and updates tests for the new argument and emitted flag value.

Sequence Diagram(s)

sequenceDiagram
  participant "launch.ts"
  participant "settings.get"
  participant desktopFeatureFlags
  participant "ComfyUI frontend"
  "launch.ts"->>"settings.get": read showComfyVersionUpdates
  "launch.ts"->>desktopFeatureFlags: pass showVersionUpdates boolean
  desktopFeatureFlags->>"ComfyUI frontend": inject show_version_updates

Possibly related PRs

Comfy-Org/Comfy-Desktop#1143: Also extends desktopFeatureFlags in src/main/lib/ipc/sessionActions/launch.ts to inject conditional ComfyUI feature flags.

Suggested reviewers

deepme987
MaanilVerma

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR implements `#1194` by adding the new version-updates toggle, settings wiring, and feature-flag injection to change the frontend default.
Out of Scope Changes check	✅ Passed	All changes support the new update-notification toggle and its plumbing; no unrelated scope creep is evident.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feature/show-version-updates-flag

✨ Simplify code

Create PR with simplified code
Commit simplified code in branch feature/show-version-updates-flag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Kosinkadink · 2026-06-26T10:26:00Z

@coderabbitai review

coderabbitai · 2026-06-26T10:26:10Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Kosinkadink · 2026-06-26T10:27:23Z

@coderabbitai full review

coderabbitai · 2026-06-26T10:27:29Z

✅ Action performed

Full review finished.

Kosinkadink · 2026-06-26T11:05:41Z

@coderabbitai review

coderabbitai · 2026-06-26T11:05:47Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-06-26T11:10:39Z

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{}

Kosinkadink · 2026-06-26T11:39:59Z

@coderabbitai review

coderabbitai · 2026-06-26T11:40:05Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Kosinkadink · 2026-06-26T12:13:23Z

@coderabbitai review

coderabbitai · 2026-06-26T12:13:30Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/main/popups/titlePopup.ts`:
- Around line 2074-2082: The filtering in titlePopup.ts duplicates the same
update-field IDs in both desktopUpdateFields and generalFields, which risks the
sections drifting apart when another toggle is added. Extract the update-related
IDs into one shared symbol near the generalRaw filters, then have both the
desktopUpdateFields and generalFields predicates reference that shared set so
the grouping logic stays consistent.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 41361887-f045-401a-9274-737c6257500f

📥 Commits

Reviewing files that changed from the base of the PR and between 588b072 and deb1314.

📒 Files selected for processing (7)

locales/en.json
locales/zh.json
src/main/lib/ipc/registerSettingsHandlers.ts
src/main/lib/ipc/sessionActions/launch.test.ts
src/main/lib/ipc/sessionActions/launch.ts
src/main/popups/titlePopup.ts
src/main/settings.ts

Amp-Thread-ID: https://ampcode.com/threads/T-019f0347-dc00-723a-a4d2-558539329035 Co-authored-by: Amp <amp@ampcode.com>

Kosinkadink · 2026-06-26T22:46:43Z

Still need to test end-to-end

christian-byrne

LGTM but it would make sense to use the same settings key as the frontend for this IMO.

coderabbitai Bot requested review from MaanilVerma and deepme987 June 26, 2026 11:06

coderabbitai Bot reviewed Jun 26, 2026

View reviewed changes

Comment thread src/main/popups/titlePopup.ts Outdated

Kosinkadink and others added 2 commits June 26, 2026 05:24

refactor: dedupe update-field IDs in settings snapshot

09a55e3

Amp-Thread-ID: https://ampcode.com/threads/T-019f0347-dc00-723a-a4d2-558539329035 Co-authored-by: Amp <amp@ampcode.com>

feat: default showComfyVersionUpdates to off

18ad4f5

Amp-Thread-ID: https://ampcode.com/threads/T-019f0347-dc00-723a-a4d2-558539329035 Co-authored-by: Amp <amp@ampcode.com>

Kosinkadink mentioned this pull request Jun 26, 2026

Add show_version_updates CLI feature flag Comfy-Org/ComfyUI#14646

Open

Kosinkadink changed the title ~~feat: add toggle to control ComfyUI version-update notifications~~ feat: add toggle to control ComfyUI version-update notifications (default off) Jun 26, 2026

christian-byrne approved these changes Jun 27, 2026

View reviewed changes

christian-byrne assigned Kosinkadink Jun 27, 2026

Uh oh!

Conversation

Kosinkadink commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Cross-repo dependencies

Uh oh!

coderabbitai Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Uh oh!

Kosinkadink commented Jun 26, 2026

Uh oh!

coderabbitai Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kosinkadink commented Jun 26, 2026

Uh oh!

coderabbitai Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kosinkadink commented Jun 26, 2026

Uh oh!

coderabbitai Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 26, 2026

Uh oh!

Kosinkadink commented Jun 26, 2026

Uh oh!

coderabbitai Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kosinkadink commented Jun 26, 2026

Uh oh!

coderabbitai Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Kosinkadink commented Jun 26, 2026

Uh oh!

christian-byrne left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Kosinkadink commented Jun 26, 2026 •

edited

Loading

coderabbitai Bot commented Jun 26, 2026 •

edited

Loading

coderabbitai Bot commented Jun 26, 2026 •

edited

Loading

coderabbitai Bot commented Jun 26, 2026 •

edited

Loading

coderabbitai Bot commented Jun 26, 2026 •

edited

Loading

coderabbitai Bot commented Jun 26, 2026 •

edited

Loading

coderabbitai Bot commented Jun 26, 2026 •

edited

Loading