Skip to content

Revert "feat(auth): sign in via cloud login page with short-lived desktop login codes (GTM-93)"#1279

Merged
Kosinkadink merged 1 commit into
mainfrom
revert-1222-benceruleanlu/gtm-93-desktop-login-code
Jul 17, 2026
Merged

Revert "feat(auth): sign in via cloud login page with short-lived desktop login codes (GTM-93)"#1279
Kosinkadink merged 1 commit into
mainfrom
revert-1222-benceruleanlu/gtm-93-desktop-login-code

Conversation

@deepme987

@deepme987 deepme987 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Reverts #1222
Unblocks desktop release dependency from FE

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c7740dac-2925-4592-8875-1195e422bcb3

📥 Commits

Reviewing files that changed from the base of the PR and between ebaa998 and 788d85b.

📒 Files selected for processing (21)
  • src/main/auth/desktopLoginCode/client.test.ts
  • src/main/auth/desktopLoginCode/client.ts
  • src/main/auth/desktopLoginCode/customTokenSignIn.test.ts
  • src/main/auth/desktopLoginCode/customTokenSignIn.ts
  • src/main/auth/desktopLoginCode/index.test.ts
  • src/main/auth/desktopLoginCode/index.ts
  • src/main/auth/desktopLoginCode/origins.test.ts
  • src/main/auth/desktopLoginCode/origins.ts
  • src/main/auth/desktopLoginCode/pkce.test.ts
  • src/main/auth/desktopLoginCode/pkce.ts
  • src/main/auth/desktopLoginCode/testHelpers.ts
  • src/main/auth/firebaseBridge/flowControl.ts
  • src/main/auth/firebaseBridge/flowShared.ts
  • src/main/auth/firebaseBridge/flowState.ts
  • src/main/auth/firebaseBridge/index.test.ts
  • src/main/auth/firebaseBridge/index.ts
  • src/main/auth/firebaseBridge/oauth.ts
  • src/main/auth/firebaseBridge/restoreParentWindow.test.ts
  • src/main/auth/firebaseBridge/restoreParentWindow.ts
  • src/main/host/createHostWindow.test.ts
  • src/main/host/createHostWindow.ts
 ________________________________________________________________________________________________________________________________________
< Use saboteurs to test your testing. Introduce bugs on purpose in a separate copy of the source to verify that testing will catch them. >
 ----------------------------------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-1222-benceruleanlu/gtm-93-desktop-login-code
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch revert-1222-benceruleanlu/gtm-93-desktop-login-code

Comment @coderabbitai help to get the list of available commands.

@Kosinkadink
Kosinkadink merged commit 3ab9a19 into main Jul 17, 2026
11 of 12 checks passed
@Kosinkadink
Kosinkadink deleted the revert-1222-benceruleanlu/gtm-93-desktop-login-code branch July 17, 2026 21:30
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants