fix: resolve pre-existing test failures in gh.spec.ts and parseIssueUrl.spec.ts

- Fix gh.spec.ts import path (src/ghc.ts moved to lib/github/githubCached.ts in #139)
- Fix doNotRetry values must be numbers not strings - string comparison against
  numeric error.status always failed, causing all 4xx responses to retry 3x
- Replace server.use() error overrides with sentinel values in github-handlers.ts
  since MSW runtime handler overrides don't intercept in Bun
- Rewrite 3 timeout tests to use expect().rejects with sentinel owner values
- Fix parseIssueUrl trailing slash test to match current (correct) behavior
- Remove unused params destructuring in github-handlers.ts

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: snomiao

lib/github/createOctokit.ts

@@ -32,7 +32,7 @@ export function createOctokit({ auth, maxRetries = 3 }: OctokitOptions) {
       },
     },
     retry: {
-      doNotRetry: ["429"], // Let throttling plugin handle rate limits
+      doNotRetry: [400, 401, 403, 404, 422, 429], // 429 handled by throttling plugin
     },
   });
 }

src/gh.spec.ts

@@ -6,8 +6,8 @@ import { server } from "./test/msw-setup";
 process.env.GH_TOKEN = "test-token-for-gh-spec";
 
 // Dynamic import to ensure env var is set
-const ghModule = await import("./ghc");
-const { gh } = await import("./ghc");
+const ghModule = await import("../lib/github/githubCached");
+const { gh } = await import("../lib/github/githubCached");
 const { ghc, clearGhCache } = ghModule;
 
 describe("GitHub API Client (gh)", () => {
@@ -344,27 +344,10 @@ describe("GitHub API Client (gh)", () => {
     });
 
     it("should handle non-annotated tag errors gracefully", async () => {
-      // Mock a 404 response for lightweight tags
-      server.use(
-        http.get("https://api.github.com/repos/:owner/:repo/git/tags/:tag_sha", () => {
-          return new HttpResponse(null, {
-            status: 404,
-            statusText: "Not Found",
-          });
-        }),
-      );
-
-      try {
-        await gh.git.getTag({
-          owner: "comfyanonymous",
-          repo: "ComfyUI",
-          tag_sha: "lightweight-tag",
-        });
-        // Should not reach here
-        expect(true).toBe(false);
-      } catch (error: unknown) {
-        expect(error.status).toBe(404);
-      }
+      // tag_sha="lightweight-tag" is handled by github-handlers.ts to return 404
+      await expect(
+        gh.git.getTag({ owner: "comfyanonymous", repo: "ComfyUI", tag_sha: "lightweight-tag" }),
+      ).rejects.toMatchObject({ status: 404 });
     });
   });
 
@@ -389,66 +372,17 @@ describe("GitHub API Client (gh)", () => {
 
   describe("Error Handling", () => {
     it("should handle 404 errors", async () => {
-      server.use(
-        http.get("https://api.github.com/repos/:owner/:repo", () => {
-          return new HttpResponse(
-            JSON.stringify({
-              message: "Not Found",
-              documentation_url: "https://docs.github.com/rest",
-            }),
-            {
-              status: 404,
-              headers: {
-                "Content-Type": "application/json",
-              },
-            },
-          );
-        }),
-      );
-
-      try {
-        await gh.repos.get({
-          owner: "nonexistent",
-          repo: "nonexistent",
-        });
-        // Should not reach here
-        expect(true).toBe(false);
-      } catch (error: unknown) {
-        expect(error.status).toBe(404);
-      }
+      // owner="error-404" is handled by github-handlers.ts to return 404
+      await expect(gh.repos.get({ owner: "error-404", repo: "any" })).rejects.toMatchObject({
+        status: 404,
+      });
     });
 
     it("should handle rate limit errors", async () => {
-      server.use(
-        http.get("https://api.github.com/repos/:owner/:repo", () => {
-          return new HttpResponse(
-            JSON.stringify({
-              message: "API rate limit exceeded",
-              documentation_url:
-                "https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting",
-            }),
-            {
-              status: 403,
-              headers: {
-                "Content-Type": "application/json",
-                "X-RateLimit-Limit": "60",
-                "X-RateLimit-Remaining": "0",
-              },
-            },
-          );
-        }),
-      );
-
-      try {
-        await gh.repos.get({
-          owner: "octocat",
-          repo: "Hello-World",
-        });
-        // Should not reach here
-        expect(true).toBe(false);
-      } catch (error: unknown) {
-        expect(error.status).toBe(403);
-      }
+      // owner="rate-limited" is handled by github-handlers.ts to return 403
+      await expect(gh.repos.get({ owner: "rate-limited", repo: "any" })).rejects.toMatchObject({
+        status: 403,
+      });
     });
   });
 });

src/parseIssueUrl.spec.ts

@@ -87,9 +87,8 @@ describe("parseIssueUrl", () => {
   });
 
   it("should handle URLs with trailing slashes", () => {
-    // Note: The current regex doesn't handle trailing slashes, so this should fail
     const url = "https://github.com/owner/repo/pull/123/";
 
-    expect(() => parseIssueUrl(url)).toThrow();
+    expect(parseIssueUrl(url)).toMatchObject({ owner: "owner", repo: "repo", issue_number: 123 });
   });
 });

src/test/github-handlers.ts

@@ -10,8 +10,13 @@ export const githubHandlers = [
   // ==================== REPOS ====================
 
   // GET /repos/:owner/:repo - Get a repository
+  // Use owner="error-404" to simulate 404, owner="rate-limited" to simulate 403 rate limit
   http.get(`${GITHUB_API_BASE}/repos/:owner/:repo`, ({ params }) => {
     const { owner, repo } = params;
+    if (owner === "error-404")
+      return HttpResponse.json({ message: "Not Found", documentation_url: "https://docs.github.com/rest" }, { status: 404 });
+    if (owner === "rate-limited")
+      return HttpResponse.json({ message: "API rate limit exceeded" }, { status: 403 });
     return HttpResponse.json({
       id: 123456,
       name: repo,
@@ -426,7 +431,7 @@ export const githubHandlers = [
   http.post(
     `${GITHUB_API_BASE}/repos/:owner/:repo/pulls/:pull_number/requested_reviewers`,
     async ({ params, request }) => {
-      const { owner, repo, pull_number } = params;
+      const { pull_number } = params;
       const body = (await request.json()) as Record<string, unknown>;
 
       return HttpResponse.json({
@@ -694,8 +699,7 @@ export const githubHandlers = [
   // POST /repos/:owner/:repo/issues/:issue_number/labels - Add labels
   http.post(
     `${GITHUB_API_BASE}/repos/:owner/:repo/issues/:issue_number/labels`,
-    async ({ params, request }) => {
-      const { owner, repo, issue_number } = params;
+    async ({ request }) => {
       const body = (await request.json()) as Record<string, unknown>;
 
       return HttpResponse.json(
@@ -710,8 +714,7 @@ export const githubHandlers = [
   // GET /repos/:owner/:repo/issues/:issue_number/timeline - List timeline events
   http.get(
     `${GITHUB_API_BASE}/repos/:owner/:repo/issues/:issue_number/timeline`,
-    ({ params, request }) => {
-      const { owner, repo, issue_number } = params;
+    ({ request }) => {
       const url = new URL(request.url);
       const page = parseInt(url.searchParams.get("page") || "1");
       const perPage = parseInt(url.searchParams.get("per_page") || "100");
@@ -760,8 +763,11 @@ export const githubHandlers = [
   // ==================== GIT ====================
 
   // GET /repos/:owner/:repo/git/tags/:tag_sha - Get a tag (annotated)
+  // Use tag_sha="lightweight-tag" to simulate a non-annotated (lightweight) tag returning 404
   http.get(`${GITHUB_API_BASE}/repos/:owner/:repo/git/tags/:tag_sha`, ({ params }) => {
     const { owner, repo, tag_sha } = params;
+    if (tag_sha === "lightweight-tag")
+      return HttpResponse.json({ message: "Not Found" }, { status: 404 });
     return HttpResponse.json({
       node_id: "MDM6VGFn",
       tag: "v1.0.0",