refactor(backport): rename labels to no-backport-needed[-cloud|-core] (#183)

Rename backport dismissal labels for clarity:
- `core-backport-not-needed` → `no-backport-needed-core`
- `cloud-backport-not-needed` → `no-backport-needed-cloud`
- Add general `no-backport-needed` label that dismisses all targets

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: snomiao

app/tasks/gh-frontend-backport-checker/index.spec.ts

@@ -300,31 +300,39 @@ describe("GithubFrontendBackportCheckerTask", () => {
   });
 
   describe("backport-not-needed labels", () => {
+    const backportNotNeededLabel = "no-backport-needed";
     const backportNotNeededLabels: Record<string, string> = {
-      core: "core-backport-not-needed",
-      cloud: "cloud-backport-not-needed",
+      core: "no-backport-needed-core",
+      cloud: "no-backport-needed-cloud",
     };
 
     function hasBackportNotNeededLabel(labels: string[], targetPrefix: string): boolean {
+      if (labels.some((l) => l.toLowerCase() === backportNotNeededLabel.toLowerCase())) return true;
       const notNeededLabel = backportNotNeededLabels[targetPrefix];
       if (!notNeededLabel) return false;
       return labels.some((l) => l.toLowerCase() === notNeededLabel.toLowerCase());
     }
 
-    it("should detect core-backport-not-needed label", () => {
-      const labels = ["bug", "core-backport-not-needed", "core/1.4"];
+    it("should detect no-backport-needed-core label", () => {
+      const labels = ["bug", "no-backport-needed-core", "core/1.4"];
       expect(hasBackportNotNeededLabel(labels, "core")).toBe(true);
       expect(hasBackportNotNeededLabel(labels, "cloud")).toBe(false);
     });
 
-    it("should detect cloud-backport-not-needed label", () => {
-      const labels = ["bug", "cloud-backport-not-needed", "cloud/1.36"];
+    it("should detect no-backport-needed-cloud label", () => {
+      const labels = ["bug", "no-backport-needed-cloud", "cloud/1.36"];
       expect(hasBackportNotNeededLabel(labels, "cloud")).toBe(true);
       expect(hasBackportNotNeededLabel(labels, "core")).toBe(false);
     });
 
+    it("should detect general no-backport-needed label for all targets", () => {
+      const labels = ["bug", "no-backport-needed"];
+      expect(hasBackportNotNeededLabel(labels, "core")).toBe(true);
+      expect(hasBackportNotNeededLabel(labels, "cloud")).toBe(true);
+    });
+
     it("should be case insensitive", () => {
-      const labels = ["Core-Backport-Not-Needed"];
+      const labels = ["No-Backport-Needed-Core"];
       expect(hasBackportNotNeededLabel(labels, "core")).toBe(true);
     });
 
@@ -334,8 +342,8 @@ describe("GithubFrontendBackportCheckerTask", () => {
       expect(hasBackportNotNeededLabel(labels, "cloud")).toBe(false);
     });
 
-    it("should return false for unknown target prefix", () => {
-      const labels = ["core-backport-not-needed"];
+    it("should return false for unknown target prefix without general label", () => {
+      const labels = ["no-backport-needed-core"];
       expect(hasBackportNotNeededLabel(labels, "unknown")).toBe(false);
     });
   });

app/tasks/gh-frontend-backport-checker/index.ts

@@ -64,7 +64,7 @@ import { slackCached } from "@/lib";
  *
  *    c) PER-TARGET-BRANCH STATUS — only runs when `backportStatusRaw` is
  *       "needed". For each labeled target branch:
- *       - Checks for `*-backport-not-needed` labels (e.g. `core-backport-not-needed`)
+ *       - Checks for `no-backport-needed[-core|-cloud]` labels
  *         → marks that target as "not-needed"
  *       - Uses `compareCommits(target_branch, commit_sha)` to check if the
  *         commit already exists on that branch:
@@ -126,10 +126,11 @@ import { slackCached } from "@/lib";
  *   from bots (username ending in `bot` or `[bot]`) are excluded to avoid
  *   false positives from automated messages.
  *
- * • BACKPORT-NOT-NEEDED LABELS — per-target dismissal labels like
- *   `core-backport-not-needed` override the per-branch status to "not-needed",
- *   even if the commit hasn't been cherry-picked. When ALL targets are
- *   dismissed this way, the overall status becomes "not-needed".
+ * • BACKPORT-NOT-NEEDED LABELS — `no-backport-needed` dismisses all targets;
+ *   per-target labels `no-backport-needed-core` / `no-backport-needed-cloud`
+ *   override individual branch status to "not-needed", even if the commit
+ *   hasn't been cherry-picked. When ALL targets are dismissed, the overall
+ *   status becomes "not-needed".
  *
  * • DIVERGED BRANCH (backport PR detection) — when the target branch has
  *   diverged from the commit (common for long-lived stable branches), the
@@ -183,10 +184,11 @@ const config = {
   // 3. backport labels on PRs
   backportLabels: ["needs-backport"],
 
-  // labels that dismiss backport requirements per target
+  // labels that dismiss backport requirements per target (or all targets)
+  backportNotNeededLabel: "no-backport-needed",
   backportNotNeededLabels: {
-    core: "core-backport-not-needed",
-    cloud: "cloud-backport-not-needed",
+    core: "no-backport-needed-core",
+    cloud: "no-backport-needed-cloud",
   } as Record<string, string>,
 
   // 5. detect backport mentions
@@ -463,6 +465,10 @@ async function resolveSlackTagForAuthor(githubUsername?: string): Promise<string
 
 /** Check if a PR has a backport-not-needed label for a given target prefix (e.g. "core" or "cloud") */
 function hasBackportNotNeededLabel(labels: string[], targetPrefix: string): boolean {
+  // General label dismisses all targets
+  if (labels.some((l) => l.toLowerCase() === config.backportNotNeededLabel.toLowerCase()))
+    return true;
+  // Per-target label
   const notNeededLabel = config.backportNotNeededLabels[targetPrefix];
   if (!notNeededLabel) return false;
   return labels.some((l) => l.toLowerCase() === notNeededLabel.toLowerCase());
@@ -593,7 +599,7 @@ async function processTask(
 
           const backportTargetStatus = await sflow(targetBranches)
             .map(async (branchName) => {
-              // Check for *-backport-not-needed labels first (e.g. "core/1.4" → prefix "core")
+              // Check for no-backport-needed[-core|-cloud] labels first (e.g. "core/1.4" → prefix "core")
               const targetPrefix = branchName.split("/")[0];
               if (hasBackportNotNeededLabel(labels, targetPrefix)) {
                 logger.debug(