refactor: clean up coreping implementation and improve spam handling (#115)

* refactor: extract slack message URL parsing and add coreping spam cleanup improvements

- Extract slackMessageUrlParse and slackMessageUrlStringify to separate module for reusability
- Add 23-hour cooldown between new coreping messages to prevent spam
- Improve spam cleanup function with user confirmation before deletion
- Add confirm utility function to lib/utils.ts for interactive prompts
- Update imports across affected files

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Update lib/utils.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update app/tasks/coreping/coreping.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update app/tasks/coreping/coreping.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update app/tasks/gh-design/slackMessageUrlParse.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: remove space in slack message URL and improve spam cleanup confirmation

- Remove extra space in Slack message URL formatting for CorePing notifications
- Add explicit abort handling for spam cleanup confirmation dialog

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Update app/tasks/gh-design/slackMessageUrlParse.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update app/tasks/gh-desktop-release-notification/upsertSlackMessage.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

app/tasks/coreping/coreping.ts

@@ -21,6 +21,8 @@ import { yaml } from "@/src/utils/yaml";
 import { upsertSlackMessage } from "../gh-desktop-release-notification/upsertSlackMessage";
 import { getSlack, slack } from "@/src/slack";
 import { slackCached } from "@/src/slack/slackCached";
+import { slackMessageUrlParse } from "../gh-design/slackMessageUrlParse";
+import { confirm } from "@/lib/utils";
 
 // yeah, if the bot could ping when updates have been made to a previously-reviewed PR, would be extremely helpful
 
@@ -139,6 +141,7 @@ if (import.meta.main) {
 	// const url = "https://github.com/comfyanonymous/ComfyUI/pull/8351";
 	// await determinePullRequestReviewStatus(url);
 
+	// await _cleanSpammyMessages20251117()
 	await runCorePingTaskFull();
 	// await runCorePingTaskIncremental();
 	// reviewCommentsCheckpoint()
@@ -325,7 +328,7 @@ async function runCorePingTaskFull() {
 
 	// console.log("ready to send slack message to notify @comfy");
 	// console.log(processedTasks);
-	const tail = `Sent from < https://github.com/Comfy-Org/Comfy-PR/blob/main/app/tasks/coreping/coreping.ts|CorePing.ts> by <@snomiao>`;
+	const tail = `Sent from <https://github.com/Comfy-Org/Comfy-PR/blob/main/app/tasks/coreping/coreping.ts|CorePing.ts> by <@snomiao>`;
 	const notifyMessage = !pendingCorePRs.length
 		? `Congratulations! All Core/Important PRs are reviewed! 🎉🎉🎉 \n${tail}`
 		: `Hey <@comfy>, Here's x${pendingCorePRs.length} Core/Important PRs waiting your feedback!\n\n${pendingCorePRs.map((pr) => pr.statusMsg || `- <${pr.url}|${pr.title}> ${pr.labels}`).join("\n")}\n\n${tail}`;
@@ -335,7 +338,13 @@ async function runCorePingTaskFull() {
 	// // send or update slack message
 	let meta = await Meta.$upsert({});
 
-	// can only post new message: tz: PST,  day: working day + sat, time: 10-12am
+	const lastMessageTsDate = meta.lastSlackMessage?.url
+		? new Date(+(slackMessageUrlParse(meta.lastSlackMessage.url).ts) * 1000,)
+		: null;
+
+	// can only post new message when:
+	// 1. tz: PST,  day: working day + sat, time: 10-12am
+	// 2. or last message sent time( Note: not edited time ) >23h ago (if have last msg)
 	const canPostNewMessage = (() => {
 		const now = new Date();
 		const pstTime = new Date(
@@ -350,7 +359,10 @@ async function runCorePingTaskFull() {
 		const isValidTime = hour >= 10 && hour < 12;
 
 		return isValidDay && isValidTime;
-	})();
+	})() && (
+			!lastMessageTsDate ||
+			Date.now() - lastMessageTsDate.getTime() >= 23 * 60 * 60 * 1000
+		);
 
 	const canUpdateExistingMessage =
 		meta.lastSlackMessage?.sendAt &&
@@ -487,9 +499,9 @@ async function processPullRequestCorePingTask(
 }
 
 async function _cleanSpammyMessages20251117() {
-	// list 2025-11-16 2:11 to 3:49 (in HKT)
-	const st = new Date('2025-11-16T02:00:00+0800');
-	const et = new Date('2025-11-16T03:50:00+0800');
+	// list 2025-11-18 2:00 to 3:55 (in HKT)
+	const st = new Date('2025-11-18T02:00:00+0800');
+	const et = new Date('2025-11-18T03:55:00+0800');
 	console.log(`fetch slack messages from ${st.toISOString()} to ${et.toISOString()}`);
 	// slack.history.list(getslackchannel)
 	const channel = await pageFlow(undefined as string | undefined, async (cursor, limit = 3) => {
@@ -510,6 +522,7 @@ async function _cleanSpammyMessages20251117() {
 		// .log(e => yaml.stringify({}))
 		.toAtLeastOne()
 
+	console.log('checking messages sent by ComfyPR-Bot:', comfyPrBot.id, comfyPrBot.name);
 	const myspammessages = await pageFlow(undefined as string | undefined, async (cursor, limit = 100) => {
 		const resp = await slackCached.conversations.history({
 			channel: channelId,
@@ -519,13 +532,14 @@ async function _cleanSpammyMessages20251117() {
 			oldest: String((+st) / 1000),
 			latest: String((+et) / 1000),
 		})
-		console.log(`+${resp.messages?.length} messages by ${await sflow(resp.messages || [])
-			?.mapMixin(async e => ({ info: await slackCached.users.info({ user: e.user || undefined }).then(u => u.user) }))
-			?.map(m => String(m.username || m.info?.real_name || m.user || ''))
-			.filter()
-			.join(", ")
-			.text()
-			}`);
+		console.log(resp.messages?.length)
+		// console.log(`+${resp.messages?.length} messages by ${await sflow(resp.messages || [])
+		// 	?.mapMixin(async e => ({ info: await slackCached.users.info({ user: e.user || undefined }).then(u => u.user) }))
+		// 	?.map(m => String(m.username || m.info?.real_name || m.user || ''))
+		// 	.filter()
+		// 	.join(", ")
+		// 	.text()
+		// 	}`);
 
 		return { next: resp.response_metadata?.next_cursor || undefined, data: resp.messages || [] };
 	})
@@ -542,7 +556,6 @@ async function _cleanSpammyMessages20251117() {
 		// .takeWhile(e => +(e.ts || DIE(`Fatal: msg have no.ts ${e}`)) * 1000 >= (+st))
 		// .filter(e => e.username)
 		.filter(e => e.user === comfyPrBot.id)
-		.forEach(async e => await slack.chat.delete({ channel: channelId, ts: e.ts || DIE() }))
 		// throw check
 		.toArray()
 
@@ -553,4 +566,14 @@ async function _cleanSpammyMessages20251117() {
 		)
 	}))
 
-}
+	const confirmed = await confirm(`About to delete ${myspammessages.length} messages sent by ComfyPR-Bot in #${channel.name} between ${st.toISOString()} and ${et.toISOString()}. Proceed?`);
+	if (!confirmed) {
+		console.log("Operation cancelled");
+		return;
+	}
+
+	const deletedMessages = await sflow(myspammessages)
+		.forEach(async e => await slack.chat.delete({ channel: channelId, ts: e.ts || DIE() }))
+		.log(e => `Deleted message at ${new Date(+(e.ts || DIE()) * 1000).toISOString()}: ${e.text?.replace(/\n/g, ' ').slice(0, 30)}...`)
+		.run()
+}

app/tasks/gh-design/gh-design.ts

@@ -12,6 +12,7 @@ import sha256 from "sha256";
 import { z } from "zod";
 import { createTimeLogger } from "./createTimeLogger";
 import { ghDesignDefaultConfig } from "./default-config";
+import { slackMessageUrlParse, slackMessageUrlStringify } from "./slackMessageUrlParse";
 const tlog = createTimeLogger();
 // Task bot to scan for [Design] labels on PRs and issues and send notifications to product channel
 
@@ -275,22 +276,4 @@ export async function runGithubDesignTask() {
   });
 }
 
-/**
- * @deprecated use slack.chat.getPermalink instead
- */
-export function slackMessageUrlStringify({ channel, ts }: { channel: string; ts: string }) {
-  // slack use microsecond as message id, uniq by channel
-  // TODO: move organization to env variable
-  return `https://comfy-organization.slack.com/archives/{{CHANNEL_ID}}/p{{TSNODOT}}`
-    .replace("{{CHANNEL_ID}}", channel)
-    .replace("{{TSNODOT}}", ts.replace(/\./g, ""));
-}
-export function slackMessageUrlParse(url: string) {
-  // slack use microsecond as message id, uniq by channel
-  const match = url.match(/archives\/([^\/]+)\/p(\d+)/);
-  if (!match) throw new Error(`Invalid Slack message URL: ${url}`);
-  return {
-    channel: match[1],
-    ts: match[2].replace(/^(\d+)(\d{6})$/, "$1.$2"), // convert to full timestamp
-  };
-}
+

app/tasks/gh-design/slackMessageUrlParse.ts

@@ -0,0 +1,21 @@
+export function slackMessageUrlParse(url: string) {
+  // slack use microsecond as message id, uniq by channel
+  const match = url.match(/archives\/([^\/]+)\/p(\d+)/);
+  if (!match) throw new Error(`Invalid Slack message URL: ${url}`);
+  return {
+    channel: match[1],
+    ts: match[2].replace(/^(\d+)(\d{6})$/, "$1.$2"), // convert Slack message ID (e.g., "1234567890123456") to Slack timestamp format with decimal (e.g., "1234567890.123456")
+  };
+}
+
+/**
+ * @deprecated use slack.chat.getPermalink instead
+ */
+export function slackMessageUrlStringify({ channel, ts }: { channel: string; ts: string; }) {
+  // slack use microsecond as message id, uniq by channel
+  // TODO: move organization to env variable
+  return `https://comfy-organization.slack.com/archives/{{CHANNEL_ID}}/p{{TSNODOT}}`
+    .replace("{{CHANNEL_ID}}", channel)
+    .replace("{{TSNODOT}}", ts.replace(/\./g, ""));
+}
+

app/tasks/gh-desktop-release-notification/upsertSlackMessage.ts

@@ -5,7 +5,7 @@ import KeyvSqlite from "@keyv/sqlite";
 import DIE from "@snomiao/die";
 import chalk from "chalk";
 import Keyv from "keyv";
-import { slackMessageUrlParse, slackMessageUrlStringify } from "../gh-design/gh-design";
+import { slackMessageUrlStringify, slackMessageUrlParse } from "../gh-design/slackMessageUrlParse";
 import { COMFY_PR_CACHE_DIR } from "./COMFY_PR_CACHE_DIR";
 
 const SlackChannelIdsCache = new Keyv<string>({

lib/utils.ts

@@ -4,3 +4,28 @@ import { twMerge } from "tailwind-merge";
 export function cn(...inputs: ClassValue[]) {
   return twMerge(clsx(inputs));
 }
+/**
+ * Prompts the user with a yes/no question in the terminal and returns their response as a boolean.
+ *
+ * @param {string} question - The question to display to the user.
+ * @returns {Promise<boolean>} - Resolves to `true` if the user answers "y" or "yes" (case-insensitive), otherwise `false`.
+ *
+ * @example
+ * const answer = await confirm("Do you want to continue?");
+ * if (answer) {
+ *   // User confirmed
+ * } else {
+ *   // User declined
+ * }
+ */
+export async function confirm(question: string) {
+	return new Promise<boolean>((resolve) => {
+		process.stdin.resume();
+		process.stdout.write(`${question} (y/n): `);
+		process.stdin.once("data", function (data) {
+			const answer = data.toString().trim().toLowerCase();
+			process.stdin.pause();
+			resolve(answer === "y" || answer === "yes");
+		});
+	});
+}