-
Notifications
You must be signed in to change notification settings - Fork 5
feat(coreping): group PR list by author #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snomiao
wants to merge
1
commit into
main
Choose a base branch
from
sno-coreping-groupby-author
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -431,20 +431,46 @@ async function runCorePingTaskFull() { | |||||
| const diff = Date.now() - (at instanceof Date ? at.getTime() : at); | ||||||
| return "for " + ms(diff, { long: true }); | ||||||
| }; | ||||||
| const groupByAuthor = <T extends { author?: string; statusAt?: Date | number }>(prs: T[]) => { | ||||||
| const groups = new Map<string, T[]>(); | ||||||
| for (const pr of prs) { | ||||||
| const author = pr.author ?? "unknown"; | ||||||
| if (!groups.has(author)) groups.set(author, []); | ||||||
| groups.get(author)!.push(pr); | ||||||
| } | ||||||
| // Sort PRs within each group by statusAt (oldest first) | ||||||
| for (const [, group] of groups) { | ||||||
| group.sort((a, b) => { | ||||||
| const aTime = a.statusAt instanceof Date ? a.statusAt.getTime() : (a.statusAt ?? 0); | ||||||
| const bTime = b.statusAt instanceof Date ? b.statusAt.getTime() : (b.statusAt ?? 0); | ||||||
| return aTime - bTime; | ||||||
| }); | ||||||
| } | ||||||
| // Sort author groups by their oldest PR's statusAt (oldest first) | ||||||
| return [...groups.entries()].sort(([, a], [, b]) => { | ||||||
| const aTime = a[0].statusAt instanceof Date ? a[0].statusAt.getTime() : (a[0].statusAt ?? 0); | ||||||
| const bTime = b[0].statusAt instanceof Date ? b[0].statusAt.getTime() : (b[0].statusAt ?? 0); | ||||||
| return aTime - bTime; | ||||||
| }); | ||||||
| }; | ||||||
|
|
||||||
| const formatGroupedPRs = ( | ||||||
| groups: [string, ComfyCorePRs[]][], | ||||||
| formatPR: (pr: ComfyCorePRs) => string, | ||||||
| ) => | ||||||
| groups | ||||||
| .map(([author, prs]) => `*@${author}*:\n${prs.map((pr) => ` - ${formatPR(pr)}`).join("\n")}`) | ||||||
| .join("\n"); | ||||||
|
|
||||||
| const reviewMessage = !pendingReviewCorePRs.length | ||||||
| ? `Congratulations! All Core/Important PRs are reviewed! 🎉🎉🎉` | ||||||
| : `Hey <@comfy>, Here's x${pendingReviewCorePRs.length} Core/Important PRs waiting your feedback! | ||||||
| - ${pendingReviewCorePRs.map((pr) => `@${pr.author}: <${pr.url}|${pr.title}> (${pr.labels}) is ${pr.status} ${forDuration(pr.statusAt)}`).join("\n- ")}`; | ||||||
| ${formatGroupedPRs(groupByAuthor(pendingReviewCorePRs), (pr) => `<${pr.url}|${pr.title}> (${pr.labels}) is ${pr.status} ${forDuration(pr.statusAt)}`)}`; | ||||||
|
|
||||||
| const keepInMindMessage = | ||||||
| remainingOpeningCorePRs.length > 0 | ||||||
| ? `\n\nAdditionally, there ${remainingOpeningCorePRs.length === 1 ? "is" : "are"} ${remainingOpeningCorePRs.length} other open Core/Important ${remainingOpeningCorePRs.length === 1 ? "PR" : "PRs"} that ${remainingOpeningCorePRs.length === 1 ? "is" : "are"} pending for author's change/update, lets wait for them. | ||||||
|
||||||
| ? `\n\nAdditionally, there ${remainingOpeningCorePRs.length === 1 ? "is" : "are"} ${remainingOpeningCorePRs.length} other open Core/Important ${remainingOpeningCorePRs.length === 1 ? "PR" : "PRs"} that ${remainingOpeningCorePRs.length === 1 ? "is" : "are"} pending for author's change/update, lets wait for them. | |
| ? `\n\nAdditionally, there ${remainingOpeningCorePRs.length === 1 ? "is" : "are"} ${remainingOpeningCorePRs.length} other open Core/Important ${remainingOpeningCorePRs.length === 1 ? "PR" : "PRs"} that ${remainingOpeningCorePRs.length === 1 ? "is" : "are"} pending for author's change/update, let's wait for them. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The template literal adds a leading space before the grouped PR output (there’s a literal space after the newline before
${formatGroupedPRs(...)}). This will indent the first*@author*:line in Slack and can subtly affect formatting; consider removing the leading whitespace (e.g., put the interpolation immediately after the newline or trim the inserted block).