fix: skip backport checks for releases not from main branch#200
Open
comfy-pr-bot wants to merge 1 commit intomainfrom
Open
fix: skip backport checks for releases not from main branch#200comfy-pr-bot wants to merge 1 commit intomainfrom
comfy-pr-bot wants to merge 1 commit intomainfrom
Conversation
Releases made from RC branches (like core/1.42) already have their
commits on that branch — there is nothing to backport. Add a
target_commitish filter so the checker only processes releases whose
source branch matches config.mainBranch ('main').
- Add mainBranch config option (default: 'main')
- Filter out non-main releases with a debug log message
- Update JSDoc to document the new filtering step
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The backport checker was running for ALL releases from ComfyUI_frontend, including patch releases made from RC branches like
core/1.42. Christian Byrne pointed out that we do NOT need to check backports when a release is NOT made from the main branch — releases from RC branches already have their commits on that branch, so there's nothing to backport.Changes
mainBranch: 'main'config option so the filter is configurablesflowpipeline to skip releases wheretarget_commitish !== config.mainBranchlogger.debugmessage when skipping non-main releases (shows the tag name and actual target branch)How it works
GitHub releases have a
target_commitishfield indicating the branch/commit the release was created from:target_commitish === 'main'target_commitish === 'core/1.42'The new filter skips any release where
target_commitishdoesn't matchconfig.mainBranch.Testing
Run with
--dry-runagainst the frontend repo and verify that releases likev1.42.9(fromcore/1.42) are skipped with a debug log, while main branch releases continue to be processed normally.