ci(release): pre-fetch bootstrap-python so todesktop validates extraResources#506
Merged
Kosinkadink merged 1 commit intomainfrom May 7, 2026
Merged
Conversation
…esources
@todesktop/cli@1.22.0 now eagerly validates the platform-specific
extraResources paths in todesktop.json before invoking the beforeBuild
hook, so the bootstrap-python/{win-x64,mac-arm64,linux-x64} directories
must exist on disk at the time todesktop build runs. Run the existing
fetch-bootstrap-python script (all platforms) right after the CLI is
installed.
Amp-Thread-ID: https://ampcode.com/threads/T-019e009a-812e-734e-b371-d5eacf9d34c2
Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019e009a-812e-734e-b371-d5eacf9d34c2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build-release.ymlfor tagv0.6.0failed at theBuild with ToDesktopstep:Failed run.
@todesktop/cli@1.22.0now eagerly validates the platform-specific paths intodesktop.jsonplatformOverrides.*.extraResourcesbefore invoking thebeforeBuildhook. Ourscripts/todesktop-beforeBuild.cjsis the thing that callsfetch-bootstrap-python.mjsto download the bootstrap-python archive for the active platform — by the time it runs, validation has already failed.The CLI version is unchanged from the v0.5.0 release that worked a month ago, so this is a behavior change shipped server-side or in a non-version-bumped CLI release.
Fix
Run the existing
pnpm run bootstrap:fetchscript (which callsscripts/fetch-bootstrap-python.mjsfor all 3 platforms) right after the ToDesktop CLI is installed, so the directories exist on disk beforetodesktop buildvalidates the config.The script already supports being a no-op for any platform whose directory already exists, and uses
GITHUB_TOKENfor authenticated downloads to avoid rate limits.Follow-up
After this merges, the
v0.6.0build needs to be re-triggered. Options:v0.6.1viaversion-bump.yml(cleanest).workflow_dispatchbuild-release.ymlfor tagv0.6.0after force-moving the tag to the new merge commit (avoid: tag mutation is hostile to consumers).Recommend the bump.
Amp-Thread-ID: https://ampcode.com/threads/T-019e009a-812e-734e-b371-d5eacf9d34c2