Commit 41ab628
committed
fix(git_helper): Windows subprocess crash fix — reinstall URL handling + tqdm pipe deadlock
Two fixes for Windows E2E failures:
1. cm_cli reinstall_node(): resolve_node_spec() returns the full URL
as node_name, but internal dicts are keyed by repo basename or
cnr_id. Use get_cnr_by_repo() for CNR-aware lookup with correct
is_unknown flag, falling back to basename for unknown nodes.
2. git_helper.py gitclone(): disable tqdm progress when stderr is
piped (sys.stderr.isatty() gate). When a parent process captures
stderr via PIPE, tqdm output fills the 4KB Windows pipe buffer,
blocking GitPython's progress reader and causing git clone exit 128.1 parent 099aed1 commit 41ab628
2 files changed
Lines changed: 25 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
238 | 238 | | |
239 | 239 | | |
240 | 240 | | |
241 | | - | |
242 | | - | |
243 | | - | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
244 | 254 | | |
245 | | - | |
246 | | - | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
247 | 259 | | |
248 | | - | |
249 | | - | |
250 | | - | |
| 260 | + | |
| 261 | + | |
251 | 262 | | |
252 | | - | |
| 263 | + | |
253 | 264 | | |
254 | 265 | | |
255 | 266 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
105 | 109 | | |
106 | 110 | | |
107 | 111 | | |
| |||
0 commit comments