Update Deno custom node map#2987
Conversation
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds a new ChangesDenoIdeogramDirector Node Addition and JSON Correction
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8de0d97 to
6acbfdb
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@extension-node-map.json`:
- Around line 7423-7429: The extension-node-map.json and
node_db/new/extension-node-map.json files are out of sync with different Deno
node counts (19 vs 18 respectively), conflicting with the PR objective of 18
nodes. Verify that node_db/new/extension-node-map.json is the source of truth,
then update extension-node-map.json to match it exactly—removing one entry from
the Deno nodes list (which currently includes DenoAIReviewGate,
DenoAdvancedImageSourceLoader, DenoBerniniPromptGuide, DenoIdeogramDirector,
DenoImageCompare, DenoLTX23PresetLoader, and DenoLTXModelDownloader among
others) to reduce the count from 19 to 18 nodes. Ensure both files are identical
after the change and that the metadata structure remains intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 84208bfa-5fdf-4936-ba0b-bbad0aae95c6
📒 Files selected for processing (1)
extension-node-map.json
| "DenoAIReviewGate", | ||
| "DenoAdvancedImageSourceLoader", | ||
| "DenoBerniniPromptGuide", | ||
| "DenoIdeogramDirector", | ||
| "DenoImageCompare", | ||
| "DenoLTX23PresetLoader", | ||
| "DenoLTXModelDownloader", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the Deno Custom Nodes mapping expansion across both files
echo "=== Checking Deno node count in extension-node-map.json ==="
# Extract the Deno node list and count entries
jq '.["https://github.com/Deno2026/comfyui-deno-custom-nodes"][0] | length' extension-node-map.json
echo ""
echo "=== Checking Deno node count in node_db/new/extension-node-map.json ==="
jq '.["https://github.com/Deno2026/comfyui-deno-custom-nodes"][0] | length' node_db/new/extension-node-map.json
echo ""
echo "=== Verifying both files have identical Deno entries ==="
# Compare the Deno mapping entries
diff <(jq '.["https://github.com/Deno2026/comfyui-deno-custom-nodes"]' extension-node-map.json) \
<(jq '.["https://github.com/Deno2026/comfyui-deno-custom-nodes"]' node_db/new/extension-node-map.json) && echo "✓ Files are synchronized" || echo "✗ Files differ"
echo ""
echo "=== Listing all Deno node identifiers in extension-node-map.json ==="
jq '.["https://github.com/Deno2026/comfyui-deno-custom-nodes"][0] | sort' extension-node-map.json
echo ""
echo "=== Verifying JSON syntax validity ==="
jq empty extension-node-map.json && echo "✓ extension-node-map.json is valid JSON" || echo "✗ extension-node-map.json has JSON errors"
jq empty node_db/new/extension-node-map.json && echo "✓ node_db/new/extension-node-map.json is valid JSON" || echo "✗ node_db/new/extension-node-map.json has JSON errors"
echo ""
echo "=== Checking metadata structure (second element of Deno entry) ==="
jq '.["https://github.com/Deno2026/comfyui-deno-custom-nodes"][1]' extension-node-map.jsonRepository: Comfy-Org/ComfyUI-Manager
Length of output: 1182
Synchronize extension-node-map.json and node_db/new/extension-node-map.json—they contain different node counts.
The two files are not in sync: extension-node-map.json contains 19 Deno nodes, while node_db/new/extension-node-map.json contains 18. This contradicts the PR objective claim that both files are "updated identically."
Additionally, the count in extension-node-map.json (19 nodes) exceeds the PR objective of 18 nodes. Before proceeding, verify:
- Which file is the source of truth?
- Should
extension-node-map.jsonbe trimmed to 18 nodes, or shouldnode_db/new/extension-node-map.jsonbe updated to 19?
Both files currently validate as well-formed JSON, and the metadata structure is correct ({"title_aux": "Deno Custom Nodes"}), so this is a data-integrity issue rather than a syntax one. Looks like these twin files could use some node-al intervention! 🧠
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@extension-node-map.json` around lines 7423 - 7429, The
extension-node-map.json and node_db/new/extension-node-map.json files are out of
sync with different Deno node counts (19 vs 18 respectively), conflicting with
the PR objective of 18 nodes. Verify that node_db/new/extension-node-map.json is
the source of truth, then update extension-node-map.json to match it
exactly—removing one entry from the Deno nodes list (which currently includes
DenoAIReviewGate, DenoAdvancedImageSourceLoader, DenoBerniniPromptGuide,
DenoIdeogramDirector, DenoImageCompare, DenoLTX23PresetLoader, and
DenoLTXModelDownloader among others) to reduce the count from 19 to 18 nodes.
Ensure both files are identical after the change and that the metadata structure
remains intact.
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
extension-node-map.json (1)
7440-7458:⚠️ Potential issue | 🟠 Major | ⚡ Quick winConfirm the Deno node-count contract before merge (18 vs 19).
Line 7440 through Line 7458 now enumerate 19 Deno class IDs, while the PR objective states “exactly 18” and claims mirrored parity with
node_db/new/extension-node-map.json. Please verify source-of-truth cardinality and keep both maps identical; otherwise downstream node-to-pack resolution can drift. A tiny count check now avoids a bigger “map-trap” later.#!/bin/bash set -euo pipefail echo "Deno count in extension-node-map.json:" jq '.["https://github.com/Deno2026/comfyui-deno-custom-nodes"][0] | length' extension-node-map.json echo "Deno count in node_db/new/extension-node-map.json:" jq '.["https://github.com/Deno2026/comfyui-deno-custom-nodes"][0] | length' node_db/new/extension-node-map.json echo "Diff of the full Deno mapping payload between files:" diff <(jq '.["https://github.com/Deno2026/comfyui-deno-custom-nodes"]' extension-node-map.json) \ <(jq '.["https://github.com/Deno2026/comfyui-deno-custom-nodes"]' node_db/new/extension-node-map.json) || true🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@extension-node-map.json` around lines 7440 - 7458, The Deno nodes enumeration in extension-node-map.json (lines 7440-7458) contains 19 node IDs ranging from DenoAIReviewGate to DenoVideoPreview, but the PR objective specifies exactly 18 nodes and claims parity with node_db/new/extension-node-map.json. Verify the correct count and ensure both files are identical: either remove one Deno node ID from the current list in extension-node-map.json to match the expected count of 18, or confirm that both the extension-node-map.json and node_db/new/extension-node-map.json files contain the same Deno nodes array to maintain downstream mapping consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@node_db/new/extension-node-map.json`:
- Around line 7438-7460: The node_db/new/extension-node-map.json file is missing
the "DenoIdeogramDirector" node from the Deno Custom Nodes entry under the
"https://github.com/Deno2026/comfyui-deno-custom-nodes" key. Add
"DenoIdeogramDirector" to the array of node names in the correct alphabetical
position (it should be inserted after "DenoImageCompare" to maintain
alphabetical order), bringing the total from 18 nodes to 19 nodes to match the
parity with extension-node-map.json.
- Around line 7440-7457: The extension-node-map.json file is missing the
`DenoIdeogramDirector` node entry from the Deno nodes list shown in lines
7440-7457. Add `DenoIdeogramDirector` to this list in alphabetical order between
`DenoImageCompare` and `DenoLTX23PresetLoader` to complete the mapping contract
for this release objective.
---
Duplicate comments:
In `@extension-node-map.json`:
- Around line 7440-7458: The Deno nodes enumeration in extension-node-map.json
(lines 7440-7458) contains 19 node IDs ranging from DenoAIReviewGate to
DenoVideoPreview, but the PR objective specifies exactly 18 nodes and claims
parity with node_db/new/extension-node-map.json. Verify the correct count and
ensure both files are identical: either remove one Deno node ID from the current
list in extension-node-map.json to match the expected count of 18, or confirm
that both the extension-node-map.json and node_db/new/extension-node-map.json
files contain the same Deno nodes array to maintain downstream mapping
consistency.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: e8769bfd-ac57-4269-8aee-a449ea617885
📒 Files selected for processing (2)
extension-node-map.jsonnode_db/new/extension-node-map.json
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 2
♻️ Duplicate comments (1)
extension-node-map.json (1)
7440-7458:⚠️ Potential issue | 🟠 Major | ⚡ Quick winConfirm the Deno node-count contract before merge (18 vs 19).
Line 7440 through Line 7458 now enumerate 19 Deno class IDs, while the PR objective states “exactly 18” and claims mirrored parity with
node_db/new/extension-node-map.json. Please verify source-of-truth cardinality and keep both maps identical; otherwise downstream node-to-pack resolution can drift. A tiny count check now avoids a bigger “map-trap” later.#!/bin/bash set -euo pipefail echo "Deno count in extension-node-map.json:" jq '.["https://github.com/Deno2026/comfyui-deno-custom-nodes"][0] | length' extension-node-map.json echo "Deno count in node_db/new/extension-node-map.json:" jq '.["https://github.com/Deno2026/comfyui-deno-custom-nodes"][0] | length' node_db/new/extension-node-map.json echo "Diff of the full Deno mapping payload between files:" diff <(jq '.["https://github.com/Deno2026/comfyui-deno-custom-nodes"]' extension-node-map.json) \ <(jq '.["https://github.com/Deno2026/comfyui-deno-custom-nodes"]' node_db/new/extension-node-map.json) || true🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@extension-node-map.json` around lines 7440 - 7458, The Deno nodes enumeration in extension-node-map.json (lines 7440-7458) contains 19 node IDs ranging from DenoAIReviewGate to DenoVideoPreview, but the PR objective specifies exactly 18 nodes and claims parity with node_db/new/extension-node-map.json. Verify the correct count and ensure both files are identical: either remove one Deno node ID from the current list in extension-node-map.json to match the expected count of 18, or confirm that both the extension-node-map.json and node_db/new/extension-node-map.json files contain the same Deno nodes array to maintain downstream mapping consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@node_db/new/extension-node-map.json`:
- Around line 7438-7460: The node_db/new/extension-node-map.json file is missing
the "DenoIdeogramDirector" node from the Deno Custom Nodes entry under the
"https://github.com/Deno2026/comfyui-deno-custom-nodes" key. Add
"DenoIdeogramDirector" to the array of node names in the correct alphabetical
position (it should be inserted after "DenoImageCompare" to maintain
alphabetical order), bringing the total from 18 nodes to 19 nodes to match the
parity with extension-node-map.json.
- Around line 7440-7457: The extension-node-map.json file is missing the
`DenoIdeogramDirector` node entry from the Deno nodes list shown in lines
7440-7457. Add `DenoIdeogramDirector` to this list in alphabetical order between
`DenoImageCompare` and `DenoLTX23PresetLoader` to complete the mapping contract
for this release objective.
---
Duplicate comments:
In `@extension-node-map.json`:
- Around line 7440-7458: The Deno nodes enumeration in extension-node-map.json
(lines 7440-7458) contains 19 node IDs ranging from DenoAIReviewGate to
DenoVideoPreview, but the PR objective specifies exactly 18 nodes and claims
parity with node_db/new/extension-node-map.json. Verify the correct count and
ensure both files are identical: either remove one Deno node ID from the current
list in extension-node-map.json to match the expected count of 18, or confirm
that both the extension-node-map.json and node_db/new/extension-node-map.json
files contain the same Deno nodes array to maintain downstream mapping
consistency.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: e8769bfd-ac57-4269-8aee-a449ea617885
📒 Files selected for processing (2)
extension-node-map.jsonnode_db/new/extension-node-map.json
🛑 Comments failed to post (2)
node_db/new/extension-node-map.json (2)
7438-7460:
⚠️ Potential issue | 🟠 Major🧩 Analysis chain
🏁 Script executed:
#!/bin/bash set -euo pipefail python - <<'PY' import json from pathlib import Path target = "https://github.com/Deno2026/comfyui-deno-custom-nodes" files = [ Path("extension-node-map.json"), Path("node_db/new/extension-node-map.json"), ] def read_nodes(path): data = json.loads(path.read_text(encoding="utf-8")) if target not in data: raise SystemExit(f"{path}: missing key {target}") nodes = data[target][0] return nodes maps = {str(p): read_nodes(p) for p in files} for f, nodes in maps.items(): print(f"{f}: {len(nodes)} nodes") print(" " + ", ".join(nodes)) a, b = maps[str(files[0])], maps[str(files[1])] if a != b: sa, sb = set(a), set(b) print("\nMismatch detected:") print("Only in extension-node-map.json:", sorted(sa - sb)) print("Only in node_db/new/extension-node-map.json:", sorted(sb - sa)) raise SystemExit(1) print("\nDeno mapping entries are identical across both files.") PYRepository: Comfy-Org/ComfyUI-Manager
Length of output: 1069
Add missing DenoIdeogramDirector node to node_db/new/extension-node-map.json.
Parity check reveals
DenoIdeogramDirectorexists inextension-node-map.jsonbut is missing fromnode_db/new/extension-node-map.json. The Deno entry needs to align (no deno-ying the drift—fix this before merge).Parity check results
extension-node-map.json: 19 nodes node_db/new/extension-node-map.json: 18 nodes Missing from new file: DenoIdeogramDirector🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@node_db/new/extension-node-map.json` around lines 7438 - 7460, The node_db/new/extension-node-map.json file is missing the "DenoIdeogramDirector" node from the Deno Custom Nodes entry under the "https://github.com/Deno2026/comfyui-deno-custom-nodes" key. Add "DenoIdeogramDirector" to the array of node names in the correct alphabetical position (it should be inserted after "DenoImageCompare" to maintain alphabetical order), bringing the total from 18 nodes to 19 nodes to match the parity with extension-node-map.json.
7440-7457:
⚠️ Potential issue | 🟠 Major | ⚡ Quick winMissing
DenoIdeogramDirectorin the Deno node list (the map still has a hole in it).Line 7440 through Line 7457 includes 18 Deno nodes, but the PR objective for this cohort is to add
DenoIdeogramDirector, and that class ID is not present. This leaves the mapping contract incomplete for the intended release.Proposed fix
[ "DenoAIReviewGate", "DenoAdvancedImageSourceLoader", "DenoBerniniPromptGuide", + "DenoIdeogramDirector", "DenoImageCompare", "DenoLTX23PresetLoader", "DenoLTXModelDownloader", "DenoLTXMultiLoraLoader", "DenoLTXPromptGuide", "DenoLTXSequencer", "DenoLocalLLMRefiner", "DenoMultiImageLoader", "DenoMultiLoraLoader", "DenoPromptText", "DenoRTXVFXEasyUpscale", "DenoRTXVFXVideoFinisher", "DenoResolutionSetup", "DenoVideoCompare", "DenoVideoPreview" ],📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements."DenoAIReviewGate", "DenoAdvancedImageSourceLoader", "DenoBerniniPromptGuide", "DenoIdeogramDirector", "DenoImageCompare", "DenoLTX23PresetLoader", "DenoLTXModelDownloader", "DenoLTXMultiLoraLoader", "DenoLTXPromptGuide", "DenoLTXSequencer", "DenoLocalLLMRefiner", "DenoMultiImageLoader", "DenoMultiLoraLoader", "DenoPromptText", "DenoRTXVFXEasyUpscale", "DenoRTXVFXVideoFinisher", "DenoResolutionSetup", "DenoVideoCompare", "DenoVideoPreview"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@node_db/new/extension-node-map.json` around lines 7440 - 7457, The extension-node-map.json file is missing the `DenoIdeogramDirector` node entry from the Deno nodes list shown in lines 7440-7457. Add `DenoIdeogramDirector` to this list in alphabetical order between `DenoImageCompare` and `DenoLTX23PresetLoader` to complete the mapping contract for this release objective.
Summary
Updates the Deno Custom Nodes entry in
extension-node-map.jsonfrom the old single-node mapping to the current public node list.The package now exposes these nodes through its repository
node_list.json, and Comfy Registry version0.7.31is active. Without this map update, ComfyUI-Manager still shows the pack as1 nodeeven though the current package contains the full public node set.Changes
extension-node-map.jsonforhttps://github.com/Deno2026/comfyui-deno-custom-nodesnode_db/new/extension-node-map.jsonwith the same node listValidation
https://github.com/Deno2026/comfyui-deno-custom-nodespython -m json.tool extension-node-map.jsonpython -m json.tool node_db/new/extension-node-map.jsonpython json-checker.py extension-node-map.jsonpython json-checker.py node_db\new\extension-node-map.json