Skip to content

Add ComfyUI-HiCache and ComfyUI-TRELLIS2-HiCache#3042

Open
Archerkattri wants to merge 1 commit into
Comfy-Org:mainfrom
Archerkattri:add-hicache-nodes
Open

Add ComfyUI-HiCache and ComfyUI-TRELLIS2-HiCache#3042
Archerkattri wants to merge 1 commit into
Comfy-Org:mainfrom
Archerkattri:add-hicache-nodes

Conversation

@Archerkattri

Copy link
Copy Markdown

Adds two of my custom nodes (both already published on registry.comfy.org, listed here for the legacy channel; ComfyUI-TRELLIS-HiCache is already in the list):

  • ComfyUI-HiCache — training-free Hunyuan3D shape-generation acceleration (skip DiT steps, forecast the flow-matching velocity; HiCache Hermite / HiCache++ DMD via hicache-pp). Pairs with kijai/ComfyUI-Hunyuan3DWrapper.
  • ComfyUI-TRELLIS2-HiCache — the same training-free acceleration for TRELLIS.2 image-to-3D (~2x, near-lossless). Pairs with visualbruno/ComfyUI-Trellis2.

Checked the JSON loads cleanly (python json.load, 5182 nodes) and followed the existing entry format.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f434f6b6-be1f-43e7-91ef-cf5bfbfa0a40

📥 Commits

Reviewing files that changed from the base of the PR and between 8e06ee6 and 5e5e450.

📒 Files selected for processing (1)
  • custom-node-list.json

📝 Walkthrough

Walkthrough

Adds two new git-clone custom node entries, ComfyUI-HiCache and ComfyUI-TRELLIS2-HiCache, to custom-node-list.json, each with metadata fields (author, title, reference, files, install_type) and a description.

Changes

Custom Node List Update

Layer / File(s) Summary
New node entries
custom-node-list.json
Two new entries, ComfyUI-HiCache and ComfyUI-TRELLIS2-HiCache, are added with repository URLs, metadata, and descriptions covering performance notes and pairing info.

Possibly related PRs

No sequence diagram needed here — just a JSON cache expansion, cachin' in on a HiCache sensation! 🎩✨

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e5e4507cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread custom-node-list.json
"title": "ComfyUI-HiCache",
"reference": "https://github.com/Archerkattri/ComfyUI-HiCache",
"files": [
"https://github.com/Archerkattri/ComfyUI-HiCache"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Install hicache-pp for HiCache git installs

When this entry is installed through the legacy/nightly git-clone path, Manager only installs dependencies from requirements.txt or install.py (glob/manager_core.py:924-944); it does not install pyproject.toml dependencies. The referenced repo imports hicache_pp at module import time, but its current requirements.txt is a single commented line with hicache-pp>=1.1.0 after #, so pip skips it. Users without hicache-pp already installed will get an import failure after installing this catalog entry, so the repo needs a real requirements/install hook before this can work reliably via the legacy list.

Useful? React with 👍 / 👎.

Comment thread custom-node-list.json
"title": "ComfyUI-TRELLIS2-HiCache",
"reference": "https://github.com/Archerkattri/ComfyUI-TRELLIS2-HiCache",
"files": [
"https://github.com/Archerkattri/ComfyUI-TRELLIS2-HiCache"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Provide hicache-pp for TRELLIS2 git installs

For legacy/nightly installs this URL is cloned via repo_install, whose post-install only reads requirements.txt or install.py (glob/manager_core.py:1345-1372, glob/manager_core.py:924-944), so pyproject.toml dependencies are ignored. The linked TRELLIS2 repo imports hicache_pp at import time and its README tells users to pip install hicache-pp, but the repo currently has no requirements.txt or install.py; installing this new entry will therefore leave the node unloadable unless the user already has that package. Please add a git-install dependency hook before listing it here.

Useful? React with 👍 / 👎.

@Archerkattri

Copy link
Copy Markdown
Author

Thanks — good catch on the git-install path. Fixed:

On ComfyUI-HiCache: its requirements.txt already carries hicache-pp>=1.1.0 as a real (uncommented) requirement — the # line above it is a separate comment about torch/ComfyUI being pre-installed, so the legacy pip path picks the dependency up as-is: https://github.com/Archerkattri/ComfyUI-HiCache/blob/main/requirements.txt

All three nodes now install cleanly via both the registry and the legacy git-clone path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants