Add ComfyUI-HiCache and ComfyUI-TRELLIS2-HiCache#3042
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds two new git-clone custom node entries, ComfyUI-HiCache and ComfyUI-TRELLIS2-HiCache, to custom-node-list.json, each with metadata fields (author, title, reference, files, install_type) and a description. ChangesCustom Node List Update
Possibly related PRs
No sequence diagram needed here — just a JSON cache expansion, cachin' in on a HiCache sensation! 🎩✨ 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e5e4507cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "title": "ComfyUI-HiCache", | ||
| "reference": "https://github.com/Archerkattri/ComfyUI-HiCache", | ||
| "files": [ | ||
| "https://github.com/Archerkattri/ComfyUI-HiCache" |
There was a problem hiding this comment.
Install hicache-pp for HiCache git installs
When this entry is installed through the legacy/nightly git-clone path, Manager only installs dependencies from requirements.txt or install.py (glob/manager_core.py:924-944); it does not install pyproject.toml dependencies. The referenced repo imports hicache_pp at module import time, but its current requirements.txt is a single commented line with hicache-pp>=1.1.0 after #, so pip skips it. Users without hicache-pp already installed will get an import failure after installing this catalog entry, so the repo needs a real requirements/install hook before this can work reliably via the legacy list.
Useful? React with 👍 / 👎.
| "title": "ComfyUI-TRELLIS2-HiCache", | ||
| "reference": "https://github.com/Archerkattri/ComfyUI-TRELLIS2-HiCache", | ||
| "files": [ | ||
| "https://github.com/Archerkattri/ComfyUI-TRELLIS2-HiCache" |
There was a problem hiding this comment.
Provide hicache-pp for TRELLIS2 git installs
For legacy/nightly installs this URL is cloned via repo_install, whose post-install only reads requirements.txt or install.py (glob/manager_core.py:1345-1372, glob/manager_core.py:924-944), so pyproject.toml dependencies are ignored. The linked TRELLIS2 repo imports hicache_pp at import time and its README tells users to pip install hicache-pp, but the repo currently has no requirements.txt or install.py; installing this new entry will therefore leave the node unloadable unless the user already has that package. Please add a git-install dependency hook before listing it here.
Useful? React with 👍 / 👎.
|
Thanks — good catch on the git-install path. Fixed:
On ComfyUI-HiCache: its All three nodes now install cleanly via both the registry and the legacy git-clone path. |
Adds two of my custom nodes (both already published on registry.comfy.org, listed here for the legacy channel; ComfyUI-TRELLIS-HiCache is already in the list):
Checked the JSON loads cleanly (python json.load, 5182 nodes) and followed the existing entry format.