Skip to content

Commit 985fb9d

Browse files
authored
[Partner Nodes] fix(logs-auth): mask authorization headers in logs (#14774)
Signed-off-by: bigcat88 <bigcat88@icloud.com>
1 parent 7f287b7 commit 985fb9d

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

comfy_api_nodes/util/request_logger.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import folder_paths
1010

1111
logger = logging.getLogger(__name__)
12+
_SENSITIVE_HEADERS = {"authorization", "x-api-key"}
1213

1314

1415
def get_log_directory():
@@ -73,6 +74,10 @@ def _format_data_for_logging(data: Any) -> str:
7374
return str(data)
7475

7576

77+
def _redact_headers(headers: dict) -> dict:
78+
return {k: ("***" if k.lower() in _SENSITIVE_HEADERS else v) for k, v in headers.items()}
79+
80+
7681
def log_request_response(
7782
operation_id: str,
7883
request_method: str,
@@ -101,7 +106,7 @@ def log_request_response(
101106
log_content.append(f"Method: {request_method}")
102107
log_content.append(f"URL: {request_url}")
103108
if request_headers:
104-
log_content.append(f"Headers:\n{_format_data_for_logging(request_headers)}")
109+
log_content.append(f"Headers:\n{_format_data_for_logging(_redact_headers(request_headers))}")
105110
if request_params:
106111
log_content.append(f"Params:\n{_format_data_for_logging(request_params)}")
107112
if request_data is not None:

0 commit comments

Comments
 (0)