Skip to content

Mk/byok 2#12886

Closed
mkorovkin2 wants to merge 3 commits intoComfy-Org:masterfrom
MimosDev:mk/byok-2
Closed

Mk/byok 2#12886
mkorovkin2 wants to merge 3 commits intoComfy-Org:masterfrom
MimosDev:mk/byok-2

Conversation

@mkorovkin2
Copy link
Copy Markdown

@mkorovkin2 mkorovkin2 commented Mar 11, 2026

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 11, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR migrates API authentication from ComfyOrg proxy-based to BYOK (Bring Your Own Key) environment variable-based approach. Environment variables GOOGLE_API_KEY and FAL_API_KEY are now read directly at request time. Numerous node files transition from direct ComfyOrg endpoints to fal.ai infrastructure via new fal_run helpers and Google direct API calls. Upload helpers shift from ComfyUI endpoints to fal.ai and Google uploads. Price badges and hidden auth token fields are removed from node schemas. Several node integrations (Grok, HitPaw, Magnific, Moonvalley, Runway, Topaz, Tripo, Wavespeed) are completely deleted. Authentication headers are now validated against domain allowlists, and session pooling is introduced for request reuse.

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 11.65% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Mk/byok 2' is vague and uses a branch-naming convention rather than describing the changeset; it does not convey meaningful information about the actual work performed. Use a descriptive title summarizing the main change, e.g., 'Migrate API nodes to BYOK with fal.ai and Google direct integration' or 'Replace ComfyOrg proxy with BYOK provider infrastructure'.
Description check ❓ Inconclusive The description contains only an unchecked API Node PR checklist template with no explanation of the changes, objectives, or implementation details related to the BYOK migration work. Provide a meaningful description explaining the PR's intent, key changes (BYOK migration, fal.ai/Google integration), affected node modules, and migration phases completed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mkorovkin2 mkorovkin2 closed this Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant