Skip to content

把ComfyUI最新的给merge过来了#13460

Closed
SGDBS wants to merge 3 commits intoComfy-Org:masterfrom
dapaoA:feature/inference-scaling
Closed

把ComfyUI最新的给merge过来了#13460
SGDBS wants to merge 3 commits intoComfy-Org:masterfrom
dapaoA:feature/inference-scaling

Conversation

@SGDBS
Copy link
Copy Markdown

@SGDBS SGDBS commented Apr 18, 2026 •
edited by github-actions Bot
Loading

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

kasailab and others added 3 commits April 4, 2026 14:55
@SGDBS
Add inference scaling nodes with quality monitoring during generation
c254fa1 
- Implement VerifierSelectionNode for creating quality verifiers
- Implement InferenceScalingNode that wraps KSampler with quality checks
- Add VAE decoding during sampling steps for quality assessment
- Include quality verification logic using variance and edge detection
- Fix noise/latent handling to match ComfyUI patterns
- Add comprehensive error handling and logging
- Include documentation and debugging notes
@SGDBS
docs: add local features documentation
7444253 
- Document all custom inference scaling nodes added to ComfyUI
- Include VerifierSelectionNode and InferenceScalingNode descriptions
- Document HOW_TO_WRITE_NODES guide and template example
- Add usage instructions and known limitations
@SGDBS
fix: resolve ruff linting errors in nodes_inference_scaling
c5ce3e1 
- Remove unused imports: Optional, Callable, Dict, PIL.Image, traceback
- Remove trailing whitespace on blank lines (W293)
- Remove unused local variable: device
@SGDBS SGDBS closed this Apr 18, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 18, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 748a22dc-24c6-4120-bb02-5e73b7c4e055

📥 Commits

Reviewing files that changed from the base of the PR and between 3086026 and c5ce3e1.

📒 Files selected for processing (6)
  • DEBUGGING_NOTES.md
  • HOW_TO_WRITE_NODES.md
  • INFERENCE_SCALING_README.md
  • LOCAL_FEATURES.md
  • comfy_api_nodes/nodes_inference_scaling.py
  • comfy_api_nodes/nodes_template_example.py
📝 Walkthrough

Walkthrough

This pull request introduces an inference scaling feature for ComfyUI with supporting documentation and implementation. It adds a new extension module (comfy_api_nodes/nodes_inference_scaling.py) containing quality verification abstractions, a VerifierSelectionNode, and an InferenceScalingNode that wraps sampling with periodic latent decoding and quality evaluation via a callback. Additionally, four documentation files explain the feature design, implementation details, debugging fixes, and node authoring guidelines. A template example module is included to demonstrate ComfyUI node structure and patterns.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@comfyanonymous comfyanonymous Awaiting requested review from comfyanonymous comfyanonymous is a code owner

@Kosinkadink Kosinkadink Awaiting requested review from Kosinkadink Kosinkadink is a code owner

@guill guill Awaiting requested review from guill guill is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@SGDBS