[Partner Nodes] add Luma UNI-1 model#13614
Conversation
4ba23c0 to
92be83b
Compare
92be83b to
ad7e5eb
Compare
Signed-off-by: bigcat88 <bigcat88@icloud.com>
ad7e5eb to
037efe7
Compare
📝 WalkthroughWalkthroughThe PR updates the Luma nodes module to support UNI-1 generation capabilities. Type annotations in existing execute methods are modernized from 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@comfy_api_nodes/nodes_luma.py`:
- Line 827: validate_string is currently called on the raw prompt which allows
whitespace-only strings; change both calls that read validate_string(prompt,
min_length=1, max_length=6000) to validate_string(prompt.strip(), min_length=1,
max_length=6000) so the prompt is trimmed first and whitespace-only input is
rejected (apply the same change for the second occurrence in the file).
- Around line 681-689: The code currently uploads all entries in refs via
upload_image_to_comfyapi before enforcing max_count; change the logic in the
function handling refs to validate the number of provided references against
max_count before any calls to upload_image_to_comfyapi (or alternatively only
iterate up to max_count and skip/raise for extras). Specifically, check if refs
is truthy and then if len(refs) > max_count raise ValueError (or enforce a
slice) prior to the for loop that calls upload_image_to_comfyapi and constructs
Luma2ImageRef (ensure cls is still passed correctly to
upload_image_to_comfyapi).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b03eeb61-798a-4c06-a7e0-eff0664f977a
⛔ Files ignored due to path filters (1)
comfy_api_nodes/apis/luma.pyis excluded by!comfy_api_nodes/apis/**
📒 Files selected for processing (1)
comfy_api_nodes/nodes_luma.py
API Node PR Checklist
Scope
Pricing & Billing
If Need pricing update:
QA
Comms