Skip to content

[Partner Nodes] add Luma UNI-1 model#13614

Merged
bigcat88 merged 2 commits intomasterfrom
feat/api-nodes/UNI-1
May 5, 2026
Merged

[Partner Nodes] add Luma UNI-1 model#13614
bigcat88 merged 2 commits intomasterfrom
feat/api-nodes/UNI-1

Conversation

@bigcat88
Copy link
Copy Markdown
Contributor

@bigcat88 bigcat88 commented Apr 29, 2026

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

@bigcat88 bigcat88 force-pushed the feat/api-nodes/UNI-1 branch from 4ba23c0 to 92be83b Compare April 29, 2026 09:05
@bigcat88 bigcat88 added preview-cpu Creates a preview ephemeral environment for this PR (CPU only) and removed preview-cpu Creates a preview ephemeral environment for this PR (CPU only) labels Apr 29, 2026
@bigcat88 bigcat88 force-pushed the feat/api-nodes/UNI-1 branch from 92be83b to ad7e5eb Compare May 5, 2026 05:00
Signed-off-by: bigcat88 <bigcat88@icloud.com>
@bigcat88 bigcat88 force-pushed the feat/api-nodes/UNI-1 branch from ad7e5eb to 037efe7 Compare May 5, 2026 05:24
@bigcat88 bigcat88 marked this pull request as ready for review May 5, 2026 05:36
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

📝 Walkthrough

Walkthrough

The PR updates the Luma nodes module to support UNI-1 generation capabilities. Type annotations in existing execute methods are modernized from Optional[T] to T | None union syntax. New helper functions are introduced to manage UNI-1 workflow steps: building input schemas, uploading reference images, and submitting/polling generation requests. Two new node classes—LumaImageNode for text-to-image and LumaImageEditNode for image editing—are added with UNI-1-specific validation rules (prompt length constraints, style+aspect ratio combinations) and request construction using Luma2GenerationRequest. The extension's node registry is updated to expose these new nodes.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title '[Partner Nodes] add Luma UNI-1 model' clearly and concisely describes the main change: adding support for Luma's UNI-1 model as partner nodes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description is a checklist related to API Node changes, pricing updates, QA, and communications for Luma UNI-1 model implementation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@comfy_api_nodes/nodes_luma.py`:
- Line 827: validate_string is currently called on the raw prompt which allows
whitespace-only strings; change both calls that read validate_string(prompt,
min_length=1, max_length=6000) to validate_string(prompt.strip(), min_length=1,
max_length=6000) so the prompt is trimmed first and whitespace-only input is
rejected (apply the same change for the second occurrence in the file).
- Around line 681-689: The code currently uploads all entries in refs via
upload_image_to_comfyapi before enforcing max_count; change the logic in the
function handling refs to validate the number of provided references against
max_count before any calls to upload_image_to_comfyapi (or alternatively only
iterate up to max_count and skip/raise for extras). Specifically, check if refs
is truthy and then if len(refs) > max_count raise ValueError (or enforce a
slice) prior to the for loop that calls upload_image_to_comfyapi and constructs
Luma2ImageRef (ensure cls is still passed correctly to
upload_image_to_comfyapi).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b03eeb61-798a-4c06-a7e0-eff0664f977a

📥 Commits

Reviewing files that changed from the base of the PR and between fed8d5e and 037efe7.

⛔ Files ignored due to path filters (1)
  • comfy_api_nodes/apis/luma.py is excluded by !comfy_api_nodes/apis/**
📒 Files selected for processing (1)
  • comfy_api_nodes/nodes_luma.py

Comment thread comfy_api_nodes/nodes_luma.py
Comment thread comfy_api_nodes/nodes_luma.py
@bigcat88 bigcat88 merged commit c55ff85 into master May 5, 2026
17 checks passed
@bigcat88 bigcat88 deleted the feat/api-nodes/UNI-1 branch May 5, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants