[Partner Nodes] replace NanoBanana2 node with new node that uses Autogrow#13657
Draft
[Partner Nodes] replace NanoBanana2 node with new node that uses Autogrow#13657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding changes in the
app/node_replace_manager.pyfile:We should skip input_mapping entries whose
old_idis absent from the prompt.apply_replacementsreassigns inputs by indexingnode_struct["inputs"][old_id]directly, which raises KeyError whenever the old node had an optional input that the workflow didn't connect as Core omits unconnected optional input slots from the prompt JSON.This wasn't reachable before because every existing replacement (ImageBatch, ImageScaleBy) only maps required inputs, which are always present. The new GeminiNanoBanana2 -> GeminiNanoBanana2V2 replacement is the first to map optional slots (images, files) - text-to-image workflows, which leave both unconnected would crash without this guard.
API Node PR Checklist
Scope
Pricing & Billing
If Need pricing update:
QA
Comms