[Partner Nodes] add Gpt 5.5 and 5.5-pro LLM models#13673
Conversation
📝 WalkthroughWalkthroughThe PR adds two new members to the 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: bigcat88 <bigcat88@icloud.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
comfy_api_nodes/nodes_openai.py (1)
744-753: 💤 Low valuePricing values are correct;
$containsordering is correct.Confirmed against OpenAI's official pricing page:
gpt-5.5is priced at $5 per 1M input tokens and $30 per 1M output tokens ($0.005/$0.030 per 1K — matches lines 751), andgpt-5.5-prois priced at $30 per 1M input tokens and $180 per 1M output tokens ($0.030/$0.180 per 1K — matches line 746).The branch order (
gpt-5.5-probeforegpt-5.5) is correct: since"gpt-5.5"is a substring of"gpt-5.5-pro", reversing the order would misroute the pro model to the base pricing.One minor forward-looking note: if
gpt-5.5-miniorgpt-5.5-nanovariants are introduced later, the current$contains($m, "gpt-5.5")branch would silently absorb them with pro pricing before any dedicated branches could be added. This is the same pattern used elsewhere in the expression (gpt-5,gpt-4.1, etc.), so it's consistent — just worth keeping in mind when adding sub-variants.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@comfy_api_nodes/nodes_openai.py` around lines 744 - 753, Pricing values and ordering are correct, but to prevent future sub-variants (e.g., gpt-5.5-mini) from being misclassified, tighten the gpt-5.5 branch condition: replace the loose $contains($m, "gpt-5.5") check with a stricter matcher such as a regex $match($m, "^gpt-5\\.5($|[^-])") or add a negative check like $contains($m, "gpt-5.5") && !$contains($m, "gpt-5.5-"); keep the gpt-5.5-pro branch first and leave its condition unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@comfy_api_nodes/nodes_openai.py`:
- Around line 744-753: Pricing values and ordering are correct, but to prevent
future sub-variants (e.g., gpt-5.5-mini) from being misclassified, tighten the
gpt-5.5 branch condition: replace the loose $contains($m, "gpt-5.5") check with
a stricter matcher such as a regex $match($m, "^gpt-5\\.5($|[^-])") or add a
negative check like $contains($m, "gpt-5.5") && !$contains($m, "gpt-5.5-"); keep
the gpt-5.5-pro branch first and leave its condition unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c22161d1-ed3f-4929-bcb1-1138b3d26e21
📒 Files selected for processing (1)
comfy_api_nodes/nodes_openai.py
| gpt_4_1_nano = "gpt-4.1-nano" | ||
| o4_mini = "o4-mini" | ||
| o3 = "o3" | ||
| o1_pro = "o1-pro" |
There was a problem hiding this comment.
Looks like these models will be deprecated soon?
o1
o1-pro
o4-mini
gpt-4.1-nano
API Node PR Checklist
Scope
Pricing & Billing
If Need pricing update:
QA
Comms