CORE-329 feat: add Save 3D (Advanced) node family#14701
Conversation
jtydhr88
requested review from
Kosinkadink,
alexisrolland,
comfyanonymous,
guill,
kijai and
rattus128
as code owners
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis change adds advanced 3D file save support in 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@comfy_extras/nodes_save_3d.py`:
- Around line 409-420: The 3D save path helper is not forwarding the node’s
actual dimensions, so `%width%` and `%height%` in filename_prefix resolve to 0.
Update `_save_file3d_to_output` and its caller from `execute_save_3d_advanced`
to pass the real width/height values into `folder_paths.get_save_image_path`,
matching the pattern used by other Save* nodes so templated filenames use the
node inputs instead of defaults.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d9338cc5-1901-4422-b813-4dcd2a719ee1
📒 Files selected for processing (1)
comfy_extras/nodes_save_3d.py
| filename_prefix, folder_paths.get_output_directory() | ||
| ) | ||
| ext = model_3d.format or "glb" | ||
| saved_filename = f"{filename}_{counter:05}_.{ext}" |
There was a problem hiding this comment.
We are removing the trailing _ in Save (Advanced) nodes:
| saved_filename = f"{filename}_{counter:05}_.{ext}" | |
| saved_filename = f"{filename}_{counter:05}.{ext}" |
| IO.Load3DCamera.Input("camera_info", optional=True, advanced=True), | ||
| IO.Int.Input("width", default=1024, min=1, max=4096, step=1), | ||
| IO.Int.Input("height", default=1024, min=1, max=4096, step=1), | ||
| IO.String.Input("filename_prefix", default="3d/ComfyUI"), |
There was a problem hiding this comment.
I would propose to move this before the 3D viewport for a more consistent experience with other save nodes (filename_prefix is always before the preview).
Same feedback for Save Splat.
jtydhr88
force-pushed
the
CORE-329-save-3d-advanced
branch
from
eea3502 to
78d9bfd
Compare
2 participants
Add Save3DAdvanced, SaveGaussianSplat, and SavePointCloud as the save-side counterparts to the advanced preview nodes (Preview 3D (Advanced), Preview Splat, Preview Point Cloud).
Each mirrors its preview node's input/output shape and display name, and saves the File3D to the output directory under filename_prefix (preserving the original format), then emits PreviewUI3DAdvanced for the viewport.
FE change - Comfy-Org/ComfyUI_frontend#13330
Screenshot
Save 3D (Advanced)
Save Splat
