Clarify GLSL PyOpenGL acceleration log#14802
Draft
krakenunbound wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the startup log emitted when the GLSL node disables
PyOpenGL_accelerate.The previous PyOpenGL info message reads like GPU/OpenGL acceleration is missing. In this path, ComfyUI is intentionally using the ANGLE/EGL GLSL backend and disabling only PyOpenGL's optional wrapper acceleration layer for compatibility.
Why
OpenGL.USE_ACCELERATE = Falseis intentional here, but PyOpenGL logsNo OpenGL_accelerate module loaded: Acceleration disabled, which can be misleading for users because it sounds like GPU shader rendering is disabled.This adds a ComfyUI-side info line that makes the distinction explicit and raises the PyOpenGL accelerate-support logger to
WARNINGso the misleading info line does not appear.Validation
python -m py_compile comfy_extras/nodes_glsl.py