Skip to content

Commit 2120c13

Browse files
committed
chore: add CodeRabbit Playwright path instruction
Route changed browser_tests/**/*.spec.ts files through CodeRabbit guidance that explicitly names .agents/checks/test-quality.md and docs/testing/README.md as required review context. Verification: parsed .coderabbit.yaml with Ruby YAML, ran git diff --check, and ran pnpm typecheck in this worktree.
1 parent 0b66a81 commit 2120c13

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

.coderabbit.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,3 +84,11 @@ reviews:
8484
Treat `.agents/checks/test-quality.md`, `docs/testing/README.md`, and `docs/guidance/vitest.md` as required review context for every changed litegraph Vitest test file.
8585
Reuse shared factories in `src/utils/__tests__/litegraphTestUtils.ts` instead of hand-rolling litegraph mock builders.
8686
Flag mocked litegraph classes when a real instance or shared factory would exercise behavior directly.
87+
- path: 'browser_tests/**/*.spec.ts'
88+
instructions: |
89+
Treat `.agents/checks/test-quality.md` and `docs/testing/README.md` as required review context for every changed Playwright test file.
90+
Flag missing behavioral coverage, change-detector tests, mock-heavy tests, snapshot abuse, fragile assertions, missing edge cases, unclear setup, and test isolation problems.
91+
Every route.fulfill() body must be typed with generated types or schemas from packages/ingest-types, packages/registry-types, src/workbench/extensions/manager/types/generatedManagerTypes.ts, or src/schemas/; flag untyped inline JSON objects.
92+
Never use waitForTimeout; use Locator actions and auto-retrying assertions instead.
93+
Restrict page.evaluate() to reading internal state or fixture setup; flag any page.evaluate() that drives UI actions when a Playwright action method exists.
94+
New shared test helpers must be Playwright fixtures via base.extend(), not properties added to ComfyPage.

0 commit comments

Comments
 (0)