refactor: encapsulate execution error store writes behind record actions (#13636)

## Summary

Encapsulate `executionErrorStore`'s raw error state behind record
actions and deduplicate the slot-matching/prompt-error-shape logic that
callers had copy-pasted around it.

## Changes

- **What**:
- `executionErrorStore`: new `recordNodeErrors` / `recordExecutionError`
/ `recordPromptError` actions; `lastNodeErrors` / `lastExecutionError` /
`lastPromptError` are now exposed as read-only computeds, so external
writes are a compile-time error. The empty-record → `null` normalization
lives in exactly one place, which also lets `hasNodeError` and
`clearExecutionStartErrors` drop their now-dead emptiness checks
(invariant: the record is always `null` or non-empty).
- Direct-assignment call sites migrated: `app.ts` (queuePrompt success +
`PromptExecutionError` paths), `executionStore.ts`
(execution/service-level/cloud-validation errors), `subgraphStore.ts`
(blueprint validation — key shape and empty-`errors` semantics
intentionally unchanged).
- `executionErrorUtil.ts`: extracted `normalizePromptError` (shared by
the HTTP catch path and `classifyCloudValidationError`, which previously
duplicated the object/string branching) and added `errorsForSlot` /
`hasErrorForSlot`, replacing six inline copies of the
`extra_info.input_name` matching across the store,
`useNodeErrorFlagSync`, and `useProcessedWidgets`.
- `app.queuePrompt()`'s public boolean result is preserved
byte-for-byte: a local `queueResultOverride` keeps the pre-normalization
semantics for the `PromptExecutionError` path (absent/`null`
`node_errors` → `true`, `{}`/populated → `false`, last processed queue
item wins across multi-item runs). Regression tests pin all three
branches, including a multi-item concurrency case.
- Tests: 12 suites that seeded error state by direct assignment now seed
through the record actions. `TabErrors.test.ts` moved off
`createTestingPinia({ initialState })` — `initialState` cannot seed
computed-exposed state and was silently no-oping — to `stubActions:
false` with action-based seeding, which also surfaced and fixed
schema-incomplete fixtures (`executed`, missing error `type`/`details`)
and a missing `refreshMissingModels` on the app mock.
- **Breaking**: none. `app.lastNodeErrors` (deprecated getter) and
`workspaceStore.lastNodeErrors` are read-only surfaces and keep working;
after a validation failure with an empty record they now read `null`
instead of `{}`, matching the advertised `Record | null` type and the
behavior the success path already had.

## Review Focus

- Behavior equivalence of the `queuePrompt` return contract:
`queueResultOverride` is set only in the `PromptExecutionError` catch
(`!nodeErrors`, computed before normalization) and reset on each
successful iteration; every other exit falls through to the
store-derived value as before. The `node_errors` field is typed optional
but arrives from an unvalidated `JSON.parse` on the error path, so
`null` is runtime-reachable — hence `!nodeErrors` rather than an
`undefined` check, with a `null`-seeding regression test.
- The store's null-or-non-empty invariant: `recordNodeErrors` and the
internal clear path are the only writers; both normalize.

Author: jaeone94

src/components/error/ErrorOverlay.test.ts

@@ -152,9 +152,9 @@ describe('ErrorOverlay', () => {
     renderOverlay()
 
     const executionErrorStore = useExecutionErrorStore()
-    executionErrorStore.lastNodeErrors = {
+    executionErrorStore.recordNodeErrors({
       '1': makeNodeError(['Only error'])
-    }
+    })
     executionErrorStore.showErrorOverlay()
     await nextTick()
 
@@ -189,9 +189,9 @@ describe('ErrorOverlay', () => {
     renderOverlay({ appMode: true })
 
     const executionErrorStore = useExecutionErrorStore()
-    executionErrorStore.lastNodeErrors = {
+    executionErrorStore.recordNodeErrors({
       '1': makeNodeError(['Only error'])
-    }
+    })
     executionErrorStore.showErrorOverlay()
     await nextTick()
 

src/components/error/useErrorOverlayState.test.ts

@@ -131,9 +131,9 @@ describe('useErrorOverlayState', () => {
     mountOverlayState()
 
     const executionErrorStore = useExecutionErrorStore()
-    executionErrorStore.lastNodeErrors = {
+    executionErrorStore.recordNodeErrors({
       '1': makeNodeError(['Only error'])
-    }
+    })
     executionErrorStore.showErrorOverlay()
     await nextTick()
 
@@ -168,9 +168,9 @@ describe('useErrorOverlayState', () => {
     mountOverlayState()
 
     const executionErrorStore = useExecutionErrorStore()
-    executionErrorStore.lastNodeErrors = {
+    executionErrorStore.recordNodeErrors({
       '1': makeNodeError(['Required input is missing'])
-    }
+    })
     executionErrorStore.showErrorOverlay()
     await nextTick()
 
@@ -207,9 +207,9 @@ describe('useErrorOverlayState', () => {
     mountOverlayState()
 
     const executionErrorStore = useExecutionErrorStore()
-    executionErrorStore.lastNodeErrors = {
+    executionErrorStore.recordNodeErrors({
       '1': makeNodeError(['Raw validation error'])
-    }
+    })
     executionErrorStore.showErrorOverlay()
     await nextTick()
 
@@ -248,7 +248,7 @@ describe('useErrorOverlayState', () => {
     mountOverlayState()
 
     const executionErrorStore = useExecutionErrorStore()
-    executionErrorStore.lastExecutionError = {
+    executionErrorStore.recordExecutionError({
       prompt_id: 'prompt',
       node_id: 1,
       node_type: 'KSampler',
@@ -257,7 +257,7 @@ describe('useErrorOverlayState', () => {
       exception_type: 'torch.OutOfMemoryError',
       traceback: [],
       timestamp: Date.now()
-    }
+    })
     executionErrorStore.showErrorOverlay()
     await nextTick()
 
@@ -474,9 +474,9 @@ describe('useErrorOverlayState', () => {
     mountOverlayState()
 
     const executionErrorStore = useExecutionErrorStore()
-    executionErrorStore.lastNodeErrors = {
+    executionErrorStore.recordNodeErrors({
       '1': makeNodeError(['Only error'])
-    }
+    })
     executionErrorStore.showErrorOverlay()
     await nextTick()
 

src/components/rightSidePanel/errors/ErrorGroupList.test.ts

@@ -63,10 +63,7 @@ const LOADER_NODE = { id: '2', title: 'LoaderNode' }
 
 function seedTwoErrorGroups(pinia: TestingPinia) {
   const executionErrorStore = useExecutionErrorStore(pinia)
-  executionErrorStore.lastNodeErrors = fromAny<
-    typeof executionErrorStore.lastNodeErrors,
-    unknown
-  >({
+  executionErrorStore.recordNodeErrors({
     '1': {
       class_type: 'KSampler',
       dependent_outputs: [],
@@ -83,7 +80,11 @@ function seedTwoErrorGroups(pinia: TestingPinia) {
       class_type: 'CLIPLoader',
       dependent_outputs: [],
       errors: [
-        { type: 'weird_error', message: 'Something odd happened', details: '' }
+        {
+          type: 'weird_error',
+          message: 'Something odd happened',
+          details: ''
+        }
       ]
     }
   })