Skip to content

Commit 630ae61

Browse files
authored
chore: update core dev dependencies (#13733)
## Summary Bump core dev toolchain (Vue/Vite/Oxlint/Oxfmt/ESLint/pnpm + ecosystem) to latest same-major versions, with the small compat fixes the new versions require. ## Changes - **What**: Catalog bumps in `pnpm-workspace.yaml`: vue 3.5.39, vite 8.1.4, oxlint 1.74, oxfmt 0.59, eslint 10.7, vitest 4.1.10, vue-tsc 3.3.7, tailwindcss 4.3.2, @playwright/test 1.61.1, storybook 10.5.0, knip 6.27, typescript-eslint 8.64, @vueuse 14.3 + assorted ecosystem minors. `packageManager` pnpm 11.3.0 → 11.13.1. - **Compat fixes**: - `defineModel` default-factory param typing in `WidgetSelectDefault.vue`/`WidgetSelectDropdown.vue` (vue 3.5.40+ types it as `Record<string, unknown>`) - `useClipboard` mock in `useCopyToClipboard.test.ts` (vueuse 14.3: `ComputedRef` fields + new `copyPending`) - Removed two knip ignores obsoleted by knip 6.27 (config treats hints as errors) - Renamed invalid CSS ident `--color-dark-elevation-1.5` → `-1-5` (dot is not a valid ident char; unused; oxfmt 0.59 hard-errors on it) - oxfmt 0.59 reformat as a separate commit (small churn, 8 files) - **Held back**: happy-dom pinned at 20.9.0 — 20.10.x throws sync `NotSupportedError` on external `<script>` append, breaking GTM/Typeform loader tests. Majors deferred to individual PRs: typescript 7, pinia 4, vue-router 5, vue-i18n 11, stylelint 17, jsdom 29, globals 17, unplugin-* majors, vite-plugin-dts 5, @types/node 25. - **Dependencies**: version bumps only, no new packages. no `minimumReleaseAgeExclude` exemptions — range floors sit at the newest age-compliant releases (vue 3.5.40, vite 8.1.5, tailwind 4.3.3, storybook 10.5.2 are <24h old and flow in automatically once they pass the gate). ## Review Focus - Unit suite failures match main exactly (previewAny/uploadAudio pre-existing flakes); typecheck, lint, knip, build all green. Desktop-ui typecheck failures are identical on main (pre-existing, untouched). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
1 parent 179c1dd commit 630ae61

22 files changed

Lines changed: 4917 additions & 4597 deletions

File tree

.github/workflows/ci-perf-report.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
runs-on: ubuntu-latest
3232
timeout-minutes: 30
3333
container:
34-
image: ghcr.io/comfy-org/comfyui-ci-container:0.0.17
34+
image: ghcr.io/comfy-org/comfyui-ci-container:0.0.21
3535
credentials:
3636
username: ${{ github.actor }}
3737
password: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/ci-tests-e2e.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
runs-on: ubuntu-latest
6464
timeout-minutes: 60
6565
container:
66-
image: ghcr.io/comfy-org/comfyui-ci-container:0.0.17
66+
image: ghcr.io/comfy-org/comfyui-ci-container:0.0.21
6767
credentials:
6868
username: ${{ github.actor }}
6969
password: ${{ secrets.GITHUB_TOKEN }}
@@ -121,7 +121,7 @@ jobs:
121121
needs: setup
122122
runs-on: ubuntu-latest
123123
container:
124-
image: ghcr.io/comfy-org/comfyui-ci-container:0.0.17
124+
image: ghcr.io/comfy-org/comfyui-ci-container:0.0.21
125125
credentials:
126126
username: ${{ github.actor }}
127127
password: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/ci-website-e2e.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
if: ${{ needs.changes.outputs.app-website-changes == 'true' || needs.changes.outputs.packages-changes == 'true' }}
2929
runs-on: ubuntu-latest
3030
container:
31-
image: mcr.microsoft.com/playwright:v1.58.1-noble
31+
image: mcr.microsoft.com/playwright:v1.61.1-noble
3232
timeout-minutes: 15
3333
permissions:
3434
contents: read

.github/workflows/pr-update-playwright-expectations.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ jobs:
7777
needs: setup
7878
runs-on: ubuntu-latest
7979
container:
80-
image: ghcr.io/comfy-org/comfyui-ci-container:0.0.17
80+
image: ghcr.io/comfy-org/comfyui-ci-container:0.0.21
8181
credentials:
8282
username: ${{ github.actor }}
8383
password: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/pr-update-website-screenshots.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
update-screenshots:
1515
runs-on: ubuntu-latest
1616
container:
17-
image: mcr.microsoft.com/playwright:v1.58.1-noble
17+
image: mcr.microsoft.com/playwright:v1.61.1-noble
1818
timeout-minutes: 15
1919
permissions:
2020
contents: write
@@ -128,6 +128,9 @@ jobs:
128128

129129
- name: Remove label
130130
if: always() && github.event_name == 'pull_request'
131+
# Label cleanup is best-effort; the restricted pull_request token may
132+
# lack permission to remove labels and must not fail the run.
133+
continue-on-error: true
131134
uses: actions/github-script@v8
132135
env:
133136
PR_NUMBER: ${{ steps.pr-info.outputs.pr-number }}

browser_tests/fixtures/data/README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ import { mockSystemStats } from '../fixtures/data/systemStats'
1717

1818
// Extend the base set with test-specific nodes
1919
const nodeDefs = createMockNodeDefinitions({
20-
MyCustomNode: {
21-
/* ... */
22-
}
20+
MyCustomNode: {/* ... */}
2321
})
2422

2523
await page.route('**/api/object_info', (route) =>

docs/guidance/storybook.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,7 @@ export default meta
3131
type Story = StoryObj<typeof meta>
3232

3333
export const Default: Story = {
34-
args: {
35-
/* props */
36-
}
34+
args: {/* props */}
3735
}
3836
```
3937

knip.config.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,8 @@ const config: KnipConfig = {
3737
entry: ['src/scripts/**/*.ts']
3838
}
3939
},
40-
ignoreBinaries: ['python3'],
4140
ignoreDependencies: [
4241
// Weird importmap things
43-
'@iconify-json/lucide',
4442
'@iconify/json',
4543
'@primeuix/forms',
4644
'@primeuix/styled',

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
"@vee-validate/zod": "catalog:",
9898
"@vueuse/core": "catalog:",
9999
"@vueuse/integrations": "catalog:",
100-
"@vueuse/router": "^14.2.0",
100+
"@vueuse/router": "^14.3.0",
101101
"@xterm/addon-fit": "^0.10.0",
102102
"@xterm/addon-serialize": "^0.13.0",
103103
"@xterm/xterm": "^5.5.0",
@@ -111,7 +111,7 @@
111111
"extendable-media-recorder": "^9.2.27",
112112
"extendable-media-recorder-wav-encoder": "^7.0.129",
113113
"firebase": "catalog:",
114-
"fuse.js": "^7.0.0",
114+
"fuse.js": "7.0.0",
115115
"glob": "catalog:",
116116
"jsonata": "catalog:",
117117
"loglevel": "^1.9.2",
@@ -219,5 +219,5 @@
219219
"node": ">=25 <26",
220220
"pnpm": ">=11.3"
221221
},
222-
"packageManager": "pnpm@11.3.0"
222+
"packageManager": "pnpm@11.13.1"
223223
}

packages/design-system/src/css/style.css

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@
7878
--color-interface-panel-job-progress-border: var(--base-foreground);
7979

8080
--color-blue-selection: rgb(from var(--color-azure-600) r g b / 0.3);
81-
--color-node-hover-100: rgb(from var(--color-charcoal-800) r g b/ 0.15);
82-
--color-node-hover-200: rgb(from var(--color-charcoal-800) r g b/ 0.1);
83-
--color-modal-tag: rgb(from var(--color-smoke-400) r g b/ 0.4);
81+
--color-node-hover-100: rgb(from var(--color-charcoal-800) r g b / 0.15);
82+
--color-node-hover-200: rgb(from var(--color-charcoal-800) r g b / 0.1);
83+
--color-modal-tag: rgb(from var(--color-smoke-400) r g b / 0.4);
8484
--color-alpha-charcoal-600-30: color-mix(
8585
in srgb,
8686
var(--color-charcoal-600) 30%,
@@ -107,7 +107,7 @@
107107
--color-highlight: var(--p-primary-color);
108108

109109
/* Special Colors (temporary) */
110-
--color-dark-elevation-1.5: rgba(from white r g b/ 0.015);
110+
--color-dark-elevation-1-5: rgba(from white r g b / 0.015);
111111
--color-dark-elevation-2: rgba(from white r g b / 0.03);
112112
}
113113

@@ -1853,17 +1853,17 @@ audio.comfy-audio.empty-audio-widget {
18531853
/* Shadow Cover TOP */
18541854
linear-gradient(--value(--color-*) 30%, transparent) center top,
18551855
/* Shadow Cover BOTTOM */
1856-
linear-gradient(transparent, --value(--color-*) 70%) center bottom,
1856+
linear-gradient(transparent, --value(--color-*) 70%) center bottom,
18571857
/* Shadow TOP */
1858-
radial-gradient(
1858+
radial-gradient(
18591859
farthest-side at 50% 0,
18601860
color-mix(in oklab, --value(--color-*), #777777 35%),
18611861
60%,
18621862
transparent
18631863
)
18641864
center top,
18651865
/* Shadow BOTTOM */
1866-
radial-gradient(
1866+
radial-gradient(
18671867
farthest-side at 50% 100%,
18681868
color-mix(in oklab, --value(--color-*), #777777 35%),
18691869
60%,

0 commit comments

Comments
 (0)