test: add tests for dialogService and cloudRemoteConfig

Addresses review feedback:
#11464 (review)

Author: christian-byrne

src/extensions/core/cloudRemoteConfig.test.ts

@@ -0,0 +1,103 @@
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+const {
+  mockIsLoggedIn,
+  mockCanAccessSubscriptionFeatures,
+  mockRefreshRemoteConfig,
+  mockRegisterExtension,
+  mockWatchDebounced
+} = vi.hoisted(() => ({
+  mockIsLoggedIn: { value: false },
+  mockCanAccessSubscriptionFeatures: { value: true },
+  mockRefreshRemoteConfig: vi.fn(),
+  mockRegisterExtension: vi.fn(),
+  mockWatchDebounced: vi.fn()
+}))
+
+vi.mock('@vueuse/core', () => ({
+  watchDebounced: mockWatchDebounced
+}))
+
+vi.mock('@/composables/auth/useCurrentUser', () => ({
+  useCurrentUser: () => ({
+    isLoggedIn: mockIsLoggedIn
+  })
+}))
+
+vi.mock('@/composables/billing/useBillingContext', () => ({
+  useBillingContext: () => ({
+    canAccessSubscriptionFeatures: mockCanAccessSubscriptionFeatures
+  })
+}))
+
+vi.mock('@/platform/remoteConfig/refreshRemoteConfig', () => ({
+  refreshRemoteConfig: mockRefreshRemoteConfig
+}))
+
+vi.mock('@/services/extensionService', () => ({
+  useExtensionService: () => ({
+    registerExtension: mockRegisterExtension
+  })
+}))
+
+describe('cloudRemoteConfig extension', () => {
+  beforeEach(() => {
+    vi.clearAllMocks()
+    vi.resetModules()
+    mockIsLoggedIn.value = false
+    mockCanAccessSubscriptionFeatures.value = true
+  })
+
+  it('registers extension with correct name', async () => {
+    await import('./cloudRemoteConfig')
+
+    expect(mockRegisterExtension).toHaveBeenCalledWith(
+      expect.objectContaining({
+        name: 'Comfy.Cloud.RemoteConfig'
+      })
+    )
+  })
+
+  it('setup watches isLoggedIn and canAccessSubscriptionFeatures', async () => {
+    await import('./cloudRemoteConfig')
+
+    const registeredExtension = mockRegisterExtension.mock.calls[0][0]
+    await registeredExtension.setup()
+
+    expect(mockWatchDebounced).toHaveBeenCalledWith(
+      [mockIsLoggedIn, mockCanAccessSubscriptionFeatures],
+      expect.any(Function),
+      expect.objectContaining({ debounce: 256, immediate: true })
+    )
+  })
+
+  it('watch callback refreshes config when logged in', async () => {
+    await import('./cloudRemoteConfig')
+
+    const registeredExtension = mockRegisterExtension.mock.calls[0][0]
+    await registeredExtension.setup()
+
+    // Get the callback passed to watchDebounced
+    const watchCallback = mockWatchDebounced.mock.calls[0][1]
+
+    // Simulate logged in state
+    mockIsLoggedIn.value = true
+    watchCallback()
+
+    expect(mockRefreshRemoteConfig).toHaveBeenCalled()
+  })
+
+  it('watch callback does not refresh when not logged in', async () => {
+    await import('./cloudRemoteConfig')
+
+    const registeredExtension = mockRegisterExtension.mock.calls[0][0]
+    await registeredExtension.setup()
+
+    const watchCallback = mockWatchDebounced.mock.calls[0][1]
+
+    mockIsLoggedIn.value = false
+    watchCallback()
+
+    expect(mockRefreshRemoteConfig).not.toHaveBeenCalled()
+  })
+})

src/services/dialogService.test.ts

@@ -0,0 +1,108 @@
+import { createPinia, setActivePinia } from 'pinia'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+const {
+  mockCanAccessSubscriptionFeatures,
+  mockIsFreeTier,
+  mockBillingType,
+  mockShowDialog
+} = vi.hoisted(() => ({
+  mockCanAccessSubscriptionFeatures: { value: true },
+  mockIsFreeTier: { value: false },
+  mockBillingType: { value: 'legacy' as 'legacy' | 'workspace' },
+  mockShowDialog: vi.fn()
+}))
+
+vi.mock('@/composables/billing/useBillingContext', () => ({
+  useBillingContext: () => ({
+    canAccessSubscriptionFeatures: mockCanAccessSubscriptionFeatures,
+    isFreeTier: mockIsFreeTier,
+    type: mockBillingType
+  })
+}))
+
+vi.mock('@/stores/dialogStore', () => ({
+  useDialogStore: () => ({
+    showDialog: mockShowDialog,
+    closeDialog: vi.fn()
+  })
+}))
+
+vi.mock('@/platform/telemetry', () => ({
+  useTelemetry: () => ({
+    trackEvent: vi.fn()
+  })
+}))
+
+vi.mock('@/i18n', () => ({
+  t: (key: string) => key
+}))
+
+vi.mock('@/platform/distribution/types', () => ({
+  isCloud: true
+}))
+
+describe('dialogService', () => {
+  beforeEach(() => {
+    setActivePinia(createPinia())
+    vi.clearAllMocks()
+    mockCanAccessSubscriptionFeatures.value = true
+    mockIsFreeTier.value = false
+    mockBillingType.value = 'legacy'
+  })
+
+  describe('showTopUpCreditsDialog', () => {
+    it('shows top up dialog for legacy billing when canAccessSubscriptionFeatures is true', async () => {
+      mockCanAccessSubscriptionFeatures.value = true
+      mockIsFreeTier.value = false
+      mockBillingType.value = 'legacy'
+
+      const { useDialogService } = await import('./dialogService')
+      const dialogService = useDialogService()
+
+      await dialogService.showTopUpCreditsDialog()
+
+      expect(mockShowDialog).toHaveBeenCalledWith(
+        expect.objectContaining({
+          key: 'top-up-credits'
+        })
+      )
+    })
+
+    it('shows workspace top up dialog when type is workspace', async () => {
+      mockCanAccessSubscriptionFeatures.value = true
+      mockIsFreeTier.value = false
+      mockBillingType.value = 'workspace'
+
+      const { useDialogService } = await import('./dialogService')
+      const dialogService = useDialogService()
+
+      await dialogService.showTopUpCreditsDialog()
+
+      expect(mockShowDialog).toHaveBeenCalledWith(
+        expect.objectContaining({
+          key: 'top-up-credits'
+        })
+      )
+    })
+
+    it('passes options to dialog when canAccessSubscriptionFeatures', async () => {
+      mockCanAccessSubscriptionFeatures.value = true
+      mockIsFreeTier.value = false
+
+      const { useDialogService } = await import('./dialogService')
+      const dialogService = useDialogService()
+
+      await dialogService.showTopUpCreditsDialog({
+        isInsufficientCredits: true
+      })
+
+      expect(mockShowDialog).toHaveBeenCalledWith(
+        expect.objectContaining({
+          key: 'top-up-credits',
+          props: { isInsufficientCredits: true }
+        })
+      )
+    })
+  })
+})