fix: satisfy upgraded TypeScript checks

Author: huang47

apps/desktop-ui/.storybook/preview.ts

@@ -77,7 +77,6 @@ const preview: Preview = {
           { value: 'light', icon: 'sun', title: 'Light' },
           { value: 'dark', icon: 'moon', title: 'Dark' }
         ],
-        showName: true,
         dynamicTitle: true
       }
     }

apps/desktop-ui/src/composables/bottomPanelTabs/useTerminal.test.ts

@@ -1,32 +1,30 @@
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { ref } from 'vue'
 
-const { mockTerminal, MockTerminal, mockFitAddon, MockFitAddon } = vi.hoisted(
-  () => {
-    const mockTerminal = {
-      loadAddon: vi.fn(),
-      attachCustomKeyEventHandler: vi.fn(),
-      open: vi.fn(),
-      dispose: vi.fn(),
-      hasSelection: vi.fn<[], boolean>(),
-      resize: vi.fn(),
-      cols: 80,
-      rows: 24
-    }
-    const MockTerminal = vi.fn(function () {
-      return mockTerminal
-    })
-
-    const mockFitAddon = {
-      proposeDimensions: vi.fn().mockReturnValue({ cols: 80, rows: 24 })
-    }
-    const MockFitAddon = vi.fn(function () {
-      return mockFitAddon
-    })
+const { mockTerminal, MockTerminal, MockFitAddon } = vi.hoisted(() => {
+  const mockTerminal = {
+    loadAddon: vi.fn(),
+    attachCustomKeyEventHandler: vi.fn(),
+    open: vi.fn(),
+    dispose: vi.fn(),
+    hasSelection: vi.fn<() => boolean>(),
+    resize: vi.fn(),
+    cols: 80,
+    rows: 24
+  }
+  const MockTerminal = vi.fn(function () {
+    return mockTerminal
+  })
 
-    return { mockTerminal, MockTerminal, mockFitAddon, MockFitAddon }
+  const mockFitAddon = {
+    proposeDimensions: vi.fn().mockReturnValue({ cols: 80, rows: 24 })
   }
-)
+  const MockFitAddon = vi.fn(function () {
+    return mockFitAddon
+  })
+
+  return { mockTerminal, MockTerminal, MockFitAddon }
+})
 
 vi.mock('@xterm/xterm', () => ({ Terminal: MockTerminal }))
 vi.mock('@xterm/addon-fit', () => ({ FitAddon: MockFitAddon }))

apps/desktop-ui/src/composables/bottomPanelTabs/useTerminalBuffer.test.ts

@@ -1,7 +1,7 @@
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 const { mockSerialize, MockSerializeAddon } = vi.hoisted(() => {
-  const mockSerialize = vi.fn<[], string>()
+  const mockSerialize = vi.fn<() => string>()
   const MockSerializeAddon = vi.fn(function () {
     return { serialize: mockSerialize }
   })
@@ -33,15 +33,15 @@ describe('useTerminalBuffer', () => {
       mockSerialize.mockReturnValue('hello world')
       const { copyTo } = withSetup(() => useTerminalBuffer())
       const mockWrite = vi.fn()
-      copyTo({ write: mockWrite } as Pick<Terminal, 'write'>)
+      copyTo({ write: mockWrite } as unknown as Terminal)
       expect(mockWrite).toHaveBeenCalledWith('hello world')
     })
 
     it('writes empty string when buffer is empty', () => {
       mockSerialize.mockReturnValue('')
       const { copyTo } = withSetup(() => useTerminalBuffer())
       const mockWrite = vi.fn()
-      copyTo({ write: mockWrite } as Pick<Terminal, 'write'>)
+      copyTo({ write: mockWrite } as unknown as Terminal)
       expect(mockWrite).toHaveBeenCalledWith('')
     })
   })

apps/desktop-ui/src/constants/desktopDialogs.test.ts

@@ -28,7 +28,7 @@ describe('getDialog', () => {
   it('returns a deep clone — mutations do not affect the original', () => {
     const result = getDialog('reinstallVenv')
     const originalFirstLabel = DESKTOP_DIALOGS.reinstallVenv.buttons[0].label
-    result.buttons[0].label = 'Mutated'
+    ;(result.buttons as Array<{ label: string }>)[0].label = 'Mutated'
     expect(DESKTOP_DIALOGS.reinstallVenv.buttons[0].label).toBe(
       originalFirstLabel
     )

apps/desktop-ui/src/constants/desktopMaintenanceTasks.test.ts

@@ -3,11 +3,11 @@ import { beforeEach, describe, expect, it, vi } from 'vitest'
 const { mockElectron } = vi.hoisted(() => ({
   mockElectron: {
     setBasePath: vi.fn(),
-    reinstall: vi.fn<[], Promise<void>>().mockResolvedValue(undefined),
+    reinstall: vi.fn<() => Promise<void>>().mockResolvedValue(undefined),
     uv: {
-      installRequirements: vi.fn<[], Promise<void>>(),
-      clearCache: vi.fn<[], Promise<void>>().mockResolvedValue(undefined),
-      resetVenv: vi.fn<[], Promise<void>>().mockResolvedValue(undefined)
+      installRequirements: vi.fn<() => Promise<void>>(),
+      clearCache: vi.fn<() => Promise<void>>().mockResolvedValue(undefined),
+      resetVenv: vi.fn<() => Promise<void>>().mockResolvedValue(undefined)
     }
   }
 }))
@@ -48,24 +48,24 @@ describe('desktopMaintenanceTasks', () => {
   })
 
   describe('URL-opening tasks', () => {
-    it('git execute opens the git download page', () => {
-      findTask('git').execute()
+    it('git execute opens the git download page', async () => {
+      expect(await findTask('git').execute()).toBe(true)
       expect(window.open).toHaveBeenCalledWith(
         'https://git-scm.com/downloads/',
         '_blank'
       )
     })
 
-    it('uv execute opens the uv installation page', () => {
-      findTask('uv').execute()
+    it('uv execute opens the uv installation page', async () => {
+      expect(await findTask('uv').execute()).toBe(true)
       expect(window.open).toHaveBeenCalledWith(
         'https://docs.astral.sh/uv/getting-started/installation/',
         '_blank'
       )
     })
 
-    it('vcRedist execute opens the VC++ redistributable download', () => {
-      findTask('vcRedist').execute()
+    it('vcRedist execute opens the VC++ redistributable download', async () => {
+      expect(await findTask('vcRedist').execute()).toBe(true)
       expect(window.open).toHaveBeenCalledWith(
         'https://aka.ms/vs/17/release/vc_redist.x64.exe',
         '_blank'

apps/desktop-ui/src/utils/electronMirrorCheck.test.ts

@@ -3,7 +3,7 @@ import { beforeEach, describe, expect, it, vi } from 'vitest'
 const { mockElectron } = vi.hoisted(() => ({
   mockElectron: {
     NetWork: {
-      canAccessUrl: vi.fn<[url: string], Promise<boolean>>()
+      canAccessUrl: vi.fn<(url: string) => Promise<boolean>>()
     }
   }
 }))

apps/desktop-ui/src/utils/envUtil.ts

@@ -1,11 +1,17 @@
 import type { ElectronAPI } from '@comfyorg/comfyui-electron-types'
 
+export type ElectronWindow = typeof window & {
+  electronAPI: Record<string, unknown> & {
+    Config: Record<string, unknown>
+  }
+}
+
 export function isElectron() {
   return 'electronAPI' in window && window.electronAPI !== undefined
 }
 
 export function electronAPI() {
-  return (window as any).electronAPI as ElectronAPI
+  return (window as ElectronWindow).electronAPI as ElectronAPI
 }
 
 export function isNativeWindow() {

apps/desktop-ui/tsconfig.json

@@ -6,7 +6,13 @@
     "paths": {
       "@/*": ["./src/*"],
       "@frontend-locales/*": ["../../src/locales/*"]
-    }
+    },
+    "types": [
+      "vite/client",
+      "vitest/globals",
+      "@webgpu/types",
+      "@testing-library/jest-dom/vitest"
+    ]
   },
   "include": [
     ".storybook/**/*",

packages/shared-frontend-utils/src/piiUtil.test.ts

@@ -1,6 +1,7 @@
 import { describe, expect, it } from 'vitest'
 
 import { createPostHogBeforeSend } from './piiUtil'
+import type { PostHogEventLike } from './piiUtil'
 
 describe('createPostHogBeforeSend', () => {
   const beforeSend = createPostHogBeforeSend()
@@ -10,7 +11,7 @@ describe('createPostHogBeforeSend', () => {
   })
 
   it('strips all PII keys from properties, $set, and $set_once', () => {
-    const event = {
+    const event: PostHogEventLike = {
       properties: {
         email: 'a@example.com',
         prompt: 'hello',
@@ -48,7 +49,9 @@ describe('createPostHogBeforeSend', () => {
   })
 
   it('handles missing property bags gracefully', () => {
-    const event = { properties: { email: 'a@example.com', safe: true } }
+    const event: PostHogEventLike = {
+      properties: { email: 'a@example.com', safe: true }
+    }
     const result = beforeSend(event)!
     expect(result.properties).not.toHaveProperty('email')
     expect(result.properties).toHaveProperty('safe', true)

packages/shared-frontend-utils/src/piiUtil.ts

@@ -16,7 +16,7 @@ function stripPiiKeys(obj?: Record<string, unknown>): void {
  *
  * Ref: posthog.com/tutorials/web-redact-properties
  */
-interface PostHogEventLike {
+export interface PostHogEventLike {
   properties?: Record<string, unknown>
   $set?: Record<string, unknown>
   $set_once?: Record<string, unknown>