refactor: simplify promoted widget handling

Author: DrJKL

src/components/rightSidePanel/parameters/WidgetActions.test.ts

@@ -236,7 +236,10 @@ describe('WidgetActions', () => {
       type: 'TestNode',
       rootGraph: { id: 'graph-test' },
       isSubgraphNode: () => true,
-      getSlotFromWidget: () => ({ widgetId: 'graph-test:1:test_widget' })
+      getSlotFromWidget: (candidate: IBaseWidget) =>
+        candidate.name === 'test_widget'
+          ? { widgetId: 'graph-test:1:test_widget' }
+          : undefined
     })
     const host = fromAny<SubgraphNode, unknown>({ id: 2 })
 
@@ -247,11 +250,12 @@ describe('WidgetActions', () => {
     ).not.toBeInTheDocument()
   })
 
-  it('toggles the favorite for the host node itself', async () => {
+  it("toggles the favorite for the row's node", async () => {
     const widget = createMockWidget()
     const node = createMockNode()
+    const host = fromAny<SubgraphNode, unknown>({ id: 2 })
 
-    const { user } = renderWidgetActions(widget, node)
+    const { user } = renderWidgetActions(widget, node, { host })
 
     await user.click(screen.getByRole('button', { name: /Favorite/ }))
 

src/components/rightSidePanel/subgraph/SubgraphEditor.vue

@@ -248,7 +248,7 @@ function rowDisplayName(row: ActiveRow): string {
 }
 
 function isRowLinked(row: ActiveRow): boolean {
-  return row.kind === 'promoted' && row.input.widgetId != null
+  return row.kind === 'promoted'
 }
 
 function promotedRowKey(row: PromotedRow): string {
@@ -269,10 +269,10 @@ function demoteRow(row: ActiveRow) {
   const subgraphNode = activeNode.value
   if (!subgraphNode) return
   if (row.kind === 'promoted') {
-    const linkedInput = row.input._subgraphSlot
-    if (linkedInput) {
-      if (row.input.link != null) linkedInput.disconnect()
-      else subgraphNode.subgraph.removeInput(linkedInput)
+    const subgraphSlot = row.input._subgraphSlot
+    if (subgraphSlot) {
+      if (row.input.link != null) subgraphSlot.disconnect()
+      else subgraphNode.subgraph.removeInput(subgraphSlot)
     }
     refreshPromotedWidgetRendering()
     return