fix(cloud): cap onboarding survey free-text length

Author: MaanilVerma

src/locales/en/main.json

@@ -3130,7 +3130,8 @@
       "errors": {
         "chooseAnOption": "Please choose an option.",
         "selectAtLeastOne": "Please select at least one option.",
-        "describeAnswer": "Please describe your answer."
+        "describeAnswer": "Please describe your answer.",
+        "answerTooLong": "Please keep your answer under {max} characters."
       },
       "options": {
         "intent": {

src/platform/cloud/onboarding/survey/DynamicSurveyField.vue

@@ -61,6 +61,7 @@
       v-if="field.allowOther && field.otherFieldId && isOtherSelected"
       :model-value="(otherValue as string) ?? ''"
       :class="inputClass"
+      :maxlength="OTHER_TEXT_MAX_LENGTH"
       :placeholder="
         $t(
           `cloudOnboarding.survey.options.${field.id}.otherPlaceholder`,
@@ -103,6 +104,8 @@ import type {
   OnboardingSurveyOption
 } from '@/platform/remoteConfig/types'
 
+import { OTHER_TEXT_MAX_LENGTH } from './surveySchema'
+
 const {
   field,
   modelValue,

src/platform/cloud/onboarding/survey/surveySchema.test.ts

@@ -4,6 +4,7 @@ import type { OnboardingSurvey } from '@/platform/remoteConfig/types'
 
 import { defaultOnboardingSurvey } from './defaultSurveySchema'
 import {
+  OTHER_TEXT_MAX_LENGTH,
   buildInitialValues,
   buildSubmissionPayload,
   buildZodSchema,
@@ -404,4 +405,23 @@ describe('other free-text validation', () => {
       schema.safeParse({ source: 'other', sourceOther: '   ' }).success
     ).toBe(false)
   })
+
+  it('rejects an "other" answer longer than the max length', () => {
+    const schema = buildZodSchema(otherSurvey, {
+      source: 'other',
+      sourceOther: 'x'.repeat(OTHER_TEXT_MAX_LENGTH + 1)
+    })
+    expect(
+      schema.safeParse({
+        source: 'other',
+        sourceOther: 'x'.repeat(OTHER_TEXT_MAX_LENGTH + 1)
+      }).success
+    ).toBe(false)
+    expect(
+      schema.safeParse({
+        source: 'other',
+        sourceOther: 'x'.repeat(OTHER_TEXT_MAX_LENGTH)
+      }).success
+    ).toBe(true)
+  })
 })

src/platform/cloud/onboarding/survey/surveySchema.ts

@@ -9,6 +9,8 @@ import type {
 
 export type SurveyValues = Record<string, string | string[] | undefined>
 
+export const OTHER_TEXT_MAX_LENGTH = 200
+
 export const hasNonEmptyValue = (
   current: string | string[] | undefined
 ): boolean => {
@@ -59,7 +61,7 @@ export const prepareSurvey = (survey: OnboardingSurvey): OnboardingSurvey => ({
   fields: survey.fields.map(randomizeOptions)
 })
 
-type Translator = (key: string) => string
+type Translator = (key: string, named?: Record<string, unknown>) => string
 
 const identityTranslator: Translator = (key) => key
 
@@ -100,6 +102,11 @@ export const buildZodSchema = (
         .min(1, {
           message: t('cloudOnboarding.survey.errors.describeAnswer')
         })
+        .max(OTHER_TEXT_MAX_LENGTH, {
+          message: t('cloudOnboarding.survey.errors.answerTooLong', {
+            max: OTHER_TEXT_MAX_LENGTH
+          })
+        })
     } else if (field.otherFieldId) {
       shape[field.otherFieldId] = z.string().optional()
     }