refactor: rename isActiveSubscription to canAccessSubscriptionFeatures

The name isActiveSubscription was misleading: it's defined as
  !isCloud || !subscription_required || subscription.is_active
so it returns true on non-cloud builds and when subscription is not
required, regardless of actual subscription state. The new name
canAccessSubscriptionFeatures reads correctly at every call site:
'if can access features, show UI / allow action'.

Pure identifier rename, no behavioral changes. Also renames the internal
alias isSubscribedOrIsNotCloud to match.

Author: christian-byrne

src/components/topbar/CurrentUserPopoverLegacy.test.ts

@@ -64,7 +64,7 @@ function makeSubscription(
 
 const mockFetchStatus = vi.fn().mockResolvedValue(undefined)
 const mockFetchBalance = vi.fn().mockResolvedValue(undefined)
-const mockIsActiveSubscription = ref(true)
+const mockCanAccessSubscriptionFeatures = ref(true)
 const mockIsFreeTier = ref(false)
 const mockTier = ref<SubscriptionInfo['tier']>('CREATOR')
 const mockSubscription = ref<SubscriptionInfo | null>(makeSubscription())
@@ -73,7 +73,7 @@ const mockIsLoading = ref(false)
 
 vi.mock('@/composables/billing/useBillingContext', () => ({
   useBillingContext: vi.fn(() => ({
-    isActiveSubscription: mockIsActiveSubscription,
+    canAccessSubscriptionFeatures: mockCanAccessSubscriptionFeatures,
     isFreeTier: mockIsFreeTier,
     tier: mockTier,
     subscription: mockSubscription,
@@ -153,7 +153,7 @@ describe('CurrentUserPopoverLegacy', () => {
   beforeEach(() => {
     vi.clearAllMocks()
     mockIsCloud.value = true
-    mockIsActiveSubscription.value = true
+    mockCanAccessSubscriptionFeatures.value = true
     mockIsFreeTier.value = false
     mockTier.value = 'CREATOR'
     mockSubscription.value = makeSubscription()
@@ -203,7 +203,7 @@ describe('CurrentUserPopoverLegacy', () => {
   })
 
   it('refreshes subscription status through the billing facade after subscribing', async () => {
-    mockIsActiveSubscription.value = false
+    mockCanAccessSubscriptionFeatures.value = false
     const { user } = renderComponent()
 
     await user.click(screen.getByTestId('subscribe-button-mock'))
@@ -478,7 +478,7 @@ describe('CurrentUserPopoverLegacy', () => {
     })
 
     it('hides subscribe button', () => {
-      mockIsActiveSubscription.value = false
+      mockCanAccessSubscriptionFeatures.value = false
       renderComponent()
       expect(
         screen.queryByTestId('subscribe-button-mock')

src/components/topbar/CurrentUserPopoverLegacy.vue

@@ -30,8 +30,11 @@
     </div>
 
     <!-- Credits Section -->
-    <div v-if="isActiveSubscription" class="flex items-center gap-2 px-4 py-2">
-      <i class="icon-[lucide--component] text-sm text-credit" />
+    <div
+      v-if="canAccessSubscriptionFeatures"
+      class="flex items-center gap-2 px-4 py-2"
+    >
+      <i class="icon-[lucide--component] text-sm text-amber-400" />
       <Skeleton v-if="isLoading" width="4rem" height="1.25rem" class="w-full" />
       <span v-else class="text-base font-semibold text-base-foreground">{{
         formattedBalance
@@ -80,7 +83,7 @@
     <Divider class="mx-0 my-2" />
 
     <div
-      v-if="isActiveSubscription"
+      v-if="canAccessSubscriptionFeatures"
       class="flex cursor-pointer items-center gap-2 px-4 py-2 hover:bg-secondary-background-hover"
       data-testid="partner-nodes-menu-item"
       @click="handleOpenPartnerNodesInfo"
@@ -110,7 +113,7 @@
     </div>
 
     <div
-      v-if="isActiveSubscription"
+      v-if="canAccessSubscriptionFeatures"
       class="flex cursor-pointer items-center gap-2 px-4 py-2 hover:bg-secondary-background-hover"
       data-testid="manage-plan-menu-item"
       @click="handleOpenPlanAndCreditsSettings"
@@ -178,7 +181,7 @@ const { userDisplayName, userEmail, userPhotoUrl, handleSignOut } =
 const settingsDialog = useSettingsDialog()
 const dialogService = useDialogService()
 const {
-  isActiveSubscription,
+  canAccessSubscriptionFeatures,
   isFreeTier,
   tier,
   subscription,

src/composables/auth/useAuthActions.test.ts

@@ -81,7 +81,7 @@ vi.mock('@/stores/authStore', () => ({
 
 vi.mock('@/composables/billing/useBillingContext', () => ({
   useBillingContext: vi.fn(() => ({
-    isActiveSubscription: { value: false },
+    canAccessSubscriptionFeatures: { value: false },
     isFreeTier: { value: true },
     type: { value: 'free' }
   }))

src/composables/auth/useAuthActions.ts

@@ -141,8 +141,8 @@ export const useAuthActions = () => {
   )
 
   const purchaseCredits = wrapWithErrorHandlingAsync(async (amount: number) => {
-    const { isActiveSubscription } = useBillingContext()
-    if (!isActiveSubscription.value) return
+    const { canAccessSubscriptionFeatures } = useBillingContext()
+    if (!canAccessSubscriptionFeatures.value) return
 
     const response = await authStore.initiateCreditPurchase({
       amount_micros: usdToMicros(amount),

src/composables/billing/types.ts

@@ -94,7 +94,7 @@ export interface BillingState {
   currentTeamCreditStop: ComputedRef<CurrentTeamCreditStop | null>
   isLoading: Ref<boolean>
   error: Ref<string | null>
-  isActiveSubscription: ComputedRef<boolean>
+  canAccessSubscriptionFeatures: ComputedRef<boolean>
   /** Reflects the active workspace's tier, not the user's personal tier. */
   isFreeTier: ComputedRef<boolean>
   /** Coarse funding state (`billing_status`); legacy reports null. */
@@ -121,4 +121,6 @@ export interface BillingContext extends BillingState, BillingActions {
   isTeamPlan: ComputedRef<boolean>
   getMaxSeats: (tierKey: TierKey) => number
   canRunWorkflows: ComputedRef<boolean>
+  /** @deprecated Use canAccessSubscriptionFeatures instead */
+  isActiveSubscription: ComputedRef<boolean>
 }

src/composables/billing/useBillingContext.test.ts

@@ -96,7 +96,7 @@ vi.mock('@/platform/workspace/stores/teamWorkspaceStore', () => ({
 
 vi.mock('@/platform/cloud/subscription/composables/useSubscription', () => ({
   useSubscription: () => ({
-    isActiveSubscription: { value: true },
+    canAccessSubscriptionFeatures: { value: true },
     subscriptionTier: { value: 'PRO' },
     subscriptionDuration: { value: 'MONTHLY' },
     subscriptionStatus: {
@@ -269,9 +269,9 @@ describe('useBillingContext', () => {
     await expect(topup(99.5)).rejects.toThrow()
   })
 
-  it('provides isActiveSubscription convenience computed', () => {
-    const { isActiveSubscription } = useBillingContext()
-    expect(isActiveSubscription.value).toBe(true)
+  it('provides canAccessSubscriptionFeatures convenience computed', () => {
+    const { canAccessSubscriptionFeatures } = useBillingContext()
+    expect(canAccessSubscriptionFeatures.value).toBe(true)
   })
 
   it('exposes requireActiveSubscription action', async () => {

src/composables/billing/useBillingContext.ts

@@ -124,10 +124,13 @@ function useBillingContextInternal(): BillingContext {
     toValue(activeContext.value.currentTeamCreditStop)
   )
 
-  const isActiveSubscription = computed(() =>
-    toValue(activeContext.value.isActiveSubscription)
+  const canAccessSubscriptionFeatures = computed(() =>
+    toValue(activeContext.value.canAccessSubscriptionFeatures)
   )
 
+  // Alias kept for backward compatibility; equals canAccessSubscriptionFeatures.
+  const isActiveSubscription = canAccessSubscriptionFeatures
+
   const isFreeTier = computed(() => subscription.value?.tier === 'FREE')
 
   const freeTierQuota = useFreeTierQuota()
@@ -143,7 +146,7 @@ function useBillingContextInternal(): BillingContext {
   const isLegacyTeamPlan = computed(
     () =>
       type.value === 'workspace' &&
-      isActiveSubscription.value &&
+      canAccessSubscriptionFeatures.value &&
       !isFreeTier.value &&
       currentTeamCreditStop.value === null &&
       (currentPlanSlug.value
@@ -324,6 +327,7 @@ function useBillingContextInternal(): BillingContext {
     error,
     isActiveSubscription,
     canRunWorkflows,
+    canAccessSubscriptionFeatures,
     isFreeTier,
     isLegacyTeamPlan,
     isTeamPlan,

src/composables/billing/useLegacyBilling.ts

@@ -27,7 +27,7 @@ import type {
  */
 export function useLegacyBilling(): BillingState & BillingActions {
   const {
-    isActiveSubscription: legacyIsActiveSubscription,
+    canAccessSubscriptionFeatures: legacyCanAccessSubscriptionFeatures,
     subscriptionTier,
     subscriptionDuration,
     subscriptionStatus: legacySubscriptionStatus,
@@ -45,16 +45,18 @@ export function useLegacyBilling(): BillingState & BillingActions {
   const isLoading = ref(false)
   const error = ref<string | null>(null)
 
-  const isActiveSubscription = computed(() => legacyIsActiveSubscription.value)
+  const canAccessSubscriptionFeatures = computed(
+    () => legacyCanAccessSubscriptionFeatures.value
+  )
   const isFreeTier = computed(() => subscriptionTier.value === 'FREE')
 
   const subscription = computed<SubscriptionInfo | null>(() => {
-    if (!legacyIsActiveSubscription.value && !subscriptionTier.value) {
+    if (!legacyCanAccessSubscriptionFeatures.value && !subscriptionTier.value) {
       return null
     }
 
     return {
-      isActive: legacyIsActiveSubscription.value,
+      isActive: legacyCanAccessSubscriptionFeatures.value,
       tier: subscriptionTier.value,
       duration: subscriptionDuration.value,
       planSlug: null, // Legacy doesn't use plan slugs
@@ -85,7 +87,7 @@ export function useLegacyBilling(): BillingState & BillingActions {
   const billingStatus = computed<BillingStatus | null>(() => null)
   const subscriptionStatus = computed<BillingSubscriptionStatus | null>(() => {
     if (isCancelled.value) return 'canceled'
-    if (legacyIsActiveSubscription.value) return 'active'
+    if (legacyCanAccessSubscriptionFeatures.value) return 'active'
     return null
   })
   const tier = computed(() => subscriptionTier.value)
@@ -189,8 +191,8 @@ export function useLegacyBilling(): BillingState & BillingActions {
 
   async function requireActiveSubscription(): Promise<void> {
     await fetchStatus()
-    if (!isActiveSubscription.value) {
-      legacyShowSubscriptionDialog({ reason: 'subscription_required' })
+    if (!canAccessSubscriptionFeatures.value) {
+      legacyShowSubscriptionDialog()
     }
   }
 
@@ -209,7 +211,7 @@ export function useLegacyBilling(): BillingState & BillingActions {
     currentTeamCreditStop,
     isLoading,
     error,
-    isActiveSubscription,
+    canAccessSubscriptionFeatures,
     isFreeTier,
     billingStatus,
     subscriptionStatus,

src/composables/useCoreCommands.test.ts

@@ -190,14 +190,14 @@ vi.mock('@/composables/auth/useAuthActions', () => ({
 
 vi.mock('@/platform/cloud/subscription/composables/useSubscription', () => ({
   useSubscription: vi.fn(() => ({
-    isActiveSubscription: vi.fn().mockReturnValue(true),
+    canAccessSubscriptionFeatures: vi.fn().mockReturnValue(true),
     showSubscriptionDialog: vi.fn()
   }))
 }))
 
 vi.mock('@/composables/billing/useBillingContext', () => ({
   useBillingContext: vi.fn(() => ({
-    isActiveSubscription: { value: true },
+    canAccessSubscriptionFeatures: { value: true },
     showSubscriptionDialog: vi.fn()
   }))
 }))

src/composables/useCoreCommands.ts

@@ -74,7 +74,8 @@ import { useDialogStore } from '@/stores/dialogStore'
 
 const moveSelectedNodesVersionAdded = '1.22.2'
 export function useCoreCommands(): ComfyCommand[] {
-  const { isActiveSubscription, showSubscriptionDialog } = useBillingContext()
+  const { canAccessSubscriptionFeatures, showSubscriptionDialog } =
+    useBillingContext()
   const workflowService = useWorkflowService()
   const workflowStore = useWorkflowStore()
   const settingsDialog = useSettingsDialog()
@@ -502,8 +503,8 @@ export function useCoreCommands(): ComfyCommand[] {
         trigger_source?: ExecutionTriggerSource
       }) => {
         trackRunButton(metadata)
-        if (!isActiveSubscription.value) {
-          showSubscriptionDialog({ reason: 'subscribe_to_run' })
+        if (!canAccessSubscriptionFeatures.value) {
+          showSubscriptionDialog()
           return
         }
 
@@ -525,8 +526,8 @@ export function useCoreCommands(): ComfyCommand[] {
         trigger_source?: ExecutionTriggerSource
       }) => {
         trackRunButton(metadata)
-        if (!isActiveSubscription.value) {
-          showSubscriptionDialog({ reason: 'subscribe_to_run' })
+        if (!canAccessSubscriptionFeatures.value) {
+          showSubscriptionDialog()
           return
         }
 
@@ -547,8 +548,8 @@ export function useCoreCommands(): ComfyCommand[] {
         trigger_source?: ExecutionTriggerSource
       }) => {
         trackRunButton(metadata)
-        if (!isActiveSubscription.value) {
-          showSubscriptionDialog({ reason: 'subscribe_to_run' })
+        if (!canAccessSubscriptionFeatures.value) {
+          showSubscriptionDialog()
           return
         }