test: cover queue models and execution-store slices#13336
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1691 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 7.77 MB gzip 🟢 -148 BDetailsSummary
Category Glance App Entry Points — 47.4 kB (baseline 47.4 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.25 MB (baseline 1.25 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 97.7 kB (baseline 97.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 3 unchanged Panels & Settings — 546 kB (baseline 546 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 26.9 kB (baseline 26.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 117 kB (baseline 117 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed / 1 unchanged UI Components — 57.2 kB (baseline 57.2 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 270 kB (baseline 270 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 3.37 MB (baseline 3.37 MB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 17 unchanged Vendor & Third-Party — 15.3 MB (baseline 15.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 11.7 MB (baseline 11.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 66 added / 66 removed / 99 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-01T05:57:32.898Z",
"gitSha": "bc54d1c6e5a74688481c1ad7bb81d4dbc3edf202",
"branch": "shihchi/coverage-queue-execution-slices",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2030.968999999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.921000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.27700000000004,
"heapDeltaBytes": -8016448,
"heapUsedBytes": 61236020,
"domNodes": -276,
"jsHeapTotalBytes": 20344832,
"scriptDurationMs": 16.612,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2040.4670000000351,
"styleRecalcs": 10,
"styleRecalcDurationMs": 12.831999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.24600000000004,
"heapDeltaBytes": -7229968,
"heapUsedBytes": 62267728,
"domNodes": -275,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 14.206999999999999,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.4550000000204,
"styleRecalcs": 72,
"styleRecalcDurationMs": 33.442,
"layouts": 12,
"layoutDurationMs": 3.025,
"taskDurationMs": 715.415,
"heapDeltaBytes": -12646748,
"heapUsedBytes": 56798608,
"domNodes": -242,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 98.301,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1750.586999999996,
"styleRecalcs": 71,
"styleRecalcDurationMs": 33.782,
"layouts": 12,
"layoutDurationMs": 2.8719999999999994,
"taskDurationMs": 641.624,
"heapDeltaBytes": -12611428,
"heapUsedBytes": 56808876,
"domNodes": -245,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 89.61099999999999,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.1600000000212,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.407,
"layouts": 6,
"layoutDurationMs": 0.514,
"taskDurationMs": 295.228,
"heapDeltaBytes": 699216,
"heapUsedBytes": 52665164,
"domNodes": -238,
"jsHeapTotalBytes": 7204864,
"scriptDurationMs": 24.338,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.4650000000188,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.92,
"layouts": 6,
"layoutDurationMs": 0.61,
"taskDurationMs": 274.522,
"heapDeltaBytes": 6278028,
"heapUsedBytes": 58855704,
"domNodes": -239,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 15.211,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 510.3350000000546,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.959999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 288.133,
"heapDeltaBytes": 7428648,
"heapUsedBytes": 66559044,
"domNodes": 20,
"jsHeapTotalBytes": 19398656,
"scriptDurationMs": 46.11,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 446.44999999997026,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.436,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 266.959,
"heapDeltaBytes": 5835460,
"heapUsedBytes": 58105248,
"domNodes": 22,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 47.97,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2054.826999999989,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.900999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.735,
"heapDeltaBytes": -265160,
"heapUsedBytes": 59214232,
"domNodes": -274,
"jsHeapTotalBytes": -557056,
"scriptDurationMs": 98.968,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 1990.238999999974,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.5729999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.12499999999994,
"heapDeltaBytes": -9666516,
"heapUsedBytes": 62157912,
"domNodes": 22,
"jsHeapTotalBytes": 9842688,
"scriptDurationMs": 68.645,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2067.420000000027,
"styleRecalcs": 70,
"styleRecalcDurationMs": 18.326999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 937.1320000000001,
"heapDeltaBytes": 29038128,
"heapUsedBytes": 82670200,
"domNodes": -264,
"jsHeapTotalBytes": 466944,
"scriptDurationMs": 347.21599999999995,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2044.854999999984,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.064000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 820.184,
"heapDeltaBytes": 27488296,
"heapUsedBytes": 81100408,
"domNodes": -262,
"jsHeapTotalBytes": 204800,
"scriptDurationMs": 303.838,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3079.1110000000117,
"styleRecalcs": 65,
"styleRecalcDurationMs": 17.017,
"layouts": 60,
"layoutDurationMs": 7.3629999999999995,
"taskDurationMs": 1070.0620000000001,
"heapDeltaBytes": 13893744,
"heapUsedBytes": 69728112,
"domNodes": 12,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 400.226,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3052.024999999958,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.443999999999996,
"layouts": 60,
"layoutDurationMs": 7.116,
"taskDurationMs": 1014.9819999999999,
"heapDeltaBytes": 11936000,
"heapUsedBytes": 66604924,
"domNodes": 10,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 385.71500000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2003.0590000000075,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.723999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.88899999999995,
"heapDeltaBytes": 51155372,
"heapUsedBytes": 105608588,
"domNodes": 14,
"jsHeapTotalBytes": 36438016,
"scriptDurationMs": 65.84899999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2008.2929999999806,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.407000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.181,
"heapDeltaBytes": -3352704,
"heapUsedBytes": 58255556,
"domNodes": -272,
"jsHeapTotalBytes": -1081344,
"scriptDurationMs": 63.654,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 484.3050000000062,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.768,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.601,
"heapDeltaBytes": -22940900,
"heapUsedBytes": 46376356,
"domNodes": -275,
"jsHeapTotalBytes": 5926912,
"scriptDurationMs": 96.221,
"eventListeners": -193,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 493.30299999996896,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.879999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.59599999999995,
"heapDeltaBytes": -12151276,
"heapUsedBytes": 52842728,
"domNodes": 22,
"jsHeapTotalBytes": 22577152,
"scriptDurationMs": 96.092,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2114.1680000000065,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.221999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 854.3539999999999,
"heapDeltaBytes": -8255368,
"heapUsedBytes": 61220004,
"domNodes": -285,
"jsHeapTotalBytes": 20082688,
"scriptDurationMs": 40.013,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.7019999999757,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.1160000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 279.886,
"heapDeltaBytes": -1826368,
"heapUsedBytes": 56962372,
"domNodes": 22,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 10.804999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.5160000000183,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.003,
"layouts": 16,
"layoutDurationMs": 4.307,
"taskDurationMs": 645.625,
"heapDeltaBytes": -17045804,
"heapUsedBytes": 52423100,
"domNodes": -235,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 84.74400000000001,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.4569999999962,
"styleRecalcs": 76,
"styleRecalcDurationMs": 29.29,
"layouts": 16,
"layoutDurationMs": 3.5140000000000002,
"taskDurationMs": 568.765,
"heapDeltaBytes": 18474420,
"heapUsedBytes": 70804012,
"domNodes": -248,
"jsHeapTotalBytes": 14807040,
"scriptDurationMs": 73.395,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 848.5600000000204,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.712999999999997,
"layouts": 6,
"layoutDurationMs": 9.742999999999999,
"taskDurationMs": 574.9439999999998,
"heapDeltaBytes": 29981324,
"heapUsedBytes": 102150600,
"domNodes": 13833,
"jsHeapTotalBytes": 17039360,
"scriptDurationMs": 21.235999999999997,
"eventListeners": 2531,
"totalBlockingTimeMs": 111,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8075.076000000025,
"styleRecalcs": 250,
"styleRecalcDurationMs": 54.66799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2998.38,
"heapDeltaBytes": -1728752,
"heapUsedBytes": 70212420,
"domNodes": 22,
"jsHeapTotalBytes": 17883136,
"scriptDurationMs": 972.411,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8132.637000000045,
"styleRecalcs": 251,
"styleRecalcDurationMs": 52.68,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2961.643,
"heapDeltaBytes": -15914836,
"heapUsedBytes": 68242316,
"domNodes": -271,
"jsHeapTotalBytes": 5795840,
"scriptDurationMs": 978.899,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11255.032000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11242.786,
"heapDeltaBytes": 4198104,
"heapUsedBytes": 186576524,
"domNodes": -3331,
"jsHeapTotalBytes": 20680704,
"scriptDurationMs": 425.349,
"eventListeners": -16374,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10690.517,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10681.706999999999,
"heapDeltaBytes": -29542456,
"heapUsedBytes": 169404320,
"domNodes": -3300,
"jsHeapTotalBytes": 19660800,
"scriptDurationMs": 413.22300000000007,
"eventListeners": -16369,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 12166.821999999967,
"styleRecalcs": 64,
"styleRecalcDurationMs": 17.02400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12154.596,
"heapDeltaBytes": -22239424,
"heapUsedBytes": 172351680,
"domNodes": -3302,
"jsHeapTotalBytes": 24088576,
"scriptDurationMs": 679.667,
"eventListeners": -16372,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13023.711000000048,
"styleRecalcs": 65,
"styleRecalcDurationMs": 18.162000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13006.551,
"heapDeltaBytes": -23484696,
"heapUsedBytes": 184466660,
"domNodes": -3300,
"jsHeapTotalBytes": -1163264,
"scriptDurationMs": 685.08,
"eventListeners": -16376,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 460.0149999999985,
"styleRecalcs": 21,
"styleRecalcDurationMs": 25.537,
"layouts": 6,
"layoutDurationMs": 1.476,
"taskDurationMs": 118.73200000000001,
"heapDeltaBytes": 5475644,
"heapUsedBytes": 65353628,
"domNodes": 172,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 15.548000000000002,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 438.6060000000498,
"styleRecalcs": 17,
"styleRecalcDurationMs": 17.156000000000002,
"layouts": 4,
"layoutDurationMs": 0.987,
"taskDurationMs": 84.355,
"heapDeltaBytes": 4947136,
"heapUsedBytes": 58153116,
"domNodes": 157,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.525,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
🌐 Website E2ENote Tests are running… View workflow run 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-13336.vercel.app This commit: https://website-frontend-r6pjkfzb0-comfyui.vercel.app Last updated: 2026-07-01T05:36:51Z for |
34ec250 to
392b1a0
Compare
392b1a0 to
9d67c50
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #13336 +/- ##
==========================================
+ Coverage 77.08% 77.14% +0.05%
==========================================
Files 1636 1636
Lines 98282 98282
Branches 33120 33765 +645
==========================================
+ Hits 75763 75818 +55
+ Misses 21810 21757 -53
+ Partials 709 707 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Add unit branch-coverage for queue/result data models and execution-store state slices. Part of the overall-coverage track of the test-coverage initiative.
Changes
src/stores/queueResultItem.test.ts,src/stores/queueTaskItem.test.ts,src/stores/resultItemParsing.test.ts,src/stores/executionErrorStore.test.ts,src/stores/executionInterrupt.test.ts,src/stores/executionLifecycle.test.ts,src/stores/executionNodeProgress.test.ts,src/stores/executionRunningState.test.ts,src/stores/executionWorkflowStatus.test.ts. Test-only — no source changes.Review Focus
These target files outside the 27-file critical allow-list, so they do not move
pnpm test:coverage:critical— they raise overall project coverage. The exact coverage delta is reported automatically by the codecov bot on this PR. All tests verified green onmain.