refactor: tidy executionStore job-state handling#13347
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1691 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 7.77 MB gzip 🟢 -101 BDetailsSummary
Category Glance App Entry Points — 47.4 kB (baseline 47.4 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.25 MB (baseline 1.25 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 97.7 kB (baseline 97.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 3 unchanged Panels & Settings — 546 kB (baseline 546 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 26.9 kB (baseline 26.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 117 kB (baseline 117 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed / 1 unchanged UI Components — 57.2 kB (baseline 57.2 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 270 kB (baseline 270 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 3.37 MB (baseline 3.37 MB) • 🟢 -221 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 17 unchanged Vendor & Third-Party — 15.3 MB (baseline 15.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 11.7 MB (baseline 11.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 66 added / 66 removed / 99 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-01T05:49:10.644Z",
"gitSha": "71042663ec5c261c684c5033e12bb16af4cadf1a",
"branch": "shihchi/refactor-execution-store",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.37,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.269,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.862,
"heapDeltaBytes": -1421924,
"heapUsedBytes": 57392616,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 15.171000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2015.781000000004,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.632999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.897,
"heapDeltaBytes": -1088216,
"heapUsedBytes": 51553944,
"domNodes": -292,
"jsHeapTotalBytes": 19525632,
"scriptDurationMs": 22.032,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1889.2480000000091,
"styleRecalcs": 73,
"styleRecalcDurationMs": 44.744,
"layouts": 12,
"layoutDurationMs": 3.577,
"taskDurationMs": 901.2180000000001,
"heapDeltaBytes": -12544968,
"heapUsedBytes": 56782224,
"domNodes": -237,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 130.766,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1790.3799999999706,
"styleRecalcs": 73,
"styleRecalcDurationMs": 36.712,
"layouts": 12,
"layoutDurationMs": 3.522,
"taskDurationMs": 771.475,
"heapDeltaBytes": -6692036,
"heapUsedBytes": 52099604,
"domNodes": 55,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 119.88499999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.276999999986,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.228,
"layouts": 6,
"layoutDurationMs": 0.5710000000000001,
"taskDurationMs": 288.173,
"heapDeltaBytes": 2254324,
"heapUsedBytes": 61060056,
"domNodes": 76,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 17.314999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.0329999999494,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.824,
"layouts": 6,
"layoutDurationMs": 0.639,
"taskDurationMs": 384.313,
"heapDeltaBytes": -3615992,
"heapUsedBytes": 65699376,
"domNodes": -228,
"jsHeapTotalBytes": 13004800,
"scriptDurationMs": 22.491999999999997,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 564.8680000000184,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.127000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.174,
"heapDeltaBytes": 14283620,
"heapUsedBytes": 67130716,
"domNodes": -291,
"jsHeapTotalBytes": 1961984,
"scriptDurationMs": 51.45799999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 563.9380000000074,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.635000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.963,
"heapDeltaBytes": 7160432,
"heapUsedBytes": 65951428,
"domNodes": 20,
"jsHeapTotalBytes": 19136512,
"scriptDurationMs": 54.416,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 1998.404999999991,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.630000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.68,
"heapDeltaBytes": 10192576,
"heapUsedBytes": 68744536,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 73.257,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2002.161000000001,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.238999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.07300000000004,
"heapDeltaBytes": -9576500,
"heapUsedBytes": 61980828,
"domNodes": 24,
"jsHeapTotalBytes": 9580544,
"scriptDurationMs": 75.95599999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2098.98400000003,
"styleRecalcs": 67,
"styleRecalcDurationMs": 16.736,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1099.2150000000001,
"heapDeltaBytes": 23007596,
"heapUsedBytes": 84195880,
"domNodes": -283,
"jsHeapTotalBytes": -90112,
"scriptDurationMs": 429.8,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2113.433999999984,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.924000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1002.001,
"heapDeltaBytes": -3810472,
"heapUsedBytes": 81861184,
"domNodes": -276,
"jsHeapTotalBytes": 1863680,
"scriptDurationMs": 352.819,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3076.3640000000123,
"styleRecalcs": 63,
"styleRecalcDurationMs": 16.859999999999996,
"layouts": 60,
"layoutDurationMs": 8.264000000000001,
"taskDurationMs": 1259.401,
"heapDeltaBytes": 11870328,
"heapUsedBytes": 67469864,
"domNodes": 8,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 480.716,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3061.842000000013,
"styleRecalcs": 63,
"styleRecalcDurationMs": 16.502999999999997,
"layouts": 60,
"layoutDurationMs": 7.837000000000001,
"taskDurationMs": 1221.143,
"heapDeltaBytes": 11874012,
"heapUsedBytes": 66254020,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 463.84999999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2020.6320000000346,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.624,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.88500000000005,
"heapDeltaBytes": -3237712,
"heapUsedBytes": 58685168,
"domNodes": -276,
"jsHeapTotalBytes": -1605632,
"scriptDurationMs": 80.39299999999999,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1998.4440000000632,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.204000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.698,
"heapDeltaBytes": 6259456,
"heapUsedBytes": 60863804,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 97.702,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.5279999999998,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.278,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.825,
"heapDeltaBytes": 7739776,
"heapUsedBytes": 66840616,
"domNodes": 20,
"jsHeapTotalBytes": 19660800,
"scriptDurationMs": 120.38,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.1530000000153,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.524999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.473,
"heapDeltaBytes": -12143112,
"heapUsedBytes": 53908616,
"domNodes": 20,
"jsHeapTotalBytes": 21266432,
"scriptDurationMs": 127.65300000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2041.2369999999953,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.834000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.39200000000005,
"heapDeltaBytes": -7945788,
"heapUsedBytes": 61558940,
"domNodes": -276,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 14.117,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2037.4570000000176,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.511,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.34000000000003,
"heapDeltaBytes": 12770248,
"heapUsedBytes": 65150284,
"domNodes": -261,
"jsHeapTotalBytes": 16642048,
"scriptDurationMs": 12.603,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1715.845999999999,
"styleRecalcs": 74,
"styleRecalcDurationMs": 35.432,
"layouts": 16,
"layoutDurationMs": 4.234,
"taskDurationMs": 672.3900000000001,
"heapDeltaBytes": 18125288,
"heapUsedBytes": 70696756,
"domNodes": -253,
"jsHeapTotalBytes": 15855616,
"scriptDurationMs": 84.762,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1747.669999999971,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.367000000000004,
"layouts": 16,
"layoutDurationMs": 4.526000000000001,
"taskDurationMs": 681.539,
"heapDeltaBytes": 19048916,
"heapUsedBytes": 70927684,
"domNodes": -252,
"jsHeapTotalBytes": 15069184,
"scriptDurationMs": 85.819,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 933.3780000000047,
"styleRecalcs": 15,
"styleRecalcDurationMs": 27.28099999999999,
"layouts": 4,
"layoutDurationMs": 11.493,
"taskDurationMs": 754.0120000000002,
"heapDeltaBytes": 4415352,
"heapUsedBytes": 80500352,
"domNodes": 13833,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 27.767999999999986,
"eventListeners": 2531,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8131.812000000025,
"styleRecalcs": 250,
"styleRecalcDurationMs": 57.716,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3531.71,
"heapDeltaBytes": -1485772,
"heapUsedBytes": 70500828,
"domNodes": 18,
"jsHeapTotalBytes": 16310272,
"scriptDurationMs": 1143.037,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8156.274999999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 59.038000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3725.408,
"heapDeltaBytes": 9061360,
"heapUsedBytes": 68876488,
"domNodes": -274,
"jsHeapTotalBytes": 696320,
"scriptDurationMs": 1174.932,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13176.246999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13151.866000000002,
"heapDeltaBytes": -28389192,
"heapUsedBytes": 173297748,
"domNodes": -3300,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 513.058,
"eventListeners": -16372,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12922.780999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12908.707,
"heapDeltaBytes": -59305080,
"heapUsedBytes": 167051228,
"domNodes": -3300,
"jsHeapTotalBytes": -5505024,
"scriptDurationMs": 587.8650000000001,
"eventListeners": -16378,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15477.580000000045,
"styleRecalcs": 77,
"styleRecalcDurationMs": 20.497999999999962,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15457.379,
"heapDeltaBytes": -36628848,
"heapUsedBytes": 155198548,
"domNodes": -3302,
"jsHeapTotalBytes": 15962112,
"scriptDurationMs": 774.7539999999999,
"eventListeners": -16372,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14796.289,
"styleRecalcs": 69,
"styleRecalcDurationMs": 19.00099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14776.211,
"heapDeltaBytes": -54764384,
"heapUsedBytes": 156318256,
"domNodes": -3300,
"jsHeapTotalBytes": 17825792,
"scriptDurationMs": 794.2810000000001,
"eventListeners": -16366,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 475.812000000019,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.874999999999996,
"layouts": 4,
"layoutDurationMs": 1.4590000000000003,
"taskDurationMs": 230.306,
"heapDeltaBytes": -21937468,
"heapUsedBytes": 48713756,
"domNodes": -165,
"jsHeapTotalBytes": 4616192,
"scriptDurationMs": 22.85,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 512.0090000000346,
"styleRecalcs": 16,
"styleRecalcDurationMs": 35.64000000000001,
"layouts": 5,
"layoutDurationMs": 1.4160000000000001,
"taskDurationMs": 178.763,
"heapDeltaBytes": -3218244,
"heapUsedBytes": 50343440,
"domNodes": -142,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 17.975,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
🌐 Website E2ETip All tests passed.
|
d18a234 to
9d4cc41
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #13347 +/- ##
========================================
Coverage 77.08% 77.09%
========================================
Files 1636 1636
Lines 98282 98274 -8
Branches 33120 33750 +630
========================================
+ Hits 75763 75764 +1
+ Misses 21810 21803 -7
+ Partials 709 707 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Tidy
executionStorejob-state handling and ship the broaderexecutionStoretest suite that pins the new behavior. Refactor series (separated from the coverage tests for isolated review).Changes
classifyCloudValidationErrornow receivesexception_message ?? '', so an error event without a message no longer throws.resetExecutionStatetakes an explicitjobIdinstead of falling back toactiveJobId.activeJoblookup and the stale-entry eviction loops are simplified (casts replace unreachableundefinedguards).executionStore.test.ts, which depends on the?? ''guard (it fires an error event with no message).resetExecutionStatedirectly would need to pass ajobId, but it is not part of the store's public surface.Review Focus
executionStoreis on the critical allow-list. With this suite, the gate's branch coverage rises 47.62% → 51.34% (marginal over the pre-existing tests, plus the refactor removes a few unreachable branches). All 8 execution suites (192 tests) pass against this source.