refactor: simplify subgraph viewport save branching#13350
Closed
huang47 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1687 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 7.77 MB gzip 🟢 -115 BDetailsSummary
Category Glance App Entry Points — 47.4 kB (baseline 47.4 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.25 MB (baseline 1.25 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 97.7 kB (baseline 97.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 3 unchanged Panels & Settings — 546 kB (baseline 546 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 26.9 kB (baseline 26.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 117 kB (baseline 117 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed / 1 unchanged UI Components — 57.2 kB (baseline 57.2 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 270 kB (baseline 270 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 3.37 MB (baseline 3.37 MB) • 🟢 -28 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 17 unchanged Vendor & Third-Party — 15.3 MB (baseline 15.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 11.7 MB (baseline 11.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 66 added / 66 removed / 99 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-01T05:51:57.966Z",
"gitSha": "acc22c03617c1dfc16c5bf754ef79e63b68205a5",
"branch": "shihchi/refactor-subgraph-nav-canvas-guard",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.7780000000448,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.764999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.57300000000004,
"heapDeltaBytes": 1101508,
"heapUsedBytes": 58780552,
"domNodes": 16,
"jsHeapTotalBytes": 18350080,
"scriptDurationMs": 14.596000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2088.9809999999898,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.722999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.47600000000006,
"heapDeltaBytes": -7625376,
"heapUsedBytes": 62003112,
"domNodes": -280,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 16.229,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1886.4639999999895,
"styleRecalcs": 69,
"styleRecalcDurationMs": 34.913,
"layouts": 12,
"layoutDurationMs": 3.575,
"taskDurationMs": 825.914,
"heapDeltaBytes": 15263400,
"heapUsedBytes": 60318072,
"domNodes": -234,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 122.37299999999998,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.0379999999968,
"styleRecalcs": 74,
"styleRecalcDurationMs": 34.182,
"layouts": 12,
"layoutDurationMs": 3.307,
"taskDurationMs": 781.5500000000001,
"heapDeltaBytes": -13204560,
"heapUsedBytes": 56263440,
"domNodes": -245,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 120.78999999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.6569999999697,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.401,
"layouts": 6,
"layoutDurationMs": 0.5870000000000001,
"taskDurationMs": 293.631,
"heapDeltaBytes": 6877248,
"heapUsedBytes": 68885140,
"domNodes": 76,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 16.644999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.6290000000836,
"styleRecalcs": 33,
"styleRecalcDurationMs": 19.515000000000004,
"layouts": 6,
"layoutDurationMs": 0.6219999999999999,
"taskDurationMs": 401.44199999999995,
"heapDeltaBytes": 5424128,
"heapUsedBytes": 57322904,
"domNodes": -239,
"jsHeapTotalBytes": 1699840,
"scriptDurationMs": 26.084999999999997,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 574.3870000000015,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.588999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.361,
"heapDeltaBytes": -1787376,
"heapUsedBytes": 50127068,
"domNodes": -273,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 53.75000000000001,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 583.1079999999247,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.715,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.751,
"heapDeltaBytes": -4703748,
"heapUsedBytes": 47206204,
"domNodes": -276,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 58.268,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2036.7739999999799,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.494000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.01000000000005,
"heapDeltaBytes": -24443884,
"heapUsedBytes": 59559844,
"domNodes": -263,
"jsHeapTotalBytes": 2445312,
"scriptDurationMs": 83.172,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2053.4300000000485,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.692000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.7800000000001,
"heapDeltaBytes": -1205712,
"heapUsedBytes": 58859692,
"domNodes": -277,
"jsHeapTotalBytes": -1081344,
"scriptDurationMs": 102.17800000000003,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2112.0500000000106,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.272,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1102.7169999999999,
"heapDeltaBytes": 21862508,
"heapUsedBytes": 82828476,
"domNodes": -280,
"jsHeapTotalBytes": -90112,
"scriptDurationMs": 432.558,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2134.7240000000056,
"styleRecalcs": 69,
"styleRecalcDurationMs": 20.731,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1126.586,
"heapDeltaBytes": -2983056,
"heapUsedBytes": 82019448,
"domNodes": -266,
"jsHeapTotalBytes": 2125824,
"scriptDurationMs": 399.147,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3117.1249999999873,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.822,
"layouts": 60,
"layoutDurationMs": 6.995,
"taskDurationMs": 1273.516,
"heapDeltaBytes": -3518652,
"heapUsedBytes": 58694368,
"domNodes": -269,
"jsHeapTotalBytes": 3432448,
"scriptDurationMs": 463.675,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3084.7820000000183,
"styleRecalcs": 61,
"styleRecalcDurationMs": 14.73,
"layouts": 60,
"layoutDurationMs": 7.716999999999999,
"taskDurationMs": 1304.5430000000001,
"heapDeltaBytes": 13399212,
"heapUsedBytes": 68334728,
"domNodes": 2,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 488.92999999999995,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1996.9609999999989,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.6240000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.4889999999999,
"heapDeltaBytes": 7421324,
"heapUsedBytes": 61276796,
"domNodes": -267,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 85.04800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2000.646999999958,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.837999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.256,
"heapDeltaBytes": -10623392,
"heapUsedBytes": 66387476,
"domNodes": 18,
"jsHeapTotalBytes": 7745536,
"scriptDurationMs": 104.27700000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 586.3270000000398,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.941,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.342,
"heapDeltaBytes": 6167500,
"heapUsedBytes": 58303300,
"domNodes": -291,
"jsHeapTotalBytes": 10350592,
"scriptDurationMs": 122.12299999999999,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.8409999999558,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.522,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.87299999999993,
"heapDeltaBytes": -1376056,
"heapUsedBytes": 50655468,
"domNodes": -272,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 128.901,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2031.7610000000172,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.645,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.94399999999996,
"heapDeltaBytes": -8274540,
"heapUsedBytes": 61180616,
"domNodes": -277,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 13.356,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2014.0380000000278,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.376,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.171,
"heapDeltaBytes": 3865660,
"heapUsedBytes": 67204804,
"domNodes": 24,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 12.824,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.2019999999957,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.077999999999996,
"layouts": 16,
"layoutDurationMs": 3.8520000000000003,
"taskDurationMs": 663.7030000000001,
"heapDeltaBytes": -10476816,
"heapUsedBytes": 48363300,
"domNodes": 64,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 87.378,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1764.6270000000186,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.094,
"layouts": 16,
"layoutDurationMs": 4.411999999999999,
"taskDurationMs": 735.087,
"heapDeltaBytes": -16897592,
"heapUsedBytes": 52451012,
"domNodes": -233,
"jsHeapTotalBytes": 20082688,
"scriptDurationMs": 89.91099999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 931.9979999999646,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.423,
"layouts": 4,
"layoutDurationMs": 14.157,
"taskDurationMs": 694.132,
"heapDeltaBytes": 29959580,
"heapUsedBytes": 101884552,
"domNodes": 13833,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 26.801000000000005,
"eventListeners": 2531,
"totalBlockingTimeMs": 159,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8178.385000000048,
"styleRecalcs": 251,
"styleRecalcDurationMs": 53.907,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3575.7120000000004,
"heapDeltaBytes": -15719968,
"heapUsedBytes": 68626668,
"domNodes": -269,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 1221.7610000000002,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8232.913000000053,
"styleRecalcs": 250,
"styleRecalcDurationMs": 57.278,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4134.580000000001,
"heapDeltaBytes": -562308,
"heapUsedBytes": 71128444,
"domNodes": 18,
"jsHeapTotalBytes": 17358848,
"scriptDurationMs": 1354.4180000000001,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11616.385999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11600.637000000002,
"heapDeltaBytes": -45842024,
"heapUsedBytes": 166308180,
"domNodes": -3300,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 485.81600000000003,
"eventListeners": -16366,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12966.613000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12945.070999999998,
"heapDeltaBytes": -26652604,
"heapUsedBytes": 167654288,
"domNodes": -3300,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 609.7600000000001,
"eventListeners": -16366,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14221.71800000001,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.706,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14198.815000000002,
"heapDeltaBytes": -41371508,
"heapUsedBytes": 158013860,
"domNodes": -8328,
"jsHeapTotalBytes": 16510976,
"scriptDurationMs": 809.485,
"eventListeners": -16372,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14980.837000000065,
"styleRecalcs": 71,
"styleRecalcDurationMs": 21.322000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14954.185,
"heapDeltaBytes": -35904880,
"heapUsedBytes": 171222256,
"domNodes": -8328,
"jsHeapTotalBytes": 22802432,
"scriptDurationMs": 838.177,
"eventListeners": -16370,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 450.9900000000471,
"styleRecalcs": 15,
"styleRecalcDurationMs": 22.934000000000005,
"layouts": 5,
"layoutDurationMs": 1.314,
"taskDurationMs": 199.78099999999998,
"heapDeltaBytes": -21876832,
"heapUsedBytes": 48650676,
"domNodes": -164,
"jsHeapTotalBytes": 4878336,
"scriptDurationMs": 17.502999999999997,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 478.0230000000074,
"styleRecalcs": 16,
"styleRecalcDurationMs": 25.482,
"layouts": 4,
"layoutDurationMs": 1.011,
"taskDurationMs": 206.59699999999998,
"heapDeltaBytes": -22158180,
"heapUsedBytes": 48445928,
"domNodes": -180,
"jsHeapTotalBytes": 4878336,
"scriptDurationMs": 19.902,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
🌐 Website E2ETip All tests passed.
|
huang47
force-pushed
the
shihchi/refactor-subgraph-nav-canvas-guard
branch
from
7452aa3 to
d8d85a3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #13350 +/- ##
==========================================
- Coverage 77.08% 77.08% -0.01%
==========================================
Files 1636 1636
Lines 98282 98281 -1
Branches 33120 33117 -3
==========================================
- Hits 75763 75761 -2
- Misses 21810 21812 +2
+ Partials 709 708 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes in
subgraphNavigationStore: (1) split the prev/next viewport-saveelse ifinto independentifs (equivalent), and (2) remove theif (!canvas) returnguard inapplyViewport().Changes
Review Focus
applyViewport()previously bailed out whenapp.canvaswas null. With the guard removed, it dereferencescanvas.dsunconditionally. ThesubgraphNavigationStoresuites (45 tests) pass, but none exercises the null-canvas path, so the tests do not prove this is safe — ifapp.canvasis ever null at runtime (e.g. during teardown / workflow switch), this now throws.There's no functional gain from removing it; it was only removed to delete an "uncovered" branch. My recommendation: keep the
if (!canvas) returnguard and ship only the branching split. Happy to push that version if you agree.