chore: route CodeRabbit test reviews through guidance docs#13486
Open
huang47 wants to merge 4 commits into
Open
chore: route CodeRabbit test reviews through guidance docs#13486huang47 wants to merge 4 commits into
huang47 wants to merge 4 commits into
Conversation
🎭 Playwright: ❌ 1690 passed, 1 failed · 2 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle: 7.78 MB gzip 🔴 +11 BDetailsSummary
Category Glance App Entry Points — 47.8 kB (baseline 47.8 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.27 MB (baseline 1.27 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 98 kB (baseline 98 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 3 unchanged Panels & Settings — 546 kB (baseline 546 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 117 kB (baseline 117 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed / 1 unchanged UI Components — 57.5 kB (baseline 57.5 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 270 kB (baseline 270 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 3.38 MB (baseline 3.38 MB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 17 unchanged Vendor & Third-Party — 15.3 MB (baseline 15.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 11.7 MB (baseline 11.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 67 added / 67 removed / 98 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-08T19:35:38.396Z",
"gitSha": "415d2edefc3c2031c6c53024512c76548427f7e6",
"branch": "codex/coderabbit-test-quality-path-instructions",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.332999999966,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.832999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.274,
"heapDeltaBytes": -1410548,
"heapUsedBytes": 57395340,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 16.779,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2042.7320000000009,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.737000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.53099999999995,
"heapDeltaBytes": -3505448,
"heapUsedBytes": 48557308,
"domNodes": -291,
"jsHeapTotalBytes": 16117760,
"scriptDurationMs": 14.832,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1974.9380000000087,
"styleRecalcs": 80,
"styleRecalcDurationMs": 44.25,
"layouts": 12,
"layoutDurationMs": 3.678,
"taskDurationMs": 933.2320000000001,
"heapDeltaBytes": -2878128,
"heapUsedBytes": 49802312,
"domNodes": -261,
"jsHeapTotalBytes": 16642048,
"scriptDurationMs": 132.13199999999998,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1794.8020000000042,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.355000000000004,
"layouts": 12,
"layoutDurationMs": 3.463,
"taskDurationMs": 784.5459999999999,
"heapDeltaBytes": -12972740,
"heapUsedBytes": 56665268,
"domNodes": -238,
"jsHeapTotalBytes": 18763776,
"scriptDurationMs": 117.31099999999998,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.6549999999988,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.119000000000003,
"layouts": 6,
"layoutDurationMs": 0.559,
"taskDurationMs": 358.496,
"heapDeltaBytes": -4026720,
"heapUsedBytes": 65525932,
"domNodes": -228,
"jsHeapTotalBytes": 11685888,
"scriptDurationMs": 18.644,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.1470000000918,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.076,
"layouts": 6,
"layoutDurationMs": 0.5949999999999999,
"taskDurationMs": 305.554,
"heapDeltaBytes": 1991744,
"heapUsedBytes": 60767920,
"domNodes": 78,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 19.343,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 613.4370000000331,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.9529999999999,
"heapDeltaBytes": -2820620,
"heapUsedBytes": 49854196,
"domNodes": -274,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 58.589,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 600.6779999999026,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.856,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.818,
"heapDeltaBytes": 2403712,
"heapUsedBytes": 72019192,
"domNodes": -283,
"jsHeapTotalBytes": 5918720,
"scriptDurationMs": 54.243,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2048.7870000000044,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.355,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.958,
"heapDeltaBytes": -24755236,
"heapUsedBytes": 59735316,
"domNodes": -263,
"jsHeapTotalBytes": 2437120,
"scriptDurationMs": 92.01200000000001,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2020.8059999999932,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.707,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.894,
"heapDeltaBytes": 11038748,
"heapUsedBytes": 69178244,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 90.15899999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2088.6800000000108,
"styleRecalcs": 69,
"styleRecalcDurationMs": 18.431000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1017.884,
"heapDeltaBytes": 29997708,
"heapUsedBytes": 85876112,
"domNodes": 18,
"jsHeapTotalBytes": 7020544,
"scriptDurationMs": 381.134,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2098.940000000084,
"styleRecalcs": 68,
"styleRecalcDurationMs": 18.076,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1021.7460000000001,
"heapDeltaBytes": 30119776,
"heapUsedBytes": 89890552,
"domNodes": 16,
"jsHeapTotalBytes": 7254016,
"scriptDurationMs": 383.259,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3186.813000000029,
"styleRecalcs": 66,
"styleRecalcDurationMs": 20.388999999999996,
"layouts": 60,
"layoutDurationMs": 8.019,
"taskDurationMs": 1329.612,
"heapDeltaBytes": 16084204,
"heapUsedBytes": 71692852,
"domNodes": 14,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 493.09999999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3065.3539999999566,
"styleRecalcs": 62,
"styleRecalcDurationMs": 15.267000000000003,
"layouts": 60,
"layoutDurationMs": 7.319999999999999,
"taskDurationMs": 1255.751,
"heapDeltaBytes": 13819836,
"heapUsedBytes": 68249144,
"domNodes": -284,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 470.17500000000007,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.591000000044,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.580999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.38800000000003,
"heapDeltaBytes": -10356148,
"heapUsedBytes": 58567808,
"domNodes": -274,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 86.776,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2031.2629999999672,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.797999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.993,
"heapDeltaBytes": 7161444,
"heapUsedBytes": 60914416,
"domNodes": -263,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 95.347,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.6460000000407,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.658999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.784,
"heapDeltaBytes": -23169552,
"heapUsedBytes": 46462124,
"domNodes": -280,
"jsHeapTotalBytes": 6443008,
"scriptDurationMs": 123.19699999999999,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.6910000000116,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.963000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.66700000000003,
"heapDeltaBytes": 8046364,
"heapUsedBytes": 66947120,
"domNodes": 20,
"jsHeapTotalBytes": 18087936,
"scriptDurationMs": 121.44899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2056.959000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.892999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.341,
"heapDeltaBytes": -8021972,
"heapUsedBytes": 61587780,
"domNodes": -277,
"jsHeapTotalBytes": 20860928,
"scriptDurationMs": 14.325000000000001,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2041.2239999999429,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.901000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.96799999999996,
"heapDeltaBytes": -8164112,
"heapUsedBytes": 61526668,
"domNodes": -281,
"jsHeapTotalBytes": 19550208,
"scriptDurationMs": 12.909,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1810.4769999999917,
"styleRecalcs": 80,
"styleRecalcDurationMs": 48.023,
"layouts": 16,
"layoutDurationMs": 5.407,
"taskDurationMs": 810.459,
"heapDeltaBytes": -16974344,
"heapUsedBytes": 52686052,
"domNodes": -232,
"jsHeapTotalBytes": 19288064,
"scriptDurationMs": 98.128,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.6239999999862,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.111,
"layouts": 16,
"layoutDurationMs": 4.404,
"taskDurationMs": 679.515,
"heapDeltaBytes": -5521848,
"heapUsedBytes": 57817916,
"domNodes": 62,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 93.80499999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1065.4230000000098,
"styleRecalcs": 17,
"styleRecalcDurationMs": 32.510999999999996,
"layouts": 13,
"layoutDurationMs": 15.959999999999999,
"taskDurationMs": 857.952,
"heapDeltaBytes": 3987264,
"heapUsedBytes": 93514564,
"domNodes": 12228,
"jsHeapTotalBytes": 10240000,
"scriptDurationMs": 29.909000000000006,
"eventListeners": 846,
"totalBlockingTimeMs": 154,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8188.008000000025,
"styleRecalcs": 249,
"styleRecalcDurationMs": 53.760000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3806.969,
"heapDeltaBytes": 15496704,
"heapUsedBytes": 75634152,
"domNodes": -265,
"jsHeapTotalBytes": 8318976,
"scriptDurationMs": 1229.687,
"eventListeners": -122,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8128.607999999986,
"styleRecalcs": 249,
"styleRecalcDurationMs": 52.316,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3587.8430000000003,
"heapDeltaBytes": 15446280,
"heapUsedBytes": 68925392,
"domNodes": -270,
"jsHeapTotalBytes": 2564096,
"scriptDurationMs": 1244.905,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12365.76500000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12344.223,
"heapDeltaBytes": -35108816,
"heapUsedBytes": 170405632,
"domNodes": -3300,
"jsHeapTotalBytes": -552960,
"scriptDurationMs": 545.9920000000001,
"eventListeners": -16378,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12496.69099999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12480.687,
"heapDeltaBytes": -28556948,
"heapUsedBytes": 171746392,
"domNodes": -3302,
"jsHeapTotalBytes": 22515712,
"scriptDurationMs": 516.437,
"eventListeners": -16376,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15319.249000000014,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.261999999999944,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15286.966,
"heapDeltaBytes": -50624008,
"heapUsedBytes": 155775800,
"domNodes": -3300,
"jsHeapTotalBytes": 4165632,
"scriptDurationMs": 831.7450000000001,
"eventListeners": -16376,
"totalBlockingTimeMs": 3,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15090.51599999998,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.927999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15067.578000000001,
"heapDeltaBytes": -48950444,
"heapUsedBytes": 178747784,
"domNodes": -3300,
"jsHeapTotalBytes": 671744,
"scriptDurationMs": 840.274,
"eventListeners": -16378,
"totalBlockingTimeMs": 10,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 485.00699999999597,
"styleRecalcs": 20,
"styleRecalcDurationMs": 37.981,
"layouts": 5,
"layoutDurationMs": 1.444,
"taskDurationMs": 227.937,
"heapDeltaBytes": -22069736,
"heapUsedBytes": 48672476,
"domNodes": -164,
"jsHeapTotalBytes": 5132288,
"scriptDurationMs": 18.271,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 453.8710000000492,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.162999999999997,
"layouts": 4,
"layoutDurationMs": 1.182,
"taskDurationMs": 114.956,
"heapDeltaBytes": 4955208,
"heapUsedBytes": 64078700,
"domNodes": 159,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 17.858000000000004,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds ChangesCodeRabbit configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.coderabbit.yaml:
- Around line 68-82: The `**/*.test.ts` rule currently mixes universal Vitest
guidance with litegraph-only review rules, which will create irrelevant review
noise for unrelated tests. Split the litegraph-specific guidance out of the
blanket test rule and move the `litegraphTestUtils` reuse and “mock litegraph
classes” checks into a narrower `path_instructions` entry scoped to
litegraph-related source/test paths, while keeping the existing `**/*.test.ts`
entry limited to broadly applicable test rules.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 3ccd56b0-168f-41b5-bf30-c565edbf5a4f
📒 Files selected for processing (1)
.coderabbit.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #13486 +/- ##
==========================================
+ Coverage 78.17% 78.24% +0.06%
==========================================
Files 1648 1650 +2
Lines 95561 96370 +809
Branches 33460 33677 +217
==========================================
+ Hits 74704 75401 +697
- Misses 20182 20262 +80
- Partials 675 707 +32
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
huang47
force-pushed
the
codex/coderabbit-test-quality-path-instructions
branch
from
f342178 to
2120c13
Compare
Contributor
Author
|
@coderabbitai review Created by Codex |
Contributor
|
✅ Action performedReview finished.
|
huang47
force-pushed
the
codex/coderabbit-test-quality-path-instructions
branch
from
2120c13 to
3e043ac
Compare
Contributor
Author
|
@coderabbitai review Created by Codex |
Contributor
|
✅ Action performedReview finished.
|
dosubot
Bot
added
the
size:XS
huang47
added a commit
that referenced
this pull request
Jul 8, 2026
Apply the PR #13362 diff on top of the PR #13486 CodeRabbit path-instruction branch so CodeRabbit can review real changed test files before #13486 merges. Verification: replayed the origin/pr-13362 commit range onto origin/pr-13486 with git cherry-pick --no-commit and no conflicts; parsed .coderabbit.yaml with Ruby YAML.load_file successfully; ran git diff --cached --check successfully.
huang47
added a commit
that referenced
this pull request
Jul 8, 2026
Apply the PR #13362 diff on top of the PR #13486 CodeRabbit path-instruction branch so CodeRabbit can review real changed test files before #13486 merges. Verification: replayed the origin/pr-13362 commit range onto origin/pr-13486 with git cherry-pick --no-commit and no conflicts; parsed .coderabbit.yaml with Ruby YAML.load_file successfully; ran git diff --cached --check successfully.
huang47
added a commit
that referenced
this pull request
Jul 8, 2026
Apply only the PR #13362 files needed to exercise the two DrJKL review patterns against the updated #13486 CodeRabbit instructions: app queue credential cleanup coverage and direct LGraph.configure() sparse-link coverage. Include the companion type-fix files required for the subset to pass typecheck. Verification: staged the targeted PR #13362 files plus typecheck dependencies; ran git diff --cached --check successfully; pre-commit ran oxfmt, oxlint, eslint, and pnpm typecheck.
huang47
added a commit
that referenced
this pull request
Jul 8, 2026
Replays representative PR #13362 patterns on top of PR #13486 so CodeRabbit can prove the updated path instructions catch DrJKL-style feedback: credential cleanup, sparse link coverage, listener/global teardown, rootGraph coverage, helper reuse, change-detector tests, as-never casts, and dropped async callbacks. Verified with: pnpm typecheck and git diff --check.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
huang47
force-pushed
the
codex/coderabbit-test-quality-path-instructions
branch
from
479bf2f to
3a7ec3e
Compare
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
huang47
force-pushed
the
codex/coderabbit-test-quality-path-instructions
branch
from
f2cd07a to
3a7ec3e
Compare
Route changed .test.ts files through CodeRabbit guidance that explicitly names .agents/checks/test-quality.md, docs/testing/README.md, and docs/guidance/vitest.md as required review context. Verification: parsed .coderabbit.yaml with Ruby YAML and ran git diff --check.
Move litegraph-only test guidance out of the blanket **/*.test.ts rule and into src/lib/litegraph/**/*.test.ts so unrelated Vitest files are not nudged toward litegraph factories or litegraph class mocking rules. The instruction also covers the DrJKL-style sparse-link cases from PR #13362: direct LGraph.configure() coverage for links: [null, validLink], direct compression coverage for compressWidgetInputSlots(), and avoiding helper-only coverage when a changed runtime path needs its own regression test. Verification: parsed .coderabbit.yaml with Ruby YAML and ran git diff --check.
Route changed browser_tests/**/*.spec.ts and apps/website/e2e/**/*.spec.ts files through CodeRabbit guidance that explicitly names .agents/checks/test-quality.md, docs/testing/README.md, and docs/guidance/playwright.md as required review context. Verification: parsed .coderabbit.yaml with Ruby YAML and ran git diff --check.
huang47
force-pushed
the
codex/coderabbit-test-quality-path-instructions
branch
from
3a7ec3e to
2e0d961
Compare
huang47
changed the title
DrJKL
reviewed
Jul 8, 2026
DrJKL
reviewed
Jul 8, 2026
DrJKL
reviewed
Jul 8, 2026
dosubot
Bot
added
size:S
Move the litegraph-specific CodeRabbit review rules into docs/testing/litegraph-testing.md, link the guide from docs/testing/README.md, and keep .coderabbit.yaml as a path-to-docs bridge. Verification: parsed .coderabbit.yaml with Ruby YAML and ran git diff --check.
huang47
force-pushed
the
codex/coderabbit-test-quality-path-instructions
branch
from
b0e7225 to
b3293d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CodeRabbit
path_instructionsso changed test files are reviewed with the repo's existing test guidance docs.Changes
**/*.test.tsfiles to.agents/checks/test-quality.md,docs/testing/README.md, anddocs/guidance/vitest.md.{browser_tests,apps/website/e2e}/**/*.spec.tsfiles to.agents/checks/test-quality.md,docs/testing/README.md, anddocs/guidance/playwright.md.docs/testing/litegraph-testing.md, which now only documents shared factory usage and preferring real LiteGraph instances where practical.Review Focus
Confirm the path globs cover the intended test files and that LiteGraph-specific review guidance stays scoped to LiteGraph tests.
Testing
.coderabbit.yamlwith Ruby YAMLgit diff --checkoxfmt,oxlint,eslint, andpnpm typecheckknip --cacheCreated by Codex