Skip to content

test(website): add e2e specs for the learning page#13529

Open
imick-io wants to merge 1 commit into
mainfrom
fix/learning-specs
Open

test(website): add e2e specs for the learning page#13529
imick-io wants to merge 1 commit into
mainfrom
fix/learning-specs

Conversation

@imick-io

@imick-io imick-io commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add end-to-end test coverage for the /learning page, which previously had none.

Changes

  • What: New e2e/learning.spec.ts covering the EN page smoke behaviour (hero, featured workflow, tutorial grid rendered from the learningTutorials data source, per-tutorial Try Workflow links, and the contact-sales CTA), the tutorial video dialog open/close/Escape interactions, and the zh-CN localized page.

Review Focus

Assertions are driven off the learningTutorials data source and t() i18n keys rather than hardcoded strings to avoid change-detector tests. Media is stubbed by the auto-applied blockExternalMedia fixture, so the specs have no network dependency. The tutorial-dialog interaction uses a toPass retry to accommodate client:visible hydration.

Cover the learning page smoke behaviour (hero, featured workflow,
tutorial grid, workflow links, CTA), the tutorial video dialog
open/close/Escape interactions, and the zh-CN localized page.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@imick-io imick-io requested a review from a team July 9, 2026 00:11
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f42e39dd-bf12-41e2-9a8c-b7d3e444be16

📥 Commits

Reviewing files that changed from the base of the PR and between e11f98b and feef23a.

📒 Files selected for processing (1)
  • apps/website/e2e/learning.spec.ts

📝 Walkthrough

Walkthrough

Adds a new Playwright e2e spec file for the Learning page, testing default-locale content (hero, tutorials, CTA links), tutorial dialog open/close behavior with retry handling, and localized zh-CN smoke checks for page title, heading, and tutorial button text.

Changes

Learning page e2e tests

Layer / File(s) Summary
Test helpers
apps/website/e2e/learning.spec.ts
Adds imports and a tutorialButtonName helper formatting localized tutorial button labels for en and zh-CN.
Default-locale smoke tests
apps/website/e2e/learning.spec.ts
Verifies page title, hero headline, featured workflow section, tutorial button rendering from learningTutorials, Try Workflow links, and contact-sales CTA link.
Tutorial dialog tests
apps/website/e2e/learning.spec.ts
Verifies opening the tutorial dialog (with retry for delayed hydration), dialog heading visibility, and dismissal via close button and Escape key.
Localized zh-CN smoke tests
apps/website/e2e/learning.spec.ts
Verifies localized page title, CJK heading content, tutorials heading visibility, and localized tutorial button title.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: adding e2e specs for the learning page.
Description check ✅ Passed The description matches the required template well, covering summary, changes, and review focus in a clear way.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed Changes are only in apps/website/e2e, which the check exempts; PR description already explains the new Playwright coverage.
Adr Compliance For Entity/Litegraph Changes ✅ Passed Changed file is only apps/website/e2e/learning.spec.ts; no src/lib/litegraph, src/ecs, or graph-entity code was modified.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/learning-specs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-13529.vercel.app

This commit: https://website-frontend-kfclssml1-comfyui.vercel.app

Last updated: 2026-07-09T00:13:02Z for feef23a

@imick-io imick-io self-assigned this Jul 9, 2026

@huang47 huang47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit:

nit: feef23aeb includes Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>, which violates AGENTS.md:70; please scrub it via amend/squash before merge.

Visual evidence: PR-head tested flow for /learning tutorial dialog, then /zh-CN/learning:

pr-13529-tested-flow.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants