test(website): add e2e specs for the learning page#13529
Conversation
Cover the learning page smoke behaviour (hero, featured workflow, tutorial grid, workflow links, CTA), the tutorial video dialog open/close/Escape interactions, and the zh-CN localized page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a new Playwright e2e spec file for the Learning page, testing default-locale content (hero, tutorials, CTA links), tutorial dialog open/close behavior with retry handling, and localized zh-CN smoke checks for page title, heading, and tutorial button text. ChangesLearning page e2e tests
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-13529.vercel.app This commit: https://website-frontend-kfclssml1-comfyui.vercel.app Last updated: 2026-07-09T00:13:02Z for |
huang47
left a comment
There was a problem hiding this comment.
LGTM with one nit:
nit: feef23aeb includes Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>, which violates AGENTS.md:70; please scrub it via amend/squash before merge.
Visual evidence: PR-head tested flow for /learning tutorial dialog, then /zh-CN/learning:
Summary
Add end-to-end test coverage for the
/learningpage, which previously had none.Changes
e2e/learning.spec.tscovering the EN page smoke behaviour (hero, featured workflow, tutorial grid rendered from thelearningTutorialsdata source, per-tutorial Try Workflow links, and the contact-sales CTA), the tutorial video dialog open/close/Escape interactions, and the zh-CN localized page.Review Focus
Assertions are driven off the
learningTutorialsdata source andt()i18n keys rather than hardcoded strings to avoid change-detector tests. Media is stubbed by the auto-appliedblockExternalMediafixture, so the specs have no network dependency. The tutorial-dialog interaction uses atoPassretry to accommodateclient:visiblehydration.