Skip to content

fix: avoid large option lists in node previews#13776

Open
loulanyue wants to merge 1 commit into
Comfy-Org:mainfrom
loulanyue:fix/node-preview-large-combo-14872
Open

fix: avoid large option lists in node previews#13776
loulanyue wants to merge 1 commit into
Comfy-Org:mainfrom
loulanyue:fix/node-preview-large-combo-14872

Conversation

@loulanyue

Copy link
Copy Markdown

Summary

Prevent inert node previews from materializing full combo option lists, which freezes node search when LoadImage exposes a very large input file list.

Changes

  • What: Keep only the value displayed by a combo widget in preview-only node data instead of retaining every option.
  • Tests: Add a 10,000-option LoadImage regression case and update existing preview expectations.

Review Focus

The real canvas node and its dropdown options are unchanged. Only the non-interactive preview data is reduced to the selected, default, or first combo value.

Fixes Comfy-Org/ComfyUI#14872

Validation

  • Related preview/search/widget tests: 89 passed
  • pnpm typecheck: passed
  • pnpm lint: passed (3 unrelated existing warnings)
  • pnpm format:check: passed
  • pnpm knip: passed
  • Repository pre-commit and pre-push hooks: passed

Disclosure: Codex assisted with source tracing and implementation. I reviewed the diff and ran the checks listed above.

@loulanyue
loulanyue requested a review from a team July 17, 2026 23:35
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged.
Posted by the CLA Assistant Lite bot.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

🎨 Storybook: 🚧 Building...

🎭 Playwright: ⏳ Running...

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 96eb5d34-bfc8-4172-b3c8-ae11284b3c3c

📥 Commits

Reviewing files that changed from the base of the PR and between 832d48e and a41741e.

📒 Files selected for processing (2)
  • src/renderer/extensions/vueNodes/components/LGraphNodePreview.test.ts
  • src/renderer/extensions/vueNodes/components/LGraphNodePreview.vue

📝 Walkthrough

Walkthrough

COMBO widget previews now resolve their displayed value from provided values, defaults, or the first option, and reduce available preview options to that value. Tests cover provided values, missing values, and large option lists.

Changes

COMBO preview behavior

Layer / File(s) Summary
Resolve COMBO preview values and validate options
src/renderer/extensions/vueNodes/components/LGraphNodePreview.vue, src/renderer/extensions/vueNodes/components/LGraphNodePreview.test.ts
COMBO previews use the provided value, default, or first option and expose it as the sole option; tests cover missing values and large option lists.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: christian-byrne


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive PR description suggests a bug fix, but the PR title/commit subjects are unavailable here, so the fail condition cannot be verified. Please provide the PR title and commit subjects (or the full changed-file/commit metadata) so the regression-test check can be applied.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: reducing large combo option lists in node previews.
Description check ✅ Passed The description covers Summary, Changes, Review Focus, and validation details, which is mostly complete for the template.
Linked Issues check ✅ Passed The preview-only combo reduction and regression test address the reported /object_info search freeze in issue #14872.
Out of Scope Changes check ✅ Passed The diff appears limited to the preview behavior and related tests, with no unrelated changes introduced.
Adr Compliance For Entity/Litegraph Changes ✅ Passed No ADR 0003/0008 patterns appear: the PR only changes preview data derivation/tests, with no entity mutation, new graph/node methods, ECS components, or extension callbacks.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@loulanyue

Copy link
Copy Markdown
Author

I have read and agree to the Contributor License Agreement

comfy-legal added a commit to Comfy-Org/comfy-cla that referenced this pull request Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node search modal freezes when /object_info contains a very large LoadImage input file list

1 participant