fix: avoid large option lists in node previews#13776
Conversation
|
✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged. |
🎨 Storybook: 🚧 Building...🎭 Playwright: ⏳ Running... |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughCOMBO widget previews now resolve their displayed value from provided values, defaults, or the first option, and reduce available preview options to that value. Tests cover provided values, missing values, and large option lists. ChangesCOMBO preview behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I have read and agree to the Contributor License Agreement |
Summary
Prevent inert node previews from materializing full combo option lists, which freezes node search when LoadImage exposes a very large input file list.
Changes
Review Focus
The real canvas node and its dropdown options are unchanged. Only the non-interactive preview data is reduced to the selected, default, or first combo value.
Fixes Comfy-Org/ComfyUI#14872
Validation
pnpm typecheck: passedpnpm lint: passed (3 unrelated existing warnings)pnpm format:check: passedpnpm knip: passedDisclosure: Codex assisted with source tracing and implementation. I reviewed the diff and ran the checks listed above.