Skip to content

docs: add missing nested CLAUDE.md shims#13824

Open
mattmillerai wants to merge 4 commits into
mainfrom
matt/be-3550-nested-claude-md-shims
Open

docs: add missing nested CLAUDE.md shims#13824
mattmillerai wants to merge 4 commits into
mainfrom
matt/be-3550-nested-claude-md-shims

Conversation

@mattmillerai

Copy link
Copy Markdown
Contributor

ELI-5

Claude Code only reads a file named CLAUDE.md — it does not fall back to AGENTS.md. So in every folder that has agent instructions in AGENTS.md, we drop a tiny sibling CLAUDE.md that just says "read AGENTS.md." Four nested folders were missing that sibling; this adds it so Claude picks up their guidance too.

Summary

Add the missing nested CLAUDE.md shim beside four nested AGENTS.md files so Claude Code loads their directory-scoped guidance (it reads only CLAUDE.md, with no AGENTS.md fallback).

Changes

  • What: New CLAUDE.md shim (canonical content: a one-line explanatory comment + @AGENTS.md, which resolves relative to the shim's own directory) added in:
    • src/components/ui/
    • src/types/
    • browser_tests/tests/propertiesPanel/
    • apps/website/src/pages/cloud/supported-nodes/

Review Focus

  • Docs-only, additive. No existing AGENTS.md (or any other file) was modified.
  • After this change, every directory containing an AGENTS.md in the repo has a sibling CLAUDE.md (verified via comm of the two file-dir sets, root included) — these four were the only gaps.
  • Shim content is the exact canonical shim rather than the whimsical per-file couplets used by the older sibling shims; both are accepted, and the canonical form is consistent and reproducible.
  • No CI impact: markdown files, and the repo has no markdown linter; oxfmt/eslint/knip/vitest don't touch them.

@mattmillerai
mattmillerai requested a review from a team July 19, 2026 02:21
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 19, 2026
@mattmillerai mattmillerai added agent-coded Opened by the agent-work code loop cursor-review Trigger multi-model Cursor agent review on this PR labels Jul 19, 2026
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3c55bd7d-8349-4257-b337-e4b535f59207

📥 Commits

Reviewing files that changed from the base of the PR and between e0e6b44 and 60b931d.

📒 Files selected for processing (4)
  • apps/website/src/pages/cloud/supported-nodes/CLAUDE.md
  • browser_tests/tests/propertiesPanel/CLAUDE.md
  • src/components/ui/CLAUDE.md
  • src/types/CLAUDE.md
💤 Files with no reviewable changes (4)
  • src/types/CLAUDE.md
  • apps/website/src/pages/cloud/supported-nodes/CLAUDE.md
  • src/components/ui/CLAUDE.md
  • browser_tests/tests/propertiesPanel/CLAUDE.md

📝 Walkthrough

Walkthrough

Four CLAUDE.md files were added or updated to reference shared agent instructions from AGENTS.md through @AGENTS.md include directives.

Changes

Claude instruction shims

Layer / File(s) Summary
Add shared AGENTS.md includes
apps/website/src/pages/cloud/supported-nodes/CLAUDE.md, browser_tests/tests/propertiesPanel/CLAUDE.md, src/components/ui/CLAUDE.md, src/types/CLAUDE.md
Each file contains an @AGENTS.md directive that references the shared instruction source.

Estimated code review effort: 1 (Trivial) | ~2 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive PR files/description are present, but the PR title and commit subjects aren’t available here, so the bug-fix signal can’t be verified. Provide the PR title and commit subjects, or include them in the review context, so I can check whether bug-fix language triggers the E2E-test requirement.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: adding missing nested CLAUDE.md shims.
Description check ✅ Passed The description covers the required Summary, Changes, and Review Focus sections; only the optional Screenshots section is omitted.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed No changed files touch src/lib/litegraph/, src/ecs/, or graph-entity paths; this docs-only PR is out of scope for ADR checks.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch matt/be-3550-nested-claude-md-shims

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-13824.vercel.app

This commit: https://website-frontend-8k3rysdcu-comfyui.vercel.app

Last updated: 2026-07-20T19:48:36Z for 60b931d

@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 07/20/2026, 07:49:10 PM UTC

Links

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @mattmillerai.

✅ No high-signal findings.

Panel: 8/8 reviewers contributed findings.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/website/src/pages/cloud/supported-nodes/CLAUDE.md`:
- Around line 1-3: Remove the explanatory HTML comment from each governed shim,
leaving only the `@AGENTS.md` directive. Apply this change to
apps/website/src/pages/cloud/supported-nodes/CLAUDE.md lines 1-3,
browser_tests/tests/propertiesPanel/CLAUDE.md lines 1-3, and src/types/CLAUDE.md
lines 1-3.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ac05c3f5-6c96-42cf-844e-0718f7120d2f

📥 Commits

Reviewing files that changed from the base of the PR and between f2ad3c4 and e0e6b44.

📒 Files selected for processing (4)
  • apps/website/src/pages/cloud/supported-nodes/CLAUDE.md
  • browser_tests/tests/propertiesPanel/CLAUDE.md
  • src/components/ui/CLAUDE.md
  • src/types/CLAUDE.md

Comment thread apps/website/src/pages/cloud/supported-nodes/CLAUDE.md Outdated
Match the existing bare @AGENTS.md shim convention used across the repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-coded Opened by the agent-work code loop cursor-review Trigger multi-model Cursor agent review on this PR size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants