Vue expose#4265
Merged
Merged
Conversation
webfiltered
suggested changes
Jun 25, 2025
webfiltered
left a comment
webfiltered
left a comment
Contributor
There was a problem hiding this comment.
Just addressed the direct defineStore expose - can come back and review properly once we have a solution for that!
christian-byrne
approved these changes
Jul 3, 2025
christian-byrne
left a comment
christian-byrne
left a comment
Contributor
There was a problem hiding this comment.
The past bugs have been confirmed resolved. We should merge this so we can get some coverage and see if any new bugs exist.
This PR is necessary for various things such as vue extensions.
comfy-jinyi
pushed a commit
that referenced
this pull request
Jul 4, 2025
benceruleanlu
pushed a commit
that referenced
this pull request
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re-sent and enable Vue expose for custom nodes
Also as practiced in a real vue-based project, it is necessary to expose defineStore to allow pinia.for custom nodes, which reverted in #4027 before
┆Issue is synchronized with this Notion page by Unito