Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
3346588
fix: rewrite Ogg parser for multi-page packets (#9256)
xeinherjer-dev Mar 1, 2026
5f0306b
Apply review suggestions (#9256)
xeinherjer-dev Mar 2, 2026
86a006b
test: refine ogg metadata assertions based on review feedback
xeinherjer-dev Mar 2, 2026
ce95bf6
refactor: address CodeRabbit nitpicks (explicit types, simpler assert…
xeinherjer-dev Mar 2, 2026
531cc00
fix: allow minimal Ogg pages with exactly 27 header bytes (<= boundar…
xeinherjer-dev Mar 2, 2026
1394ce8
docs(ogg): add JSDoc comments to all functions to meet docstring cove…
xeinherjer-dev Mar 7, 2026
79cab54
refactor(metadata): address review comments for Ogg metadata parser
xeinherjer-dev Mar 13, 2026
ef4fdf6
test: add ogg workflow test and fix mimetype mapping
xeinherjer-dev Mar 14, 2026
95b42ab
Merge branch 'main' into fix-ogg-syntax-9256
xeinherjer-dev Mar 19, 2026
c70935b
Merge remote-tracking branch 'upstream/main' into fix-ogg-syntax-9256
xeinherjer-dev Mar 20, 2026
bdba965
Merge branch 'Comfy-Org:main' into fix-ogg-syntax-9256
xeinherjer-dev Mar 22, 2026
e73176a
Merge branch 'Comfy-Org:main' into fix-ogg-syntax-9256
xeinherjer-dev Mar 25, 2026
669e476
Merge branch 'main' into fix-ogg-syntax-9256
xeinherjer-dev Mar 29, 2026
2056c4e
Merge branch 'main' into fix-ogg-syntax-9256
xeinherjer-dev Apr 3, 2026
2566af7
Merge branch 'main' into fix-ogg-syntax-9256
xeinherjer-dev Apr 10, 2026
c9b63f8
Merge branch 'main' into fix-ogg-syntax-9256
xeinherjer-dev Apr 16, 2026
fc2b24f
Merge branch 'main' into fix-ogg-syntax-9256
xeinherjer-dev Apr 18, 2026
d1ff84c
Merge branch 'main' into fix-ogg-syntax-9256
xeinherjer-dev Apr 25, 2026
90cd71d
Merge remote-tracking branch 'origin/main' into fix-ogg-syntax-9256
xeinherjer-dev Apr 29, 2026
195081a
Merge remote-tracking branch 'origin/main' into fix-ogg-syntax-9256
xeinherjer-dev May 3, 2026
246a50b
Merge remote-tracking branch 'origin/main' into fix-ogg-syntax-9256
xeinherjer-dev May 4, 2026
9364af6
refactor(metadata): address Ogg parser review comments
xeinherjer-dev May 4, 2026
221cbeb
Merge branch 'Comfy-Org:main' into fix-ogg-syntax-9256
xeinherjer-dev May 11, 2026
8a369e9
Merge remote-tracking branch 'upstream/main' into fix-ogg-syntax-9256
xeinherjer-dev May 13, 2026
93c55af
test: remove invalid JSON scenario made redundant by #12217 merge
xeinherjer-dev May 14, 2026
94f0e00
Merge branch 'main' into fix-ogg-syntax-9256
xeinherjer-dev May 14, 2026
91e7b3a
chore: sync ModelHeroSection.vue with upstream
xeinherjer-dev May 14, 2026
06ff9a0
Merge branch 'main' into fix-ogg-syntax-9256
xeinherjer-dev May 14, 2026
70b95ee
Merge branch 'Comfy-Org:main' into fix-ogg-syntax-9256
xeinherjer-dev May 16, 2026
0448af1
Merge branch 'main' into fix-ogg-syntax-9256
xeinherjer-dev May 22, 2026
b7ea189
Merge branch 'Comfy-Org:main' into fix-ogg-syntax-9256
xeinherjer-dev May 22, 2026
b8a6b69
Merge branch 'Comfy-Org:main' into fix-ogg-syntax-9256
xeinherjer-dev May 30, 2026
8194c93
Merge branch 'main' into fix-ogg-syntax-9256
xeinherjer-dev Jun 21, 2026
183ab3e
Merge branch 'main' into fix-ogg-syntax-9256
xeinherjer-dev Jul 12, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added browser_tests/assets/workflowInMedia/workflow.ogg
Binary file not shown.
1 change: 1 addition & 0 deletions browser_tests/fixtures/utils/mimeTypeUtil.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,6 @@ export function getMimeType(fileName: string): string {
if (name.endsWith('.ogg') || name.endsWith('.opus')) return 'audio/ogg'
if (name.endsWith('.json')) return 'application/json'
if (name.endsWith('.glb')) return 'model/gltf-binary'
if (name.endsWith('.ogg')) return 'audio/ogg'
return 'application/octet-stream'
}
3 changes: 2 additions & 1 deletion browser_tests/tests/loadWorkflowInMedia.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ test.describe(
'workflow.mp4',
'workflow.mov',
'workflow.m4v',
'workflow.svg'
'workflow.svg',
'workflow.ogg'
// TODO: Re-enable after fixing test asset to use core nodes only
// Currently opens missing nodes dialog which is outside scope of AVIF loading functionality
// 'workflow.avif'
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading