Skip to content

Commit 137bbb6

Browse files
author
coderfromthenorth93
committed
Move min versions to node_version
1 parent 2e1b758 commit 137bbb6

3 files changed

Lines changed: 8 additions & 19 deletions

File tree

comfy_cli/registry/api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,12 @@ def publish_node_version(self, node_config: PyProjectConfig, token) -> PublishNo
5555
"license": license_json,
5656
"repository": node_config.project.urls.repository,
5757
"supported_os": node_config.project.supported_os,
58-
"min_version_comfyUI_frontend": node_config.project.min_version_comfyUI_frontend,
59-
"min_version_comfyUI": node_config.project.min_version_comfyUI,
6058
},
6159
"node_version": {
6260
"version": node_config.project.version,
6361
"dependencies": node_config.project.dependencies,
62+
"min_version_comfyUI_frontend": node_config.project.min_version_comfyUI_frontend,
63+
"min_version_comfyUI": node_config.project.min_version_comfyUI,
6464
},
6565
}
6666
print(request_body)

comfy_cli/registry/config_parser.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,10 @@ def extract_node_configuration(
166166
if len(parts) > 1:
167167
min_version_comfyUI_frontend = parts[1].strip()
168168
break
169-
170-
dependencies = [dep for dep in dependencies if not (isinstance(dep, str) and dep.startswith("comfyui-frontend-package"))]
169+
170+
dependencies = [
171+
dep for dep in dependencies if not (isinstance(dep, str) and dep.startswith("comfyui-frontend-package"))
172+
]
171173

172174
classifiers = project_data.get("classifiers", [])
173175
supported_os = [c for c in classifiers if c.startswith("Operating System :: ")]

tests/comfy_cli/registry/test_config_parser.py

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -154,15 +154,7 @@ def test_extract_node_configuration_with_os_classifiers():
154154

155155

156156
def test_extract_node_configuration_with_comfyui_version():
157-
mock_data = {
158-
"project": {
159-
"dependencies": [
160-
"requests>=2.0.0",
161-
"comfyui-frontend-package>=1.2.3",
162-
"numpy>=1.0.0"
163-
]
164-
}
165-
}
157+
mock_data = {"project": {"dependencies": ["requests>=2.0.0", "comfyui-frontend-package>=1.2.3", "numpy>=1.0.0"]}}
166158
with (
167159
patch("os.path.isfile", return_value=True),
168160
patch("builtins.open", mock_open()),
@@ -179,12 +171,7 @@ def test_extract_node_configuration_with_comfyui_version():
179171

180172

181173
def test_extract_node_configuration_with_requires_comfyui():
182-
mock_data = {
183-
"project": {},
184-
"tool": {
185-
"requires-comfyui": "2.0.0"
186-
}
187-
}
174+
mock_data = {"project": {}, "tool": {"requires-comfyui": "2.0.0"}}
188175
with (
189176
patch("os.path.isfile", return_value=True),
190177
patch("builtins.open", mock_open()),

0 commit comments

Comments
 (0)