Commit 5cc0d14
committed
fix: use absolute path for pip install -r target
try_install_script runs pip with cwd=repo_path, so if requirements_path
were relative it would get re-resolved against that cwd, producing a
doubled path like <rel>/<rel>/requirements.txt.
Wrap the requirements_path with os.path.abspath before handing it to
pip to make the -r target unambiguous regardless of whether the caller
passes an absolute or relative repo_path. Add a regression test that
invokes execute_install_script with a relative repo_path.
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>1 parent a399d41 commit 5cc0d14
2 files changed
Lines changed: 29 additions & 1 deletion
File tree
- comfy_cli/command/custom_nodes
- tests/comfy_cli
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
174 | | - | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
175 | 178 | | |
176 | 179 | | |
177 | 180 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
| |||
104 | 105 | | |
105 | 106 | | |
106 | 107 | | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
107 | 132 | | |
108 | 133 | | |
109 | 134 | | |
| |||
0 commit comments