Skip to content

Commit c44e894

Browse files
committed
fix: sync module-level user_id after init_tracking generates UUID
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
1 parent e6d700b commit c44e894

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

comfy_cli/tracking.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ def init_tracking(enable_tracking: bool):
9797
"""
9898
Initialize the tracking system by setting the user identifier and tracking enabled status.
9999
"""
100+
global user_id
100101
logging.debug(f"Initializing tracking with enable_tracking: {enable_tracking}")
101102
config_manager.set(constants.CONFIG_KEY_ENABLE_TRACKING, str(enable_tracking))
102103
if not enable_tracking:
@@ -108,6 +109,7 @@ def init_tracking(enable_tracking: bool):
108109
curr_user_id = str(uuid.uuid4())
109110
config_manager.set(constants.CONFIG_KEY_USER_ID, curr_user_id)
110111
logging.debug(f'Setting user identifier for tracking user_id: {curr_user_id}."')
112+
user_id = curr_user_id
111113

112114
# Note: only called once when the user interacts with the CLI for the
113115
# first time iff the permission is granted.

tests/comfy_cli/test_tracking.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,11 @@ def test_disable_persists_as_parseable_bool(self, tracking_module):
8787
def test_enable_generates_user_id(self, tracking_module):
8888
assert tracking_module.config_manager.get(constants.CONFIG_KEY_USER_ID) is None
8989
tracking_module.init_tracking(True)
90-
assert tracking_module.config_manager.get(constants.CONFIG_KEY_USER_ID) is not None
90+
generated_user_id = tracking_module.config_manager.get(constants.CONFIG_KEY_USER_ID)
91+
assert generated_user_id is not None
92+
assert tracking_module.user_id == generated_user_id
93+
_, kwargs = tracking_module.mp.track.call_args
94+
assert kwargs["distinct_id"] == generated_user_id
9195

9296
def test_disable_does_not_generate_user_id(self, tracking_module):
9397
tracking_module.init_tracking(False)

0 commit comments

Comments
 (0)