Skip to content

Fix Windows Unicode error in node commands #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robinjhuang merged 2 commits into from
May 29, 2025
Merged

Fix Windows Unicode error in node commands #277

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e02d25
Fix Windows Unicode error in node commands
robinjhuang May 29, 2025
69a4d69
Format.
robinjhuang May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion comfy_cli/command/custom_nodes/cm_cli_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@
print(f"Execute from: {workspace_path}")

try:
result = subprocess.run(cmd, env=new_env, check=True, capture_output=True, text=True)
result = subprocess.run(

Check warning on line 60 in comfy_cli/command/custom_nodes/cm_cli_util.py

View check run for this annotation

Codecov / codecov/patch

comfy_cli/command/custom_nodes/cm_cli_util.py#L60 

Added line #L60 was not covered by tests
cmd, env=new_env, check=True, capture_output=True, text=True, encoding="utf-8", errors="replace"
)
print(result.stdout)

if fast_deps and args[0] in _dependency_cmds:
Expand Down