feat: refactor env command to use ui.display_table for consistent table display#286
Merged
Conversation
Member
|
Seems like a reasonable change. @bigcat88 Can you take a look? |
bigcat88
requested changes
Jul 27, 2025
bigcat88
left a comment
Contributor
There was a problem hiding this comment.
Overall the PR is good (tested locally), but some small changes need to be made.
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
|
thanks for the changes, can you remove the last unused import that |
Contributor
Author
|
sure, just removed it |
bigcat88
approved these changes
Aug 1, 2025
Contributor
|
thanks for this contribution |
Contributor
|
Nice cleanup and unification. Good job! 👍 |
Contributor
Author
|
thx guys🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Updated the
comfy envcommand to use our existingui.display_table()function instead of manually creating Rich Table objects.Why
Changes made
EnvChecker.fill_print_table()to return data tuples instead of creating a tableWorkspaceManager.fill_print_table()to return data tuples tooui.display_table()The output looks exactly the same to users.