add PR support#287
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Strengths
- Excellent test coverage (376 lines of tests)
- Clean separation of concerns
- Good error handling with rich formatting
- Handles both fork and same-repo PRs correctly
Possible Improvements
Critical:
- Parameter validation bug (cmdline.py:348): The condition
version != "nightly" or commitwill be true if version is None, preventing valid use cases. Should beversion not in {None, "nightly"} or commit.
Important:
- Timestamp formatting (install.py:381): The reset_time is displayed as a Unix timestamp instead of human-readable format.
- Deleted fork handling (install.py:579): Missing null check will cause KeyError if PR is from a deleted fork.
- Branch name sanitization (git_utils.py:87): Git will reject branch names with special characters.
Suggestions:
- Docstring placement (install.py:184): Move docstring before code execution.
- Remote naming (git_utils.py:70): Consider using
pr-{number}-{user}to avoid conflicts when checking out multiple PRs from same author.
Collaborator
Author
|
@christian-byrne fixed your feedback except Timestamp formatting, this is an existing code used in checkout version, I just move it into a function could be shared in my new logic |
jtydhr88
commented
Jun 24, 2025
Collaborator
Author
|
btw, regarding to failing test, I checked it and likely failed on download something on the MAC machine, not caused by my changes I believe |
christian-byrne
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bounty task https://www.notion.so/drip-art/Add-Comfy-CLI-feature-to-check-out-a-single-PR-launch-comfy-and-run-a-set-of-tests-1f36d73d36508074b1c3fc56d13f4346?source=copy_link
add --pr arg, support format:
"username:branch-name""#123""https://github.com/comfyanonymous/ComfyUI/pull/123"full command:
comfy --workspace=G:\comfy-cli-test install --pr "https://github.com/comfyanonymous/ComfyUI/pull/8597"then
comfy --workspace=G:\comfy-cli-test launch