Skip to content

Update install.py for Intel Arc GPUs#319

Merged
bigcat88 merged 2 commits into
Comfy-Org:mainfrom
qiacheng:patch-1
Sep 17, 2025
Merged

Update install.py for Intel Arc GPUs#319
bigcat88 merged 2 commits into
Comfy-Org:mainfrom
qiacheng:patch-1

Conversation

@qiacheng

Copy link
Copy Markdown
Contributor

update installation for Intel Arc GPUs utilizing upstream torch xpu.

Comfy-Org/ComfyUI#7767

update installation for Intel Arc GPUs utilizing upstream torch xpu.

Comfy-Org/ComfyUI#7767
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Sep 16, 2025
@qiacheng

Copy link
Copy Markdown
Contributor Author
image

tested on Intel Arc, with latest torch 2.8.0+xpu installed

@codecov

codecov Bot commented Sep 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   50.84%   50.87%   +0.02%     
==========================================
  Files          32       32              
  Lines        3446     3444       -2     
==========================================
  Hits         1752     1752              
+ Misses       1694     1692       -2     
Files with missing lines Coverage Δ
comfy_cli/command/install.py 57.92% <100.00%> (+0.25%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bigcat88

Copy link
Copy Markdown
Contributor

Hello @qiacheng , thanks for this PR.

Please fix the ruff warning and we can merge it.

@bigcat88 bigcat88 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve in advance

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Sep 17, 2025
@qiacheng

Copy link
Copy Markdown
Contributor Author

ruff check --fix install.py done

@bigcat88 bigcat88 merged commit 4de0975 into Comfy-Org:main Sep 17, 2025
11 checks passed
@qiacheng qiacheng deleted the patch-1 branch September 18, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants