Fix unnecessary full file download when checking URL authorization#320
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #320 +/- ##
=======================================
Coverage 50.87% 50.87%
=======================================
Files 32 32
Lines 3444 3444
=======================================
Hits 1752 1752
Misses 1692 1692
🚀 New features to boost your workflow:
|
bigcat88
approved these changes
Sep 26, 2025
Contributor
bigcat88
left a comment
There was a problem hiding this comment.
Nice work on this, and thank you for the fix. Merging this now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a bug when running
comfy-cli model download --url https://huggingface.co/Comfy-Org/flux1-schnell/resolve/main/flux1-schnell-fp8.safetensorsit will fully download the model first before going into
download_file(url, local_filepath, headers).Model gets downloaded twice, first time was to verify hf repo access, and second time was the actual download.
simple fix is to add
stream=Trueto requests.get incheck_unauthorized()to prevent full file download