Skip to content

Fix Python 3.14 compatibility and the built-in list redefinition #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fengsi wants to merge 1 commit into from
Closed

Fix Python 3.14 compatibility and the built-in list redefinition #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions comfy_cli/command/models/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import os
import pathlib
import sys
from typing import Annotated, Optional
from typing import Annotated, List, Optional
from urllib.parse import parse_qs, unquote, urlparse

import requests
Expand Down Expand Up @@ -339,7 +339,7 @@ def remove(
help="The relative path from the current workspace where the models are stored.",
show_default=True,
),
model_names: Optional[list[str]] = typer.Option(
model_names: Optional[List[str]] = typer.Option(
None,
help="List of model filenames to delete, separated by spaces",
show_default=False,
Expand Down Expand Up @@ -394,6 +394,11 @@ def remove(
typer.echo("Deletion canceled.")


def list_models(path: pathlib.Path) -> list:

@fengsi fengsi Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No functional change here, but if we were to redefine the built-in list, we'll need to make sure that any possible references to list should happen before the def list() function.

@fengsi fengsi Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No functional change here, but if we were to redefine the built-in list, we'll need to make sure that any possible references to list should happen before the def list() function.

Addressed separately in #330.

"""List all models in the specified directory."""
return [file for file in path.iterdir() if file.is_file()]


@app.command()
@tracking.track_command("model")
def list(
Expand All @@ -416,8 +421,3 @@ def list(
data = [(model.name, f"{model.stat().st_size // 1024} KB") for model in models]
column_names = ["Model Name", "Size"]
ui.display_table(data, column_names)


def list_models(path: pathlib.Path) -> list:
"""List all models in the specified directory."""
return [file for file in path.iterdir() if file.is_file()]