fix: support PEP 639 SPDX license identifiers in pyproject.toml#383
Merged
Conversation
e3f6526 to
dc40eff
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #383 +/- ##
==========================================
- Coverage 63.92% 63.89% -0.03%
==========================================
Files 33 33
Lines 3703 3700 -3
==========================================
- Hits 2367 2364 -3
Misses 1336 1336
🚀 New features to boost your workflow:
|
dc40eff to
de52607
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the modern PEP 639 SPDX license format like
license = "MIT"in pyproject.toml would trigger a spurious warning asking users to switch to the deprecatedlicense = {file = "LICENSE"}format. The parser already handled string licenses correctly internally, it just warned about them unnecessarily.Removed the warning for string license values since
license = "MIT"is the current recommended format per PEP 639. Also updatedcomfy node initto generatelicense = "MIT"instead oflicense = {file = "LICENSE"}in new pyproject.toml files. The deprecated dict formats ({file = "..."}and{text = "..."}) continue to work without warnings.Fixes #295