Skip to content

fix: support PEP 639 SPDX license identifiers in pyproject.toml#383

Merged
bigcat88 merged 1 commit into
mainfrom
fix/spdx-license-support
Mar 15, 2026
Merged

fix: support PEP 639 SPDX license identifiers in pyproject.toml#383
bigcat88 merged 1 commit into
mainfrom
fix/spdx-license-support

Conversation

@bigcat88
Copy link
Copy Markdown
Contributor

Using the modern PEP 639 SPDX license format like license = "MIT" in pyproject.toml would trigger a spurious warning asking users to switch to the deprecated license = {file = "LICENSE"} format. The parser already handled string licenses correctly internally, it just warned about them unnecessarily.

Removed the warning for string license values since license = "MIT" is the current recommended format per PEP 639. Also updated comfy node init to generate license = "MIT" instead of license = {file = "LICENSE"} in new pyproject.toml files. The deprecated dict formats ({file = "..."} and {text = "..."}) continue to work without warnings.

Fixes #295

@bigcat88 bigcat88 force-pushed the fix/spdx-license-support branch from e3f6526 to dc40eff Compare March 15, 2026 08:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   63.92%   63.89%   -0.03%     
==========================================
  Files          33       33              
  Lines        3703     3700       -3     
==========================================
- Hits         2367     2364       -3     
  Misses       1336     1336              
Files with missing lines Coverage Δ
comfy_cli/registry/config_parser.py 93.42% <100.00%> (-0.13%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bigcat88 bigcat88 force-pushed the fix/spdx-license-support branch from dc40eff to de52607 Compare March 15, 2026 08:40
@bigcat88 bigcat88 marked this pull request as ready for review March 15, 2026 08:54
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 15, 2026
@bigcat88 bigcat88 merged commit f75c545 into main Mar 15, 2026
13 checks passed
@bigcat88 bigcat88 deleted the fix/spdx-license-support branch March 15, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for modern license entries in pyproject.toml

1 participant