fix: handle websocket errors gracefully in comfy run#384
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #384 +/- ##
==========================================
+ Coverage 63.89% 66.59% +2.70%
==========================================
Files 33 33
Lines 3700 3706 +6
==========================================
+ Hits 2364 2468 +104
+ Misses 1336 1238 -98
🚀 New features to boost your workflow:
|
31f8cd2 to
72ac5b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
comfy run --workflowwith long-running workflows, websocket errors (timeouts, connection drops) would crash with unhandled Python tracebacks. This made it hard to understand what went wrong and how to fix it.Added exception handling in
execute()forWebSocketTimeoutExceptionand generalWebSocketException/ConnectionError. Timeout errors now print a clear message with a hint to increase--timeout. Connection drops print the specific error reason. Both exit cleanly with code 1 and properly clean up the progress bar.Tested against a local ComfyUI instance with forced timeout (0.001s), forced connection drop (socket shutdown mid-execution), and normal workflow completion. All three paths produce clean output instead of tracebacks.
Fixes #200