Add i18n ESLint plugin configuration by snomiao · Pull Request #211 · Comfy-Org/registry-web

snomiao · 2025-08-18T17:22:43Z

Summary

Install and configure eslint-plugin-i18n-json for validation of i18n JSON translation files
Add ESLint rules for i18n JSON files validation
Set up required directory structure for plugin functionality
Run ESLint fix to apply automated fixes

Changes

Added eslint-plugin-i18n-json as dev dependency
Updated .eslintrc.json with i18n validation rules:
- i18n-json/valid-json: Error for invalid JSON syntax
- i18n-json/sorted-keys: Warning for unsorted translation keys
- i18n-json/identical-keys: Error for inconsistent keys across locales
Created required directory structure and configuration files

Test plan

ESLint runs successfully without errors
Plugin validates translation JSON files in locales/ directory
Automated fixes are applied via bun run fix

🤖 Generated with Claude Code

vercel · 2025-08-18T17:22:49Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
registry-web	Error			Oct 26, 2025 7:57am

Copilot

Pull Request Overview

This pull request adds internationalization (i18n) validation to the project by installing and configuring the eslint-plugin-i18n-json plugin to validate JSON translation files.

Installs eslint-plugin-i18n-json as a development dependency
Configures ESLint rules for JSON translation validation with error and warning levels
Creates required configuration files for the i18n plugin functionality

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
package.json	Adds eslint-plugin-i18n-json as dev dependency
.eslintrc.json	Configures i18n ESLint rules for JSON validation
translations/static-label-pairing.js	Creates empty configuration file for static label pairing
translations/static-label-pairing.cjs	Creates CommonJS version of static label pairing config
src/components/lib/i18n/translations/en.json	Adds comprehensive English translation file with 399 translation keys

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

github-actions · 2025-08-18T17:24:36Z

🎨 Chromatic Visual Testing Results

Resource	URL
🔍 Build Results	Chromatic Build
📚 Storybook	View Storybook

Check the visual changes and approve or request changes as needed.

socket-security · 2025-08-18T17:25:08Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

github-actions · 2025-08-18T17:28:15Z

🎨 Chromatic Visual Testing Results

Resource	URL
🔍 Build Results	Chromatic Build
📚 Storybook	View Storybook

Check the visual changes and approve or request changes as needed.

github-actions · 2025-08-19T07:08:22Z

🎨 Chromatic Visual Testing Results

Resource	URL
🔍 Build Results	Chromatic Build
📚 Storybook	View Storybook

Check the visual changes and approve or request changes as needed.

socket-security · 2025-08-21T12:06:04Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@spaced-out/eslint-plugin-i18n@3.0.8

View full report

snomiao · 2025-08-19T13:30:12Z

                                            ? `…${e.file_path?.slice(-18)}`
                                            : e.file_path}
-                                        &nbsp;L{e.line_number}
+                                        {t('L', 'L')}


L{{number}}

snomiao · 2025-08-22T08:58:07Z

let sno try to remove src/components/lib/i18n/translations/en.json if possible, or add a readme for src/components/lib/i18n/translations/en.json in src/components/lib/i18n/translations/README.md

- Install eslint-plugin-i18n-json for JSON translation file validation - Configure ESLint rules for i18n JSON files: - valid-json: Error for invalid JSON syntax - sorted-keys: Warning for unsorted translation keys - identical-keys: Error for inconsistent keys across locales - Set up required directory structure and files - Run ESLint fix to apply automated fixes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

- Added eslint-plugin-i18n-json package to enforce i18n JSON file standards - Configured ESLint rules for JSON validation, key sorting, and consistency - Fixed React hooks dependency warning in claim-my-node component - Verified linting and build processes work correctly 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

…-json - Replaced eslint-plugin-i18n-json with @spaced-out/eslint-plugin-i18n v3.0.5 - Created required configuration files for the plugin to work properly - Added translations/static-label-pairing.cjs for plugin compatibility - Created symlink to existing translation files in expected location - Configured ESLint with missing-translation rule for i18n validation - Fixed React hooks dependencies warning in claim-my-node component - Verified both lint and build processes work correctly 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

- Replace .eslintrc.json with .eslintrc.yaml for better readability - Configure @spaced-out/i18n plugin with progressive enablement approach - Update scan-i18n.ts to support default values in translation keys - Add support for t(key, defaultValue) pattern - Improve translation key extraction with better error handling 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

Applied ESLint fixes to ensure proper internationalization patterns across the codebase using @spaced-out/eslint-plugin-i18n. This enforces consistent usage of translation functions and prevents hardcoded text strings. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

…ionalization support in status badge component feat(NodeStatusReason): integrate useNextTranslation hook for internationalization support in YAML components

…nto separate functional components for better readability and maintainability

- Remove unnecessary ESM export since ESLint plugin uses require() - Use .cjs extension for proper CommonJS handling in ES module project - Create .js symlink for plugin compatibility (plugin expects .js path) - Keep only the format that's actually used by the ESLint plugin Result: Cleaner, single-format configuration file. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

- Update NodeVersionCompatibilityEditModal.tsx to use proper i18n interpolation - Disable i18n static label checks in MockFeaturedPage.stories.tsx

github-actions · 2025-09-22T10:38:50Z

🎨 Chromatic Visual Testing Results

Resource	URL
🔍 Build Results	Chromatic Build
📚 Storybook	View Storybook

Check the visual changes and approve or request changes as needed.

- Update plugin references from @spaced-out/eslint-plugin-i18n to eslint-plugin-i18n-json in static-label-pairing files - Fix NodeStatusReason L{{number}} interpolation to use proper i18next format 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

- Remove unused src/components/lib/i18n/translations/en.json symlink pointing to locales/en/common.json - Remove unused translations/static-label-pairing.js symlink pointing to static-label-pairing.cjs - Clean up empty directories left behind These symlinks were creating file duplications in the repository without being used. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

Merged latest changes from main branch and resolved conflicts in: - components/NodeStatusBadge.tsx: Combined i18n import with NodeVersionStatus import - components/common/LanguageSwitcher.tsx: Kept both i18n changes and modal contributions - package.json: Merged biome scripts with i18n eslint plugin - src/stories/*.tsx: Combined i18n imports with new imports from main All conflicts resolved by keeping both sets of changes where applicable. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

- Merged latest changes from main branch - Updated all locale files (ar, es, fr, ja, ko, ru, tr, zh) - Added README.md explaining why en.json exists as a placeholder - The @spaced-out/eslint-plugin-i18n plugin requires en.json at src/components/lib/i18n/translations/en.json (hardcoded path) - Actual translations remain in ./locales/ directory 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

ESLint auto-fix added t() calls but the import was missing, causing TypeScript build errors. This commit adds the necessary import and hook usage. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings August 18, 2025 17:22

Copilot AI reviewed Aug 18, 2025

View reviewed changes

Comment thread translations/static-label-pairing.js Outdated

Comment thread translations/static-label-pairing.cjs Outdated

vercel Bot deployed to Preview August 18, 2025 17:24 View deployment

vercel Bot deployed to Preview August 18, 2025 17:26 View deployment

vercel Bot deployed to Preview August 18, 2025 17:28 View deployment

vercel Bot deployed to Preview August 19, 2025 07:09 View deployment

vercel Bot had a problem deploying to Preview August 19, 2025 10:02 Failure

vercel Bot had a problem deploying to Preview August 21, 2025 11:58 Failure

vercel Bot had a problem deploying to Preview August 21, 2025 12:06 Failure

vercel Bot had a problem deploying to Preview August 21, 2025 12:13 Failure

snomiao commented Aug 21, 2025

View reviewed changes

vercel Bot had a problem deploying to Preview August 21, 2025 14:03 Failure

vercel Bot had a problem deploying to Preview August 21, 2025 14:08 Failure

snomiao commented Aug 22, 2025

View reviewed changes

Comment thread components/NodeStatusReason.tsx Outdated

Comment thread src/components/lib/i18n/translations/en.json Outdated

snomiao and others added 9 commits September 22, 2025 10:25

format: Apply prettier --fix changes

b931626

format: Apply prettier --fix changes

9b20f24

feat(NodeStatusBadge): integrate useNextTranslation hook for internat…

9e2df85

…ionalization support in status badge component feat(NodeStatusReason): integrate useNextTranslation hook for internationalization support in YAML components

refactor(Container.stories.tsx): extract inline children components i…

1c0076a

…nto separate functional components for better readability and maintainability

snomiao force-pushed the sno-i18n-eslint branch from c5ba12a to 72b8f49 Compare September 22, 2025 10:27

vercel Bot had a problem deploying to Preview September 22, 2025 10:27 Failure

fix: resolve ESLint i18n errors in build

be0f126

- Update NodeVersionCompatibilityEditModal.tsx to use proper i18n interpolation - Disable i18n static label checks in MockFeaturedPage.stories.tsx

vercel Bot deployed to Preview September 22, 2025 10:38 View deployment

format: Apply prettier --fix changes

f7232e4

vercel Bot deployed to Preview September 22, 2025 10:45 View deployment

vercel Bot deployed to Preview September 22, 2025 23:09 View deployment

vercel Bot deployed to Preview September 23, 2025 00:17 View deployment

snomiao force-pushed the sno-i18n-eslint branch from 827742a to 0281ed9 Compare September 23, 2025 00:20

vercel Bot deployed to Preview September 23, 2025 00:24 View deployment

Merge main into sno-i18n-eslint

c43cdd4

vercel Bot deployed to Preview October 2, 2025 14:40 View deployment

snomiao marked this pull request as draft October 14, 2025 21:51

snomiao self-assigned this Oct 14, 2025

vercel Bot had a problem deploying to Preview October 20, 2025 17:56 Failure

format: Apply prettier --fix changes

06fe51c

vercel Bot had a problem deploying to Preview October 20, 2025 17:58 Failure

vercel Bot had a problem deploying to Preview October 25, 2025 13:39 Failure

vercel Bot had a problem deploying to Preview October 25, 2025 13:51 Failure

format: Apply prettier --fix changes

b98149a

vercel Bot had a problem deploying to Preview October 25, 2025 13:59 Failure

format: Apply bun fmt formatting changes after biome.json update

130760e

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

vercel Bot had a problem deploying to Preview October 26, 2025 07:57 Failure

Uh oh!

Conversation

snomiao commented Aug 18, 2025

Summary

Changes

Test plan

Uh oh!

vercel Bot commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 18, 2025

🎨 Chromatic Visual Testing Results

Uh oh!

socket-security Bot commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 18, 2025

🎨 Chromatic Visual Testing Results

Uh oh!

github-actions Bot commented Aug 19, 2025

🎨 Chromatic Visual Testing Results

Uh oh!

socket-security Bot commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

snomiao Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

snomiao commented Aug 22, 2025

Uh oh!

github-actions Bot commented Sep 22, 2025

🎨 Chromatic Visual Testing Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Aug 18, 2025 •

edited

Loading

socket-security Bot commented Aug 18, 2025 •

edited

Loading

socket-security Bot commented Aug 21, 2025 •

edited

Loading