Commit 10bd397
committed
[web] fix user profile long username bug
Summary:
This diff fixes the bug where we had text overflow with longer usernames. To address this I introduced a version of `SingleLine` for `web`.
For context here is the `native` version of `SingleLine`
https://github.com/CommE2E/comm/blob/master/native/components/single-line.react.js
Linear task: https://linear.app/comm/issue/ENG-5372/fix-user-profiles-for-long-usernames
Test Plan:
Please see screenshots below
Before:
{F837885}
after:
{F837886}
Reviewers: atul, inka
Reviewed By: atul
Subscribers: ted, ashoat, tomek, wyilio
Differential Revision: https://phab.comm.dev/D96041 parent 2957186 commit 10bd397
4 files changed
Lines changed: 34 additions & 2 deletions
File tree
- web
- components
- modals/user-profile
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
65 | 66 | | |
66 | 67 | | |
67 | 68 | | |
68 | | - | |
| 69 | + | |
69 | 70 | | |
70 | 71 | | |
71 | 72 | | |
| |||
0 commit comments