Skip to content

Commit 5304f6c

Browse files
JasonVranekPedroCM96
authored andcommitted
Merge remote-tracking branch 'origin/main' into pr-465
1 parent 56a85a1 commit 5304f6c

106 files changed

Lines changed: 8992 additions & 1990 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.cargo/audit.toml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# RUSTSEC-2026-0049: CRL revocation checking bug in rustls-webpki 0.101.7.
2+
#
3+
# Background: CRL (Certificate Revocation List) checking is an optional TLS
4+
# feature where a client fetches a list of revoked certificates from URLs
5+
# embedded in the cert itself, to confirm it hasn't been invalidated since
6+
# issuance. This is distinct from normal certificate validation.
7+
#
8+
# The bug: when a cert lists multiple CRL distribution point URLs, only the
9+
# first URL is checked; the rest are silently ignored. This matters only when
10+
# CRL checking is enabled AND the UnknownStatusPolicy is set to Allow (meaning
11+
# "if I can't determine revocation status, accept the cert anyway"). With that
12+
# combination, a revoked certificate from a compromised CA could be accepted.
13+
#
14+
# Why this does not affect Commit-Boost: the vulnerable code path is never
15+
# reached because no code in this codebase enables CRL checking at all.
16+
# TLS is used in four places: (1) relay communication via reqwest with
17+
# rustls-tls uses default CA validation with no CRL configured; (2) the signer
18+
# server presents a TLS certificate but does not check client revocation;
19+
# (3) the signer client pins a single self-signed certificate via
20+
# add_root_certificate — CRL is irrelevant for self-signed certs; (4) the Dirk
21+
# remote signer uses mTLS with a custom CA but again no CRL. In all cases the
22+
# buggy CRL code in rustls-webpki is never invoked.
23+
#
24+
# Blocked on sigp/lighthouse upgrading past v8.0.1 without a compilation
25+
# regression (SseEventSource missing cfg guard in eth2 error.rs).
26+
[advisories]
27+
ignore = ["RUSTSEC-2026-0049"]

.github/workflows/release.yml

Lines changed: 13 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
12
name: Draft Release
23

34
on:
@@ -72,7 +73,7 @@ jobs:
7273
VALUE=$(python .github/workflows/release/release.py is-latest "${{ inputs.tag }}")
7374
echo "value=$VALUE" >> $GITHUB_OUTPUT
7475
75-
# Builds the x64 and arm64 binaries for Linux, for all 3 crates, via the Docker builder
76+
# Builds the x64 and arm64 binaries for Linux via the Docker builder
7677
build-binaries-linux:
7778
needs: [resolve-tag]
7879
timeout-minutes: 60
@@ -83,20 +84,14 @@ jobs:
8384
- amd64
8485
- arm64
8586
name:
86-
- commit-boost-cli
87-
- commit-boost-pbs
88-
- commit-boost-signer
87+
- commit-boost
8988
include:
9089
- target: amd64
9190
package-suffix: x86-64
9291
- target: arm64
9392
package-suffix: arm64
94-
- name: commit-boost-cli
95-
target-crate: cli
96-
- name: commit-boost-pbs
97-
target-crate: pbs
98-
- name: commit-boost-signer
99-
target-crate: signer
93+
- name: commit-boost
94+
target-crate: commit-boost
10095
runs-on: ubuntu-latest
10196
steps:
10297
- name: Checkout code
@@ -150,7 +145,7 @@ jobs:
150145
path: |
151146
${{ matrix.name }}-${{ inputs.tag }}-linux_${{ matrix.package-suffix }}.tar.gz
152147
153-
# Builds the arm64 binaries for Darwin, for all 3 crates, natively
148+
# Builds the arm64 binary for Darwin natively
154149
build-binaries-darwin:
155150
needs: [resolve-tag]
156151
timeout-minutes: 60
@@ -162,9 +157,7 @@ jobs:
162157
# - x86_64-apple-darwin
163158
- aarch64-apple-darwin
164159
name:
165-
- commit-boost-cli
166-
- commit-boost-pbs
167-
- commit-boost-signer
160+
- commit-boost
168161
include:
169162
# - target: x86_64-apple-darwin
170163
# os: macos-latest-large
@@ -237,7 +230,7 @@ jobs:
237230
packages: write
238231
strategy:
239232
matrix:
240-
crate: [pbs, signer]
233+
crate: [pbs, signer, commit-boost]
241234
runs-on: ubuntu-latest
242235
timeout-minutes: 45
243236
steps:
@@ -252,16 +245,16 @@ jobs:
252245
uses: actions/download-artifact@v4
253246
with:
254247
path: ./artifacts
255-
pattern: "commit-boost-*"
248+
pattern: "commit-boost*"
256249

257250
- name: Extract binaries
258251
run: |
259252
mkdir -p ./artifacts/bin/linux_amd64
260253
mkdir -p ./artifacts/bin/linux_arm64
261-
tar -xzf ./artifacts/commit-boost-${{ matrix.crate }}-${{ inputs.tag }}-linux_x86-64/commit-boost-${{ matrix.crate }}-${{ inputs.tag }}-linux_x86-64.tar.gz -C ./artifacts/bin
262-
mv ./artifacts/bin/commit-boost-${{ matrix.crate }} ./artifacts/bin/linux_amd64/commit-boost-${{ matrix.crate }}
263-
tar -xzf ./artifacts/commit-boost-${{ matrix.crate }}-${{ inputs.tag }}-linux_arm64/commit-boost-${{ matrix.crate }}-${{ inputs.tag }}-linux_arm64.tar.gz -C ./artifacts/bin
264-
mv ./artifacts/bin/commit-boost-${{ matrix.crate }} ./artifacts/bin/linux_arm64/commit-boost-${{ matrix.crate }}
254+
tar -xzf ./artifacts/commit-boost-${{ inputs.tag }}-linux_x86-64/commit-boost-${{ inputs.tag }}-linux_x86-64.tar.gz -C ./artifacts/bin
255+
mv ./artifacts/bin/commit-boost ./artifacts/bin/linux_amd64/commit-boost
256+
tar -xzf ./artifacts/commit-boost-${{ inputs.tag }}-linux_arm64/commit-boost-${{ inputs.tag }}-linux_arm64.tar.gz -C ./artifacts/bin
257+
mv ./artifacts/bin/commit-boost ./artifacts/bin/linux_arm64/commit-boost
265258
266259
- name: Set lowercase owner
267260
run: echo "OWNER=$(echo '${{ github.repository_owner }}' | tr '[:upper:]' '[:lower:]')" >> $GITHUB_ENV

.gitignore

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,19 @@ targets.json
1616
.idea/
1717
logs
1818
.vscode/
19+
certs/
1920

2021
# Python (release scripts under .github/workflows/release/)
2122
__pycache__/
2223
*.pyc
2324
.pytest_cache/
25+
# Nix
26+
.direnv/
27+
.devenv/
28+
devenv.*
29+
devenv.lock
30+
.devenv.flake.nix
31+
.envrc
32+
33+
# Generated from testnet
34+
kurtosis-dump

.releases/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ Example verification flow:
7373
export REPO=Commit-Boost/commit-boost-client
7474
export VERSION=vX.Y.Z
7575
export ARCH=linux_x86-64
76-
export BIN=commit-boost-pbs
76+
export BIN=commit-boost
7777
7878
curl -L \
7979
-o "$BIN-$VERSION-$ARCH.tar.gz" \
@@ -87,7 +87,7 @@ cosign verify-blob \
8787
"$BIN-$VERSION-$ARCH.tar.gz" \
8888
--bundle "$BIN-$VERSION-$ARCH.tar.gz.sigstore.json" \
8989
--certificate-oidc-issuer="https://token.actions.githubusercontent.com" \
90-
--certificate-identity="https://github.com/Commit-Boost/commit-boost-client/.github/workflows/release.yml@refs/heads/main"
90+
--certificate-identity="https://github.com/$REPO/.github/workflows/release.yml@refs/heads/main"
9191
```
9292

9393
To verify assets from a fork, replace `REPO` with the fork path, for example:

0 commit comments

Comments
 (0)